| Message ID | 20190725171215.71801-1-kevin.brodsky@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: fast models: Remove clcd's max-memory-bandwidth | expand |
On Thu, Jul 25, 2019 at 06:12:14PM +0100, Kevin Brodsky wrote: > It is unclear why max-memory-bandwidth should be set for CLCD on the > fast model. Removing that property allows allocating and using 32bpp > buffers, which may be desirable on certain platforms such as > Android. > > Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com> > Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com> > --- > > Changes in v2: > - Remove the attribute completely instead of increasing its value. It is > optional and there is no clear reason why it should be set at all. > > arch/arm64/boot/dts/arm/fvp-base-revc.dts | 8 -------- > arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi | 2 -- I was about to ask about the above file in v1, and then saw v2. I will take this for v5.4. Thanks -- Regards, Sudeep
On Thu, Jul 25, 2019 at 7:12 PM Kevin Brodsky <kevin.brodsky@arm.com> wrote: > It is unclear why max-memory-bandwidth should be set for CLCD on the > fast model. Removing that property allows allocating and using 32bpp > buffers, which may be desirable on certain platforms such as > Android. > > Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com> > Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts index 687707020ec1..62ab0d54ff71 100644 --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts @@ -265,13 +265,5 @@ <0 0 42 &gic 0 0 GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>, <0 0 43 &gic 0 0 GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>, <0 0 44 &gic 0 0 GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; - - motherboard { - iofpga@3,00000000 { - clcd@1f0000 { - max-memory-bandwidth = <130000000>; /* 16bpp @ 63.5MHz */ - }; - }; - }; }; }; diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi index 454cf6c44c49..03a7bf079c8f 100644 --- a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi +++ b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi @@ -188,8 +188,6 @@ interrupts = <14>; clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; clock-names = "clcdclk", "apb_pclk"; - /* 800x600 16bpp @36MHz works fine */ - max-memory-bandwidth = <54000000>; memory-region = <&vram>; port {
It is unclear why max-memory-bandwidth should be set for CLCD on the fast model. Removing that property allows allocating and using 32bpp buffers, which may be desirable on certain platforms such as Android. Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com> --- Changes in v2: - Remove the attribute completely instead of increasing its value. It is optional and there is no clear reason why it should be set at all. arch/arm64/boot/dts/arm/fvp-base-revc.dts | 8 -------- arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi | 2 -- 2 files changed, 10 deletions(-)