diff mbox series

[16/28] ASoC: soc-core: initialize rtd->list

Message ID	87ef1z2ife.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <alsa-devel-bounces@alsa-project.org> Date: 06 Aug 2019 10:29:54 +0900 Message-ID: <87ef1z2ife.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown <broonie@kernel.org> In-Reply-To: <871rxz3x7e.wl-kuninori.morimoto.gx@renesas.com> References: <871rxz3x7e.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA <alsa-devel@alsa-project.org> Subject: [alsa-devel] [PATCH 16/28] ASoC: soc-core: initialize rtd->list Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" <alsa-devel-bounces@alsa-project.org>
Series	ASoC: cleanup patches for soc-core \| expand [00/28] ASoC: cleanup patches for soc-core [01/28] ASoC: soc-core: use device_register() [02/28] ASoC: soc-core: set component->debugfs_root NULL [03/28] ASoC: soc-core: add comment for for_each_xxx [04/28] ASoC: soc-core: check return value of snd_soc_add_dai_link() [05/28] ASoC: soc-core: don't use for_each_card_links_safe() at snd_soc_find_dai_link() [06/28] ASoC: soc-core: reuse rtdcom at snd_soc_rtdcom_add() [07/28] ASoC: soc-core: don't check widget for snd_soc_dapm_new_controls() [08/28] ASoC: soc-core: don't check controls for snd_soc_add_component_controls() [09/28] ASoC: soc-core: don't check routes for snd_soc_dapm_add_routes() [10/28] ASoC: soc-core: don't check controls for snd_soc_add_card_controls() [11/28] ASoC: soc-core: call snd_soc_dapm_debugfs_init() at soc_init_card_debugfs() [12/28] ASoC: soc-core: remove unneeded list_empty() check for snd_soc_try_rebind_card() [13/28] ASoC: soc-core: remove verbose debug message from soc_bind_dai_link() [14/28] ASoC: soc-core: remove duplicated soc_is_dai_link_bound() [15/28] ASoC: soc-core: tidyup for card->deferred_resume_work [16/28] ASoC: soc-core: initialize rtd->list [17/28] ASoC: soc-core: define soc_dpcm_debugfs_add() for non CONFIG_DEBUG_FS [18/28] ASoC: soc-core: dai_link check under soc_dpcm_debugfs_add() [19/28] ASoC: soc-core: merge snd_soc_initialize_card_lists() [20/28] ASoC: soc-core: remove unneeded dai_link check from snd_soc_remove_dai_link() [21/28] ASoC: soc-core: add NOTE to snd_soc_rtdcom_lookup() [22/28] ASoC: soc-core: don't call snd_soc_component_set_jack() [23/28] ASoC: soc-core: don't alloc memory carelessly when creating debugfs [24/28] ASoC: soc-core: soc_cleanup_card_resources() become void [25/28] ASoC: soc-core: initialize component list [26/28] ASoC: soc-core: initialize list at one place [27/28] ASoC: soc-dai: use bit field for bus_control [28/28] ASoC: soc-topology: use for_each_component_dais() at remove_dai()

Commit Message

Kuninori Morimoto Aug. 6, 2019, 1:29 a.m. UTC

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

No one initialize rtd->list, so far.
Let's do it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ranjani Sridharan Aug. 6, 2019, 5 a.m. UTC | #1

On Tue, 2019-08-06 at 10:29 +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> No one initialize rtd->list, so far.
> Let's do it.
Morimoto-san,

I dont think this is needed. The rtd->list is not meant to be a list
but rather just as a member of the card->rtd_list. So no need to
initialize.

Thanks,
Ranjani
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  sound/soc/soc-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 2536ba4..2347b58 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -354,6 +354,7 @@ static struct snd_soc_pcm_runtime
> *soc_new_pcm_runtime(
>  	if (!rtd)
>  		return NULL;
>  
> +	INIT_LIST_HEAD(&rtd->list);
>  	INIT_LIST_HEAD(&rtd->component_list);
>  	rtd->card = card;
>  	rtd->dai_link = dai_link;

Kuninori Morimoto Aug. 6, 2019, 6:29 a.m. UTC | #2

Hi Ranjani

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > No one initialize rtd->list, so far.
> > Let's do it.
> Morimoto-san,
> 
> I dont think this is needed. The rtd->list is not meant to be a list
> but rather just as a member of the card->rtd_list. So no need to
> initialize.

Thank you for your review !

I will wait other peoples review, and post v2 patch.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

diff mbox series

Patch

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 2536ba4..2347b58 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -354,6 +354,7 @@  static struct snd_soc_pcm_runtime *soc_new_pcm_runtime(
 	if (!rtd)
 		return NULL;
 
+	INIT_LIST_HEAD(&rtd->list);
 	INIT_LIST_HEAD(&rtd->component_list);
 	rtd->card = card;
 	rtd->dai_link = dai_link;