| Message ID | 20190731124000.22072-3-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: add support for the Khadas VIM3 | expand |
On Wed, Jul 31, 2019 at 6:40 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Add a specific compatible for the Amlogic G12B family based S922X SoC > to differentiate with the A311D SoC from the same family. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Rob Herring <robh@kernel.org>
Neil Armstrong <narmstrong@baylibre.com> writes: > Add a specific compatible for the Amlogic G12B family based S922X SoC > to differentiate with the A311D SoC from the same family. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml > index 325c6fd3566d..3c3bc806cd23 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml > @@ -139,6 +139,7 @@ properties: > items: > - enum: > - hardkernel,odroid-n2 > + - const: amlogic,s922x > - const: amlogic,g12b nit: in previous binding docs, we were trying to keep these sorted alphabetically. I'll reorder the new "s922x" after "g12b" when applying. Thanks, Kevin
On Mon, Aug 5, 2019 at 3:46 PM Kevin Hilman <khilman@baylibre.com> wrote: > > Neil Armstrong <narmstrong@baylibre.com> writes: > > > Add a specific compatible for the Amlogic G12B family based S922X SoC > > to differentiate with the A311D SoC from the same family. > > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > --- > > Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml > > index 325c6fd3566d..3c3bc806cd23 100644 > > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml > > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml > > @@ -139,6 +139,7 @@ properties: > > items: > > - enum: > > - hardkernel,odroid-n2 > > + - const: amlogic,s922x > > - const: amlogic,g12b > > nit: in previous binding docs, we were trying to keep these sorted > alphabetically. I'll reorder the new "s922x" after "g12b" when > applying. No, this is not documentation ordering. It's the order compatible strings must be in. Rob
On Mon, Aug 5, 2019 at 4:21 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Aug 5, 2019 at 3:46 PM Kevin Hilman <khilman@baylibre.com> wrote: > > > > Neil Armstrong <narmstrong@baylibre.com> writes: > > > > > Add a specific compatible for the Amlogic G12B family based S922X SoC > > > to differentiate with the A311D SoC from the same family. > > > > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > > --- > > > Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml > > > index 325c6fd3566d..3c3bc806cd23 100644 > > > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml > > > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml > > > @@ -139,6 +139,7 @@ properties: > > > items: > > > - enum: > > > - hardkernel,odroid-n2 > > > + - const: amlogic,s922x > > > - const: amlogic,g12b > > > > nit: in previous binding docs, we were trying to keep these sorted > > alphabetically. I'll reorder the new "s922x" after "g12b" when > > applying. > > No, this is not documentation ordering. It's the order compatible > strings must be in. BTW, you probably should run: make DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amlogic.yaml dtbs_check on your tree regularly. This will catch any errors like this and undocumented boards (but not undocumented SoCs, still too many for me to get that in place). Rob
Rob Herring <robh@kernel.org> writes: > On Mon, Aug 5, 2019 at 3:46 PM Kevin Hilman <khilman@baylibre.com> wrote: >> >> Neil Armstrong <narmstrong@baylibre.com> writes: >> >> > Add a specific compatible for the Amlogic G12B family based S922X SoC >> > to differentiate with the A311D SoC from the same family. >> > >> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> > --- >> > Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml >> > index 325c6fd3566d..3c3bc806cd23 100644 >> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml >> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml >> > @@ -139,6 +139,7 @@ properties: >> > items: >> > - enum: >> > - hardkernel,odroid-n2 >> > + - const: amlogic,s922x >> > - const: amlogic,g12b >> >> nit: in previous binding docs, we were trying to keep these sorted >> alphabetically. I'll reorder the new "s922x" after "g12b" when >> applying. > > No, this is not documentation ordering. It's the order compatible > strings must be in. Ah, thanks for clarifying, Kevin
diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml index 325c6fd3566d..3c3bc806cd23 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.yaml +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml @@ -139,6 +139,7 @@ properties: items: - enum: - hardkernel,odroid-n2 + - const: amlogic,s922x - const: amlogic,g12b ...
Add a specific compatible for the Amlogic G12B family based S922X SoC to differentiate with the A311D SoC from the same family. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+)