| Message ID | 20190805184842.GA8627@embeddedor (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 938a76ed64860b361d73a6d80f78865ffdc7e0ea |
| Headers | show |
| Series | usb: gadget: atmel_usba_udc: Mark expected switch fall-through | expand |
On 05/08/2019 13:48:42-0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: at91_dt_defconfig arm): > > drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 503d275bc4c4..86ffc8307864 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc) > switch (fifo_mode) { > default: > fifo_mode = 0; > + /* fall through */ > case 0: > udc->fifo_cfg = NULL; > n = 0; > -- > 2.22.0 >
On 8/5/19 9:48 PM, Gustavo A. R. Silva wrote: > External E-Mail > > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: at91_dt_defconfig arm): > > drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Cristian Birsan <cristian.birsan@microchip.com> > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 503d275bc4c4..86ffc8307864 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc) > switch (fifo_mode) { > default: > fifo_mode = 0; > + /* fall through */ > case 0: > udc->fifo_cfg = NULL; > n = 0; >
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 503d275bc4c4..86ffc8307864 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc) switch (fifo_mode) { default: fifo_mode = 0; + /* fall through */ case 0: udc->fifo_cfg = NULL; n = 0;
Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: at91_dt_defconfig arm): drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 + 1 file changed, 1 insertion(+)