| Message ID | 20190812235942.7120-1-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire: debugfs support for 5.4 | expand |
On Mon, Aug 12, 2019 at 06:59:39PM -0500, Pierre-Louis Bossart wrote: > This patchset enables debugfs support and corrects all the feedback > provided on an earlier RFC ('soundwire: updates for 5.4') > > There is one remaining hard-coded value in intel.c that will need to > be fixed in a follow-up patchset not specific to debugfs: we need to > remove hard-coded Intel-specific configurations from cadence_master.c > (PDI offsets, etc). > > Changes since v1 (Feedback from GKH) > Handle debugfs in a more self-contained way (no dentry as return or parameter) > Used CONFIG_DEBUG_FS in structures and code to make it easier to > remove if need be. > No functional change for register dumps. Looks much better: Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Mon, Aug 12, 2019 at 06:59:39PM -0500, Pierre-Louis Bossart wrote: > This patchset enables debugfs support and corrects all the feedback > provided on an earlier RFC ('soundwire: updates for 5.4') > > There is one remaining hard-coded value in intel.c that will need to > be fixed in a follow-up patchset not specific to debugfs: we need to > remove hard-coded Intel-specific configurations from cadence_master.c > (PDI offsets, etc). > > Changes since v1 (Feedback from GKH) > Handle debugfs in a more self-contained way (no dentry as return or parameter) > Used CONFIG_DEBUG_FS in structures and code to make it easier to > remove if need be. > No functional change for register dumps. > > Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): > removed error checks > used DEFINE_SHOW_ATTRIBUTE and seq_file > fixed copyright dates > fixed SPDX license info to use GPL2.0 only > fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected > used static inlines for fallback compilation > removed intermediate variables > removed hard-coded constants in loops (used registers offsets and > hardware capabilities) > squashed patch 3 > Changes looks good to me. Acked-by: Sanyog Kale <sanyog.r.kale@intel.com> > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On 12-08-19, 18:59, Pierre-Louis Bossart wrote: > This patchset enables debugfs support and corrects all the feedback > provided on an earlier RFC ('soundwire: updates for 5.4') > > There is one remaining hard-coded value in intel.c that will need to > be fixed in a follow-up patchset not specific to debugfs: we need to > remove hard-coded Intel-specific configurations from cadence_master.c > (PDI offsets, etc). > > Changes since v1 (Feedback from GKH) > Handle debugfs in a more self-contained way (no dentry as return or parameter) > Used CONFIG_DEBUG_FS in structures and code to make it easier to > remove if need be. > No functional change for register dumps. > > Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): > removed error checks > used DEFINE_SHOW_ATTRIBUTE and seq_file > fixed copyright dates > fixed SPDX license info to use GPL2.0 only > fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected > used static inlines for fallback compilation > removed intermediate variables > removed hard-coded constants in loops (used registers offsets and > hardware capabilities) > squashed patch 3 These looks good but failed to apply. Please rebase on soundwire-next and resend Thanks
On 8/16/19 4:43 AM, Vinod Koul wrote: > On 12-08-19, 18:59, Pierre-Louis Bossart wrote: >> This patchset enables debugfs support and corrects all the feedback >> provided on an earlier RFC ('soundwire: updates for 5.4') >> >> There is one remaining hard-coded value in intel.c that will need to >> be fixed in a follow-up patchset not specific to debugfs: we need to >> remove hard-coded Intel-specific configurations from cadence_master.c >> (PDI offsets, etc). >> >> Changes since v1 (Feedback from GKH) >> Handle debugfs in a more self-contained way (no dentry as return or parameter) >> Used CONFIG_DEBUG_FS in structures and code to make it easier to >> remove if need be. >> No functional change for register dumps. >> >> Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): >> removed error checks >> used DEFINE_SHOW_ATTRIBUTE and seq_file >> fixed copyright dates >> fixed SPDX license info to use GPL2.0 only >> fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected >> used static inlines for fallback compilation >> removed intermediate variables >> removed hard-coded constants in loops (used registers offsets and >> hardware capabilities) >> squashed patch 3 > > These looks good but failed to apply. Please rebase on soundwire-next > and resend Could you do us a favor and make sure your soundwire/fixes branch is actually merged in soundwire/next? in this case the Makefile is changed in soundwire/fixes and not in next. If you use git am --3way things work fine and the conflict is resolved. Applying: soundwire: add debugfs support Using index info to reconstruct a base tree... M drivers/soundwire/Makefile M include/linux/soundwire/sdw.h Falling back to patching base and 3-way merge... Auto-merging include/linux/soundwire/sdw.h Auto-merging drivers/soundwire/Makefile Applying: soundwire: cadence_master: add debugfs register dump Applying: soundwire: intel: add debugfs register dump
This patchset enables debugfs support and corrects all the feedback provided on an earlier RFC ('soundwire: updates for 5.4') There is one remaining hard-coded value in intel.c that will need to be fixed in a follow-up patchset not specific to debugfs: we need to remove hard-coded Intel-specific configurations from cadence_master.c (PDI offsets, etc). Changes since v1 (Feedback from GKH) Handle debugfs in a more self-contained way (no dentry as return or parameter) Used CONFIG_DEBUG_FS in structures and code to make it easier to remove if need be. No functional change for register dumps. Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): removed error checks used DEFINE_SHOW_ATTRIBUTE and seq_file fixed copyright dates fixed SPDX license info to use GPL2.0 only fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected used static inlines for fallback compilation removed intermediate variables removed hard-coded constants in loops (used registers offsets and hardware capabilities) squashed patch 3 Pierre-Louis Bossart (3): soundwire: add debugfs support soundwire: cadence_master: add debugfs register dump soundwire: intel: add debugfs register dump drivers/soundwire/Makefile | 4 + drivers/soundwire/bus.c | 6 ++ drivers/soundwire/bus.h | 16 +++ drivers/soundwire/bus_type.c | 3 + drivers/soundwire/cadence_master.c | 107 ++++++++++++++++++++ drivers/soundwire/cadence_master.h | 4 + drivers/soundwire/debugfs.c | 151 +++++++++++++++++++++++++++++ drivers/soundwire/intel.c | 121 +++++++++++++++++++++++ drivers/soundwire/slave.c | 1 + include/linux/soundwire/sdw.h | 8 ++ 10 files changed, 421 insertions(+) create mode 100644 drivers/soundwire/debugfs.c