| Message ID | 20190814043208.15591-2-gaoxiang25@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,1/2] staging: erofs: introduce EFSCORRUPTED and more logs | expand |
On 2019/8/14 12:32, Gao Xiang wrote: > For some specific fields, use ENOTSUPP instead of EIO > for values which look sane but aren't supported right now. > > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> > + return -ENOTSUPP; A little bit confused about when we need to use ENOTSUPP or EOPNOTSUPP, I checked several manual of syscall, it looks EOPNOTSUPP is widely used. Thanks,
Hi Chao, On Wed, Aug 14, 2019 at 05:25:51PM +0800, Chao Yu wrote: > On 2019/8/14 12:32, Gao Xiang wrote: > > For some specific fields, use ENOTSUPP instead of EIO > > for values which look sane but aren't supported right now. > > > > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> > > Reviewed-by: Chao Yu <yuchao0@huawei.com> > > > + return -ENOTSUPP; > > A little bit confused about when we need to use ENOTSUPP or EOPNOTSUPP, I > checked several manual of syscall, it looks EOPNOTSUPP is widely used. It seems that you are right, I didn't notice this. Let me resend this patchset to fix them all... Thanks, Gao Xiang > > Thanks,
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c index 461fd4213ce7..1088cd154efa 100644 --- a/drivers/staging/erofs/inode.c +++ b/drivers/staging/erofs/inode.c @@ -24,7 +24,7 @@ static int read_inode(struct inode *inode, void *data) errln("unsupported data mapping %u of nid %llu", vi->datamode, vi->nid); DBG_BUGON(1); - return -EIO; + return -ENOTSUPP; } if (__inode_version(advise) == EROFS_INODE_LAYOUT_V2) { @@ -95,7 +95,7 @@ static int read_inode(struct inode *inode, void *data) errln("unsupported on-disk inode version %u of nid %llu", __inode_version(advise), vi->nid); DBG_BUGON(1); - return -EIO; + return -ENOTSUPP; } if (!nblks) diff --git a/drivers/staging/erofs/zmap.c b/drivers/staging/erofs/zmap.c index 16b3625604f4..f955d0752792 100644 --- a/drivers/staging/erofs/zmap.c +++ b/drivers/staging/erofs/zmap.c @@ -178,7 +178,7 @@ static int vle_legacy_load_cluster_from_disk(struct z_erofs_maprecorder *m, break; default: DBG_BUGON(1); - return -EIO; + return -ENOTSUPP; } m->type = type; return 0; @@ -362,7 +362,7 @@ static int vle_extent_lookback(struct z_erofs_maprecorder *m, errln("unknown type %u at lcn %lu of nid %llu", m->type, lcn, vi->nid); DBG_BUGON(1); - return -EIO; + return -ENOTSUPP; } return 0; } @@ -436,7 +436,7 @@ int z_erofs_map_blocks_iter(struct inode *inode, default: errln("unknown type %u at offset %llu of nid %llu", m.type, ofs, vi->nid); - err = -EIO; + err = -ENOTSUPP; goto unmap_out; }
For some specific fields, use ENOTSUPP instead of EIO for values which look sane but aren't supported right now. Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> --- drivers/staging/erofs/inode.c | 4 ++-- drivers/staging/erofs/zmap.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)