| Message ID | 20190814020330.12133-1-xiaowei.bao@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fd5d16531a39322c3d7433d9f8a36203c9aaeddc |
| Headers | show |
| Series | [PATCHv6,1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver. | expand |
I asked you to remove the period at the end of the patch $SUBJECT and you did not, either you do not read what I write or explain me what's going on. On Wed, Aug 14, 2019 at 10:03:29AM +0800, Xiaowei Bao wrote: > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 > is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, > so set the bar_fixed_64bit with 0x14. > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> Kishon ACK'ed this patch and you have not carried his tag. I will make these changes but that's the last time I do that for you. Lorenzo > --- > v2: > - Replace value 0x14 with a macro. > v3: > - No change. > v4: > - send the patch again with '--to'. > v5: > - fix the commit message. > v6: > - remove the [EXT] tag of the $SUBJECT in email. > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index be61d96..ca9aa45 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { > .linkup_notifier = false, > .msi_capable = true, > .msix_capable = false, > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > }; > > static const struct pci_epc_features* > -- > 2.9.5 >
> -----Original Message----- > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Sent: 2019年8月14日 17:30 > To: Xiaowei Bao <xiaowei.bao@nxp.com> > Cc: M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu > <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; > bhelgaas@google.com; linuxppc-dev@lists.ozlabs.org; > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property > in EP driver. > > I asked you to remove the period at the end of the patch $SUBJECT and you > did not, either you do not read what I write or explain me what's going on. Sorry, I didn't understand the meaning of period correctly before. > > On Wed, Aug 14, 2019 at 10:03:29AM +0800, Xiaowei Bao wrote: > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > the bar_fixed_64bit with 0x14. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > Kishon ACK'ed this patch and you have not carried his tag. > > I will make these changes but that's the last time I do that for you. Thanks a lot, your means is that I don't need to send the v7 patch and you help me to Correct this patch, yes? Thanks a lot for your help about the rules of the upstream. I will Correct this error next time. ^.^ > > Lorenzo > > > --- > > v2: > > - Replace value 0x14 with a macro. > > v3: > > - No change. > > v4: > > - send the patch again with '--to'. > > v5: > > - fix the commit message. > > v6: > > - remove the [EXT] tag of the $SUBJECT in email. > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index be61d96..ca9aa45 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > ls_pcie_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = false, > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > }; > > > > static const struct pci_epc_features* > > -- > > 2.9.5 > >
On Wed, Aug 14, 2019 at 09:48:00AM +0000, Xiaowei Bao wrote: > > > > -----Original Message----- > > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > Sent: 2019年8月14日 17:30 > > To: Xiaowei Bao <xiaowei.bao@nxp.com> > > Cc: M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu > > <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; > > bhelgaas@google.com; linuxppc-dev@lists.ozlabs.org; > > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property > > in EP driver. Do not quote the email header in your replies. > > I asked you to remove the period at the end of the patch $SUBJECT and you > > did not, either you do not read what I write or explain me what's going on. > Sorry, I didn't understand the meaning of period correctly before. > > > > On Wed, Aug 14, 2019 at 10:03:29AM +0800, Xiaowei Bao wrote: > > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > > the bar_fixed_64bit with 0x14. > > > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > > > Kishon ACK'ed this patch and you have not carried his tag. > > > > I will make these changes but that's the last time I do that for you. > Thanks a lot, your means is that I don't need to send the v7 patch and you help me to > Correct this patch, yes? Thanks a lot for your help about the rules of the upstream. I will > Correct this error next time. ^.^ I fixed that up and pushed out, pci/layerscape, for v5.4. Thanks, Lorenzo > > Lorenzo > > > > > --- > > > v2: > > > - Replace value 0x14 with a macro. > > > v3: > > > - No change. > > > v4: > > > - send the patch again with '--to'. > > > v5: > > > - fix the commit message. > > > v6: > > > - remove the [EXT] tag of the $SUBJECT in email. > > > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > index be61d96..ca9aa45 100644 > > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > > ls_pcie_epc_features = { > > > .linkup_notifier = false, > > > .msi_capable = true, > > > .msix_capable = false, > > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > > }; > > > > > > static const struct pci_epc_features* > > > -- > > > 2.9.5 > > >
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c index be61d96..ca9aa45 100644 --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { .linkup_notifier = false, .msi_capable = true, .msix_capable = false, + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), }; static const struct pci_epc_features*
The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set the bar_fixed_64bit with 0x14. Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> --- v2: - Replace value 0x14 with a macro. v3: - No change. v4: - send the patch again with '--to'. v5: - fix the commit message. v6: - remove the [EXT] tag of the $SUBJECT in email. drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + 1 file changed, 1 insertion(+)