[0/3] colo: Add support for continious replication

Message

Lukas Straub Aug. 14, 2019, 8:46 p.m. UTC

Hello Everyone,
These Patches add support for continious replication to colo.
Please review.

Regards,
Lukas Straub

Lukas Straub (3):
  Replication: Ignore requests after failover
  net/filter.c: Add Options to insert filters anywhere in the filter list
  Document the qmp commands for continious replication

 block/replication.c  |  31 +++++++-
 docs/COLO-FT.txt     | 185 ++++++++++++++++++++++++++++++++-----------
 include/net/filter.h |   2 +
 net/filter.c         |  73 ++++++++++++++++-
 qemu-options.hx      |  10 +--
 5 files changed, 243 insertions(+), 58 deletions(-)

--
2.20.1

Comments

[e-mail] Aug. 15, 2019, 3:20 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

                 from /var/tmp/patchew-tester-tmp-6ji6qfi2/src/include/net/filter.h:13,
                 from /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:14:
/var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c: In function ‘netfilter_complete’:
/var/tmp/patchew-tester-tmp-6ji6qfi2/src/include/qemu/queue.h:412:44: error: ‘position’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  412 |         (listelm)->field.tqe_circ.tql_prev = &(elm)->field.tqe_circ;         \
      |                                            ^
/var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:237:21: note: ‘position’ was declared here


The full log is available at
http://patchew.org/logs/[e-mail]/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

Zhang Chen Aug. 15, 2019, 6:14 a.m. UTC | #2

Hi Lukas,

Please fix this issue and add more comments in the commit log.

Thanks
Zhang Chen

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> Sent: Thursday, August 15, 2019 11:20 AM
> To: [e-mail]
> Cc: Zhang, Chen <[e-mail]>; [e-mail]
> Subject: Re: [Qemu-devel] [PATCH 0/3] colo: Add support for continious
> replication
> 
> Patchew URL:
> https://patchew.org/QEMU/[e-mail]/
> 
> 
> 
> Hi,
> 
> This series failed build test on s390x host. Please find the details below.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> # Testing script will be invoked under the git checkout with # HEAD pointing to
> a commit that has the patches applied on top of "base"
> # branch
> set -e
> 
> echo
> echo "=== ENV ==="
> env
> 
> echo
> echo "=== PACKAGES ==="
> rpm -qa
> 
> echo
> echo "=== UNAME ==="
> uname -a
> 
> CC=$HOME/bin/cc
> INSTALL=$PWD/install
> BUILD=$PWD/build
> mkdir -p $BUILD $INSTALL
> SRC=$PWD
> cd $BUILD
> $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable
> clean up # make check -j4 V=1 make install === TEST SCRIPT END ===
> 
>                  from /var/tmp/patchew-tester-tmp-
> 6ji6qfi2/src/include/net/filter.h:13,
>                  from /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:14:
> /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c: In function
> ‘netfilter_complete’:
> /var/tmp/patchew-tester-tmp-6ji6qfi2/src/include/qemu/queue.h:412:44: error:
> ‘position’ may be used uninitialized in this function [-Werror=maybe-
> uninitialized]
>   412 |         (listelm)->field.tqe_circ.tql_prev = &(elm)->field.tqe_circ;         \
>       |                                            ^
> /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:237:21: note: ‘position’
> was declared here
> 
> 
> The full log is available at
> http://patchew.org/logs/[e-mail]/testing.s3
> 90x/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to [e-mail]