| Message ID | 20190816125225.16061-3-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | clk: renesas: Set GENPD_FLAG_ALWAYS_ON for clock domain | expand |
On Fri, Aug 16, 2019 at 02:52:24PM +0200, Geert Uytterhoeven wrote: > The RZ/N1 Clock Domain driver does not implement the > generic_pm_domain.power_{on,off}() callbacks, as the domain itself > cannot be powered down. Hence the domain should be marked as always-on > by setting the GENPD_FLAG_ALWAYS_ON flag. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Untested due to lack of hardware, but similar in spirit to the other > Clock Domain drivers. Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index b33e1383efe3abcd..1907ee195a08cf77 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -421,7 +421,8 @@ static int r9a06g032_add_clk_domain(struct device *dev) return -ENOMEM; pd->name = np->name; - pd->flags = GENPD_FLAG_PM_CLK | GENPD_FLAG_ACTIVE_WAKEUP; + pd->flags = GENPD_FLAG_PM_CLK | GENPD_FLAG_ALWAYS_ON | + GENPD_FLAG_ACTIVE_WAKEUP; pd->attach_dev = r9a06g032_attach_dev; pd->detach_dev = r9a06g032_detach_dev; pm_genpd_init(pd, &pm_domain_always_on_gov, false);
The RZ/N1 Clock Domain driver does not implement the generic_pm_domain.power_{on,off}() callbacks, as the domain itself cannot be powered down. Hence the domain should be marked as always-on by setting the GENPD_FLAG_ALWAYS_ON flag. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Untested due to lack of hardware, but similar in spirit to the other Clock Domain drivers. --- drivers/clk/renesas/r9a06g032-clocks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)