| Message ID | 20190813015602.30576-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8084499bd7d44b2c96658d788e329f3c232eb050 |
| Headers | show |
| Series | irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building | expand |
On Tue, 13 Aug 2019, YueHaibing wrote: > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is > not selected, it fails: > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade': > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip' > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init': > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops' > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips' > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip' > > select GENERIC_IRQ_CHIP to fix this. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") git show 9536eba03ec7 fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in the working tree. Thanks, tglx
Hi Thomas, On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote: > On Tue, 13 Aug 2019, YueHaibing wrote: > > > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is > > not selected, it fails: > > > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade': > > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip' > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init': > > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops' > > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips' > > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip' > > > > select GENERIC_IRQ_CHIP to fix this. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") > > git show 9536eba03ec7 > > fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in > the working tree. The referenced patch is in mips-next - can I get your Ack to apply this there too? Thanks, Paul
On Fri, 16 Aug 2019, Paul Burton wrote: > On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote: > > On Tue, 13 Aug 2019, YueHaibing wrote: > > > > > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is > > > not selected, it fails: > > > > > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade': > > > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip' > > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init': > > > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops' > > > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips' > > > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip' > > > > > > select GENERIC_IRQ_CHIP to fix this. > > > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") > > > > git show 9536eba03ec7 > > > > fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in > > the working tree. > > The referenced patch is in mips-next - can I get your Ack to apply this > there too? Sure. Acked-by-me :)
Hello, YueHaibing wrote: > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is > not selected, it fails: > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade': > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip' > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init': > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops' > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips' > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip' > > select GENERIC_IRQ_CHIP to fix this. Applied to mips-next. > commit 8084499bd7d4 > https://git.kernel.org/mips/c/8084499bd7d4 > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Acked-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Paul Burton <paul.burton@mips.com> Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.burton@mips.com to report it. ]
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 3c8308e..ccbb897 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -320,6 +320,7 @@ config INGENIC_TCU_IRQ default MACH_INGENIC depends on MIPS || COMPILE_TEST select MFD_SYSCON + select GENERIC_IRQ_CHIP help Support for interrupts in the Timer/Counter Unit (TCU) of the Ingenic JZ47xx SoCs.
While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is not selected, it fails: drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade': irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip' drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init': irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops' irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips' irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip' select GENERIC_IRQ_CHIP to fix this. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+)