diff mbox series

iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids

Message ID 20190818112306.21236-1-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show
Series iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids | expand

Commit Message

Hans de Goede Aug. 18, 2019, 11:23 a.m. UTC
The KIOX010A and KIOX020A ACPI ids go hand in hand, they are used in
yoga style 2-in-1s, with KIOX010A indicating the KXCJ91008 sensor in the
display of the 2-in-1 and KIOX020A indicating the KXCJ91008 sensor in the
base.

Improve the existing comment on the "KIOX010A" kx_acpi_match table entry
to make clear we are talking about a yoga-style (360 degree hinges) device
here and add a similar comment to the "KIOX020A" entry.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/iio/accel/kxcjk-1013.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron Aug. 18, 2019, 5:51 p.m. UTC | #1
On Sun, 18 Aug 2019 13:23:06 +0200
Hans de Goede <hdegoede@redhat.com> wrote:

> The KIOX010A and KIOX020A ACPI ids go hand in hand, they are used in
> yoga style 2-in-1s, with KIOX010A indicating the KXCJ91008 sensor in the
> display of the 2-in-1 and KIOX020A indicating the KXCJ91008 sensor in the
> base.
> 
> Improve the existing comment on the "KIOX010A" kx_acpi_match table entry
> to make clear we are talking about a yoga-style (360 degree hinges) device
> here and add a similar comment to the "KIOX020A" entry.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied to the togreg branch of iio.git and pushed out as testing to be
ignored by the autobuilders.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/kxcjk-1013.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 6645771aa349..fee535d6e45b 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1486,8 +1486,8 @@ static const struct acpi_device_id kx_acpi_match[] = {
>  	{"KIOX0008", KXCJ91008},
>  	{"KIOX0009", KXTJ21009},
>  	{"KIOX000A", KXCJ91008},
> -	{"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */
> -	{"KIOX020A", KXCJ91008},
> +	{"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */
> +	{"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */
>  	{"KXTJ1009", KXTJ21009},
>  	{"KXJ2109",  KXTJ21009},
>  	{"SMO8500",  KXCJ91008},
diff mbox series

Patch

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 6645771aa349..fee535d6e45b 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -1486,8 +1486,8 @@  static const struct acpi_device_id kx_acpi_match[] = {
 	{"KIOX0008", KXCJ91008},
 	{"KIOX0009", KXTJ21009},
 	{"KIOX000A", KXCJ91008},
-	{"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */
-	{"KIOX020A", KXCJ91008},
+	{"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */
+	{"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */
 	{"KXTJ1009", KXTJ21009},
 	{"KXJ2109",  KXTJ21009},
 	{"SMO8500",  KXCJ91008},