| Message ID | 20190819175457.231058-3-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | PM / wakeup: Fix wakeup class wrecakge in -next | expand |
Sorry, subject should be
PM / wakeup: Unexport wakeup_source_sysfs_{add,remove}()
Quoting Stephen Boyd (2019-08-19 10:54:57)
> These functions are just used by the PM core, and that isn't modular so
> these functions don't need to be exported. Drop the exports.
>
> Fixes: 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs")
> Cc: Tri Vo <trong@android.com
Messed up the address here too. Should be
Cc: Tri Vo <trong@android.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/base/power/wakeup_stats.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeup_stats.c
> index bc5e3945f7a8..c7734914d914 100644
> --- a/drivers/base/power/wakeup_stats.c
> +++ b/drivers/base/power/wakeup_stats.c
> @@ -182,7 +182,6 @@ int wakeup_source_sysfs_add(struct device *parent, struct wakeup_source *ws)
>
> return 0;
> }
> -EXPORT_SYMBOL_GPL(wakeup_source_sysfs_add);
>
> /**
> * pm_wakeup_source_sysfs_add - Add wakeup_source attributes to sysfs
> @@ -205,7 +204,6 @@ void wakeup_source_sysfs_remove(struct wakeup_source *ws)
> {
> device_unregister(ws->dev);
> }
> -EXPORT_SYMBOL_GPL(wakeup_source_sysfs_remove);
>
> static int __init wakeup_sources_sysfs_init(void)
> {
On Mon, Aug 19, 2019 at 11:21 AM Stephen Boyd <swboyd@chromium.org> wrote: > > Sorry, subject should be > > PM / wakeup: Unexport wakeup_source_sysfs_{add,remove}() > > Quoting Stephen Boyd (2019-08-19 10:54:57) > > These functions are just used by the PM core, and that isn't modular so > > these functions don't need to be exported. Drop the exports. > > > > Fixes: 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") > > Cc: Tri Vo <trong@android.com > > Messed up the address here too. Should be > > Cc: Tri Vo <trong@android.com> > > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Tri Vo <trong@android.com>
diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeup_stats.c index bc5e3945f7a8..c7734914d914 100644 --- a/drivers/base/power/wakeup_stats.c +++ b/drivers/base/power/wakeup_stats.c @@ -182,7 +182,6 @@ int wakeup_source_sysfs_add(struct device *parent, struct wakeup_source *ws) return 0; } -EXPORT_SYMBOL_GPL(wakeup_source_sysfs_add); /** * pm_wakeup_source_sysfs_add - Add wakeup_source attributes to sysfs @@ -205,7 +204,6 @@ void wakeup_source_sysfs_remove(struct wakeup_source *ws) { device_unregister(ws->dev); } -EXPORT_SYMBOL_GPL(wakeup_source_sysfs_remove); static int __init wakeup_sources_sysfs_init(void) {
These functions are just used by the PM core, and that isn't modular so these functions don't need to be exported. Drop the exports. Fixes: 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") Cc: Tri Vo <trong@android.com Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/base/power/wakeup_stats.c | 2 -- 1 file changed, 2 deletions(-)