| Message ID | 1565940884636.2215@bt.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Invert Endian bit in SPARCv9 MMU TTE | expand |
On 8/16/19 9:34 AM, tony.nguyen@bt.com wrote: > For each device declared with DEVICE_NATIVE_ENDIAN, find the set of > targets from the set of target/hw/*/device.o. > > If the set of targets are all little or all big endian, re-declare > the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN > respectively. > > This *naive* deduction may result in genuinely native endian devices > being incorrectly declared as little or big endian, but should not > introduce regressions for current targets. > > These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it > has a new target with an opposite endian or 2) someone informed knows > better =) > > Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> > --- > hw/misc/a9scu.c | 2 +- > hw/misc/applesmc.c | 6 +++--- > hw/misc/arm11scu.c | 2 +- > hw/misc/arm_l2x0.c | 2 +- > hw/misc/puv3_pm.c | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c > index 4307f00..3de8cd3 100644 > --- a/hw/misc/a9scu.c > +++ b/hw/misc/a9scu.c > @@ -94,7 +94,7 @@ static void a9_scu_write(void *opaque, hwaddr offset, > static const MemoryRegionOps a9_scu_ops = { > .read = a9_scu_read, > .write = a9_scu_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, Uh, I doubt that. > }; > > static void a9_scu_reset(DeviceState *dev) > diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c > index 2d7eb3c..6c91f29 100644 > --- a/hw/misc/applesmc.c > +++ b/hw/misc/applesmc.c > @@ -285,7 +285,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev) > static const MemoryRegionOps applesmc_data_io_ops = { > .write = applesmc_io_data_write, > .read = applesmc_io_data_read, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > .impl = { > .min_access_size = 1, > .max_access_size = 1, > @@ -295,7 +295,7 @@ static const MemoryRegionOps applesmc_data_io_ops = { > static const MemoryRegionOps applesmc_cmd_io_ops = { > .write = applesmc_io_cmd_write, > .read = applesmc_io_cmd_read, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > .impl = { > .min_access_size = 1, > .max_access_size = 1, > @@ -305,7 +305,7 @@ static const MemoryRegionOps applesmc_cmd_io_ops = { > static const MemoryRegionOps applesmc_err_io_ops = { > .write = applesmc_io_err_write, > .read = applesmc_io_err_read, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > .impl = { > .min_access_size = 1, > .max_access_size = 1, Being ioport, this one might be OK. > diff --git a/hw/misc/arm11scu.c b/hw/misc/arm11scu.c > index 84275df..59fd7c0 100644 > --- a/hw/misc/arm11scu.c > +++ b/hw/misc/arm11scu.c > @@ -57,7 +57,7 @@ static void mpcore_scu_write(void *opaque, hwaddr offset, > static const MemoryRegionOps mpcore_scu_ops = { > .read = mpcore_scu_read, > .write = mpcore_scu_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, I don't think so, > }; > > static void arm11_scu_realize(DeviceState *dev, Error **errp) > diff --git a/hw/misc/arm_l2x0.c b/hw/misc/arm_l2x0.c > index b88f40a..72ecf46 100644 > --- a/hw/misc/arm_l2x0.c > +++ b/hw/misc/arm_l2x0.c > @@ -157,7 +157,7 @@ static void l2x0_priv_reset(DeviceState *dev) > static const MemoryRegionOps l2x0_mem_ops = { > .read = l2x0_priv_read, > .write = l2x0_priv_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, neither here, but Peter will confirm. > }; > > static void l2x0_priv_init(Object *obj) > diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c > index b538b4a..cd82b69 100644 > --- a/hw/misc/puv3_pm.c > +++ b/hw/misc/puv3_pm.c > @@ -118,7 +118,7 @@ static const MemoryRegionOps puv3_pm_ops = { > .min_access_size = 4, > .max_access_size = 4, > }, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, This one I can't tell. > }; > > static void puv3_pm_realize(DeviceState *dev, Error **errp) > -- > 1.8.3.1 > > >
On 16/08/19 12:04, Philippe Mathieu-Daudé wrote: >> diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c >> index 4307f00..3de8cd3 100644 >> --- a/hw/misc/a9scu.c >> +++ b/hw/misc/a9scu.c >> @@ -94,7 +94,7 @@ static void a9_scu_write(void *opaque, hwaddr offset, >> static const MemoryRegionOps a9_scu_ops = { >> .read = a9_scu_read, >> .write = a9_scu_write, >> - .endianness = DEVICE_NATIVE_ENDIAN, >> + .endianness = DEVICE_LITTLE_ENDIAN, > Uh, I doubt that. > ... why? :) Remember that BE32 and BE8 ARM OSes still are "natively" little-endian. Paolo
diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c index 4307f00..3de8cd3 100644 --- a/hw/misc/a9scu.c +++ b/hw/misc/a9scu.c @@ -94,7 +94,7 @@ static void a9_scu_write(void *opaque, hwaddr offset, static const MemoryRegionOps a9_scu_ops = { .read = a9_scu_read, .write = a9_scu_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void a9_scu_reset(DeviceState *dev) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 2d7eb3c..6c91f29 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -285,7 +285,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev) static const MemoryRegionOps applesmc_data_io_ops = { .write = applesmc_io_data_write, .read = applesmc_io_data_read, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .impl = { .min_access_size = 1, .max_access_size = 1, @@ -295,7 +295,7 @@ static const MemoryRegionOps applesmc_data_io_ops = { static const MemoryRegionOps applesmc_cmd_io_ops = { .write = applesmc_io_cmd_write, .read = applesmc_io_cmd_read, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .impl = { .min_access_size = 1, .max_access_size = 1, @@ -305,7 +305,7 @@ static const MemoryRegionOps applesmc_cmd_io_ops = { static const MemoryRegionOps applesmc_err_io_ops = { .write = applesmc_io_err_write, .read = applesmc_io_err_read, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .impl = { .min_access_size = 1, .max_access_size = 1, diff --git a/hw/misc/arm11scu.c b/hw/misc/arm11scu.c index 84275df..59fd7c0 100644 --- a/hw/misc/arm11scu.c +++ b/hw/misc/arm11scu.c @@ -57,7 +57,7 @@ static void mpcore_scu_write(void *opaque, hwaddr offset, static const MemoryRegionOps mpcore_scu_ops = { .read = mpcore_scu_read, .write = mpcore_scu_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void arm11_scu_realize(DeviceState *dev, Error **errp) diff --git a/hw/misc/arm_l2x0.c b/hw/misc/arm_l2x0.c index b88f40a..72ecf46 100644 --- a/hw/misc/arm_l2x0.c +++ b/hw/misc/arm_l2x0.c @@ -157,7 +157,7 @@ static void l2x0_priv_reset(DeviceState *dev) static const MemoryRegionOps l2x0_mem_ops = { .read = l2x0_priv_read, .write = l2x0_priv_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void l2x0_priv_init(Object *obj) diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c index b538b4a..cd82b69 100644 --- a/hw/misc/puv3_pm.c +++ b/hw/misc/puv3_pm.c @@ -118,7 +118,7 @@ static const MemoryRegionOps puv3_pm_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void puv3_pm_realize(DeviceState *dev, Error **errp)
For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets. These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =) Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> --- hw/misc/a9scu.c | 2 +- hw/misc/applesmc.c | 6 +++--- hw/misc/arm11scu.c | 2 +- hw/misc/arm_l2x0.c | 2 +- hw/misc/puv3_pm.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) -- 1.8.3.1 ?