| Message ID | 1563534631-15897-2-git-send-email-yash.shah@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] macb: bindings doc: update sifive fu540-c000 binding | expand |
On 19/07/2019 at 13:10, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 Maybe referring to lore.kernel.org is better: https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/ > Signed-off-by: Yash Shah <yash.shah@sifive.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, best regards, Nicolas > --- > drivers/net/ethernet/cadence/macb_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 15d0737..305371c 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -4112,7 +4112,7 @@ static int fu540_c000_init(struct platform_device *pdev) > { .compatible = "cdns,emac", .data = &emac_config }, > { .compatible = "cdns,zynqmp-gem", .data = &zynqmp_config}, > { .compatible = "cdns,zynq-gem", .data = &zynq_config }, > - { .compatible = "sifive,fu540-macb", .data = &fu540_c000_config }, > + { .compatible = "sifive,fu540-c000-gem", .data = &fu540_c000_config }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, macb_dt_ids); >
On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote: > > On 19/07/2019 at 13:10, Yash Shah wrote: > > Update the compatibility string for SiFive FU540-C000 as per the new > > string updated in the binding doc. > > Reference: https://lkml.org/lkml/2019/7/17/200 > > Maybe referring to lore.kernel.org is better: > https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/ Sure. Will keep that in mind for future reference. > > > Signed-off-by: Yash Shah <yash.shah@sifive.com> > > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks. - Yash
On Fri, 19 Jul 2019, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah <yash.shah@sifive.com> Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com> - Paul
On Fri, 19 Jul 2019, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah <yash.shah@sifive.com> Tested-by: Paul Walmsley <paul.walmsley@sifive.com> - Paul
Dave, Nicolas, On Mon, 22 Jul 2019, Yash Shah wrote: > On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote: > > > > On 19/07/2019 at 13:10, Yash Shah wrote: > > > Update the compatibility string for SiFive FU540-C000 as per the new > > > string updated in the binding doc. > > > Reference: https://lkml.org/lkml/2019/7/17/200 > > > > Maybe referring to lore.kernel.org is better: > > https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/ > > Sure. Will keep that in mind for future reference. > > > > > > Signed-off-by: Yash Shah <yash.shah@sifive.com> > > > > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > > Thanks. Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. If not, please let us know. - Paul
On Aug 13 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > Dave, Nicolas, > > On Mon, 22 Jul 2019, Yash Shah wrote: > >> On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote: >> > >> > On 19/07/2019 at 13:10, Yash Shah wrote: >> > > Update the compatibility string for SiFive FU540-C000 as per the new >> > > string updated in the binding doc. >> > > Reference: https://lkml.org/lkml/2019/7/17/200 >> > >> > Maybe referring to lore.kernel.org is better: >> > https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/ >> >> Sure. Will keep that in mind for future reference. >> >> > >> > > Signed-off-by: Yash Shah <yash.shah@sifive.com> >> > >> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> >> >> Thanks. > > Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. > If not, please let us know. This is still missing in v5.4-rc5, which means that networking is broken. Andreas.
On 20/08/2019 at 11:10, Andreas Schwab wrote: > External E-Mail > > > On Aug 13 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > >> Dave, Nicolas, >> >> On Mon, 22 Jul 2019, Yash Shah wrote: >> >>> On Fri, Jul 19, 2019 at 5:36 PM <Nicolas.Ferre@microchip.com> wrote: >>>> >>>> On 19/07/2019 at 13:10, Yash Shah wrote: >>>>> Update the compatibility string for SiFive FU540-C000 as per the new >>>>> string updated in the binding doc. >>>>> Reference: https://lkml.org/lkml/2019/7/17/200 >>>> >>>> Maybe referring to lore.kernel.org is better: >>>> https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/ >>> >>> Sure. Will keep that in mind for future reference. >>> >>>> >>>>> Signed-off-by: Yash Shah <yash.shah@sifive.com> >>>> >>>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> >>> >>> Thanks. >> >> Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. >> If not, please let us know. > > This is still missing in v5.4-rc5, which means that networking is broken. Andreas, Paul, The patchwork state for the 2 first patches of this series is "Changes Requested". It's probably due to my advice of using lore.kernel.org (or something else). I'm perfectly fine in accepting the patches are they are today but can't change their patchwork state myself. We would need Dave or Jakub to take them. Dave, Jakub, All tags are collected in patchwork and all should be fine on DT (Rob) side as well. Please tell me if you're waiting some sign from me. Best regards,
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 15d0737..305371c 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4112,7 +4112,7 @@ static int fu540_c000_init(struct platform_device *pdev) { .compatible = "cdns,emac", .data = &emac_config }, { .compatible = "cdns,zynqmp-gem", .data = &zynqmp_config}, { .compatible = "cdns,zynq-gem", .data = &zynq_config }, - { .compatible = "sifive,fu540-macb", .data = &fu540_c000_config }, + { .compatible = "sifive,fu540-c000-gem", .data = &fu540_c000_config }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, macb_dt_ids);
Update the compatibility string for SiFive FU540-C000 as per the new string updated in the binding doc. Reference: https://lkml.org/lkml/2019/7/17/200 Signed-off-by: Yash Shah <yash.shah@sifive.com> --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)