| Message ID | 20190327133927.1340-4-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [1/4] Input: ads7846 - convert to devm_ alloc functions | expand |
On Wed, 27 Mar 2019 14:39:26 +0100, Marco Felsch wrote: > Mark the vendor-bindings as deprecated and replace them by the general > ones. All deprecated bindings are used as default and gets overwritten by > the general ones if the user supplies both. This ensures the backward > compatibility with old dt's. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > .../bindings/input/touchscreen/ads7846.txt | 29 ++++++++++++++----- > 1 file changed, 21 insertions(+), 8 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Dmitry, On 19-03-31 01:42, Rob Herring wrote: > On Wed, 27 Mar 2019 14:39:26 +0100, Marco Felsch wrote: > > Mark the vendor-bindings as deprecated and replace them by the general > > ones. All deprecated bindings are used as default and gets overwritten by > > the general ones if the user supplies both. This ensures the backward > > compatibility with old dt's. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > .../bindings/input/touchscreen/ads7846.txt | 29 ++++++++++++++----- > > 1 file changed, 21 insertions(+), 8 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> How about this patch?
On Wed, Aug 21, 2019 at 09:36:13AM +0200, Marco Felsch wrote: > Hi Dmitry, > > On 19-03-31 01:42, Rob Herring wrote: > > On Wed, 27 Mar 2019 14:39:26 +0100, Marco Felsch wrote: > > > Mark the vendor-bindings as deprecated and replace them by the general > > > ones. All deprecated bindings are used as default and gets overwritten by > > > the general ones if the user supplies both. This ensures the backward > > > compatibility with old dt's. > > > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > > --- > > > .../bindings/input/touchscreen/ads7846.txt | 29 ++++++++++++++----- > > > 1 file changed, 21 insertions(+), 8 deletions(-) > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > How about this patch? It's been folded into the patch implementing the handling of the bindings in the driver. Thanks.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/ads7846.txt b/Documentation/devicetree/bindings/input/touchscreen/ads7846.txt index ce540ddac902..81f6bda97d3c 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/ads7846.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/ads7846.txt @@ -32,7 +32,6 @@ Optional properties: (ADS7846). ti,keep-vref-on set to keep vref on for differential measurements as well - ti,swap-xy swap x and y axis ti,settle-delay-usec Settling time of the analog signals; a function of Vcc and the capacitance on the X/Y drivers. If set to non-zero, @@ -51,13 +50,6 @@ Optional properties: in Ohms (u16). ti,x-min Minimum value on the X axis (u16). ti,y-min Minimum value on the Y axis (u16). - ti,x-max Maximum value on the X axis (u16). - ti,y-max Maximum value on the Y axis (u16). - ti,pressure-min Minimum reported pressure value - (threshold) - u16. - ti,pressure-max Maximum reported pressure value (u16). - ti,debounce-max Max number of additional readings per - sample (u16). ti,debounce-tol Tolerance used for filtering (u16). ti,debounce-rep Additional consecutive good readings required after the first two (u16). @@ -67,7 +59,28 @@ Optional properties: line is connected to. wakeup-source use any event on touchscreen as wakeup event. (Legacy property support: "linux,wakeup") + touchscreen-size-x General touchscreen binding, see [1]. + touchscreen-size-y General touchscreen binding, see [1]. + touchscreen-max-pressure General touchscreen binding, see [1]. + touchscreen-min-pressure General touchscreen binding, see [1]. + touchscreen-average-samples General touchscreen binding, see [1]. + touchscreen-inverted-x General touchscreen binding, see [1]. + touchscreen-inverted-y General touchscreen binding, see [1]. + touchscreen-swapped-x-y General touchscreen binding, see [1]. + +[1] All general touchscreen properties are described in + Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt. +Deprecated properties: + + ti,swap-xy swap x and y axis + ti,x-max Maximum value on the X axis (u16). + ti,y-max Maximum value on the Y axis (u16). + ti,pressure-min Minimum reported pressure value + (threshold) - u16. + ti,pressure-max Maximum reported pressure value (u16). + ti,debounce-max Max number of additional readings per + sample (u16). Example for a TSC2046 chip connected to an McSPI controller of an OMAP SoC::
Mark the vendor-bindings as deprecated and replace them by the general ones. All deprecated bindings are used as default and gets overwritten by the general ones if the user supplies both. This ensures the backward compatibility with old dt's. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- .../bindings/input/touchscreen/ads7846.txt | 29 ++++++++++++++----- 1 file changed, 21 insertions(+), 8 deletions(-)