| Message ID | 20190814060854.26345-10-codekipper@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: sun4i-i2s: Updates to the driver | expand |
On Wed, Aug 14, 2019 at 2:09 PM <codekipper@gmail.com> wrote: > > From: Jernej Skrabec <jernej.skrabec@siol.net> > > I2S doesn't work if parent rate couldn't be change. Difference between > wanted and actual rate is too big. > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> This lacks your SoB. Please reply and I can add it when applying. ChenYu
Thanks....I've added to my next patch series but if you could add it when applying that would be great. BR, CK On Wed, 21 Aug 2019 at 06:07, Chen-Yu Tsai <wens@csie.org> wrote: > > On Wed, Aug 14, 2019 at 2:09 PM <codekipper@gmail.com> wrote: > > > > From: Jernej Skrabec <jernej.skrabec@siol.net> > > > > I2S doesn't work if parent rate couldn't be change. Difference between > > wanted and actual rate is too big. > > > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > This lacks your SoB. Please reply and I can add it when applying. > > ChenYu
On Wed, Aug 21, 2019 at 1:52 PM Code Kipper <codekipper@gmail.com> wrote: > > Thanks....I've added to my next patch series but if you could add it > when applying that would be great. Please reply with an explicit SoB to put it on the record. ChenYu > BR, > CK > > On Wed, 21 Aug 2019 at 06:07, Chen-Yu Tsai <wens@csie.org> wrote: > > > > On Wed, Aug 14, 2019 at 2:09 PM <codekipper@gmail.com> wrote: > > > > > > From: Jernej Skrabec <jernej.skrabec@siol.net> > > > > > > I2S doesn't work if parent rate couldn't be change. Difference between > > > wanted and actual rate is too big. > > > > > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > > > This lacks your SoB. Please reply and I can add it when applying. > > > > ChenYu > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAEKpxBnxf%3Diejk887A7qFkzt3BXVxiRS1PeA45aZYR9DsBAU4Q%40mail.gmail.com.
On Wed, 14 Aug 2019 at 08:09, <codekipper@gmail.com> wrote: > > From: Jernej Skrabec <jernej.skrabec@siol.net> > > I2S doesn't work if parent rate couldn't be change. Difference between > wanted and actual rate is too big. > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Signed-off-by: Marcus Cooper <codekipper@gmail.com> > --- > drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6.c > index aebef4af9861..d89353a3cdec 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6.c > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6.c > @@ -505,7 +505,7 @@ static struct ccu_div i2s3_clk = { > .hw.init = CLK_HW_INIT_PARENTS("i2s3", > audio_parents, > &ccu_div_ops, > - 0), > + CLK_SET_RATE_PARENT), > }, > }; > > @@ -518,7 +518,7 @@ static struct ccu_div i2s0_clk = { > .hw.init = CLK_HW_INIT_PARENTS("i2s0", > audio_parents, > &ccu_div_ops, > - 0), > + CLK_SET_RATE_PARENT), > }, > }; > > @@ -531,7 +531,7 @@ static struct ccu_div i2s1_clk = { > .hw.init = CLK_HW_INIT_PARENTS("i2s1", > audio_parents, > &ccu_div_ops, > - 0), > + CLK_SET_RATE_PARENT), > }, > }; > > @@ -544,7 +544,7 @@ static struct ccu_div i2s2_clk = { > .hw.init = CLK_HW_INIT_PARENTS("i2s2", > audio_parents, > &ccu_div_ops, > - 0), > + CLK_SET_RATE_PARENT), > }, > }; > > -- > 2.22.0 >
On Wed, Aug 21, 2019 at 5:19 PM Code Kipper <codekipper@gmail.com> wrote: > > On Wed, 14 Aug 2019 at 08:09, <codekipper@gmail.com> wrote: > > > > From: Jernej Skrabec <jernej.skrabec@siol.net> > > > > I2S doesn't work if parent rate couldn't be change. Difference between > > wanted and actual rate is too big. > > > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> Applied for 5.4
diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6.c index aebef4af9861..d89353a3cdec 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6.c +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6.c @@ -505,7 +505,7 @@ static struct ccu_div i2s3_clk = { .hw.init = CLK_HW_INIT_PARENTS("i2s3", audio_parents, &ccu_div_ops, - 0), + CLK_SET_RATE_PARENT), }, }; @@ -518,7 +518,7 @@ static struct ccu_div i2s0_clk = { .hw.init = CLK_HW_INIT_PARENTS("i2s0", audio_parents, &ccu_div_ops, - 0), + CLK_SET_RATE_PARENT), }, }; @@ -531,7 +531,7 @@ static struct ccu_div i2s1_clk = { .hw.init = CLK_HW_INIT_PARENTS("i2s1", audio_parents, &ccu_div_ops, - 0), + CLK_SET_RATE_PARENT), }, }; @@ -544,7 +544,7 @@ static struct ccu_div i2s2_clk = { .hw.init = CLK_HW_INIT_PARENTS("i2s2", audio_parents, &ccu_div_ops, - 0), + CLK_SET_RATE_PARENT), }, };