| Message ID | 20190821093905.7693-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gtt: Include asm/smp.h | expand |
Quoting Patchwork (2019-08-21 11:01:05) > == Series Details == > > Series: drm/i915/gtt: Include asm/smp.h > URL : https://patchwork.freedesktop.org/series/65532/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 8b9d243b31ad drm/i915/gtt: Include asm/smp.h > -:20: WARNING:INCLUDE_LINUX: Use #include <linux/smp.h> instead of <asm/smp.h> Sorry, checkpatch but you are wrong. If we did that, it would not include asm/smp.h for !CONFIG_SMP and we would not have the wbinvd_on_all_cpus() { wbinv() } stub. -Chris
On 21/08/2019 10:39, Chris Wilson wrote: > We need asm/smp.h for wbinvd_on_all_cpus() > > Reported-by: kbuild-all@01.org > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Matthew Auld <matthew.auld@intel.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index c9a4690bf8b1..14eef8f8d16a 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -32,6 +32,7 @@ #include <linux/stop_machine.h> #include <asm/set_memory.h> +#include <asm/smp.h> #include <drm/i915_drm.h>
We need asm/smp.h for wbinvd_on_all_cpus() Reported-by: kbuild-all@01.org Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Matthew Auld <matthew.auld@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 1 + 1 file changed, 1 insertion(+)