| Message ID | 20190821135406.26200-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [net-next] net: stmmac: dwmac-meson: use devm_platform_ioremap_resource() to simplify code | expand |
On 21/08/2019 15:54, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c > index 88eb169..bbc16b5 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c > @@ -46,7 +46,6 @@ static int meson6_dwmac_probe(struct platform_device *pdev) > struct plat_stmmacenet_data *plat_dat; > struct stmmac_resources stmmac_res; > struct meson_dwmac *dwmac; > - struct resource *res; > int ret; > > ret = stmmac_get_platform_resources(pdev, &stmmac_res); > @@ -63,8 +62,7 @@ static int meson6_dwmac_probe(struct platform_device *pdev) > goto err_remove_config_dt; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - dwmac->reg = devm_ioremap_resource(&pdev->dev, res); > + dwmac->reg = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(dwmac->reg)) { > ret = PTR_ERR(dwmac->reg); > goto err_remove_config_dt; > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
From: YueHaibing <yuehaibing@huawei.com> Date: Wed, 21 Aug 2019 21:54:06 +0800 > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c index 88eb169..bbc16b5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c @@ -46,7 +46,6 @@ static int meson6_dwmac_probe(struct platform_device *pdev) struct plat_stmmacenet_data *plat_dat; struct stmmac_resources stmmac_res; struct meson_dwmac *dwmac; - struct resource *res; int ret; ret = stmmac_get_platform_resources(pdev, &stmmac_res); @@ -63,8 +62,7 @@ static int meson6_dwmac_probe(struct platform_device *pdev) goto err_remove_config_dt; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - dwmac->reg = devm_ioremap_resource(&pdev->dev, res); + dwmac->reg = devm_platform_ioremap_resource(pdev, 1); if (IS_ERR(dwmac->reg)) { ret = PTR_ERR(dwmac->reg); goto err_remove_config_dt;
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)