diff mbox series

[1/3] scsi: bnx2fc: remove set but not used variable 'fh'

Message ID 1566566573-49300-2-git-send-email-zhengbin13@huawei.com (mailing list archive)
State Accepted
Headers show
Series scsi: bnx2fc: remove some set but not used variables | expand

Commit Message

Zheng Bin Aug. 23, 2019, 1:22 p.m. UTC 
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function bnx2fc_rcv:
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:431:26: warning: variable fh set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 --
 1 file changed, 2 deletions(-)

--
2.7.4

Comments

Saurav Kashyap Aug. 26, 2019, 6:03 a.m. UTC | #1 
On 23/08/19, 6:46 PM, "linux-scsi-owner@vger.kernel.org on behalf of zhengbin" <linux-scsi-owner@vger.kernel.org on behalf of zhengbin13@huawei.com> wrote:

    Fixes gcc '-Wunused-but-set-variable' warning:
    
    drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function bnx2fc_rcv:
    drivers/scsi/bnx2fc/bnx2fc_fcoe.c:431:26: warning: variable fh set but not used [-Wunused-but-set-variable]
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    ---
     drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 --
     1 file changed, 2 deletions(-)
    
    diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    index 7796799..ab721ab 100644
    --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    @@ -428,7 +428,6 @@ static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
     	struct fc_lport *lport;
     	struct bnx2fc_interface *interface;
     	struct fcoe_ctlr *ctlr;
    -	struct fc_frame_header *fh;
     	struct fcoe_rcv_info *fr;
     	struct fcoe_percpu_s *bg;
     	struct sk_buff *tmp_skb;
    @@ -463,7 +462,6 @@ static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
     		goto err;
    
     	skb_set_transport_header(skb, sizeof(struct fcoe_hdr));
    -	fh = (struct fc_frame_header *) skb_transport_header(skb);
    
     	fr = fcoe_dev_from_skb(skb);
     	fr->fr_dev = lport;
    --
    2.7.4

Hi,
Thanks for patch.

Acked-by: Saurav Kashyap <skashyap@marvell.com>

Thanks,
~Saurav
diff mbox series

Patch

diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 7796799..ab721ab 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -428,7 +428,6 @@  static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
 	struct fc_lport *lport;
 	struct bnx2fc_interface *interface;
 	struct fcoe_ctlr *ctlr;
-	struct fc_frame_header *fh;
 	struct fcoe_rcv_info *fr;
 	struct fcoe_percpu_s *bg;
 	struct sk_buff *tmp_skb;
@@ -463,7 +462,6 @@  static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
 		goto err;

 	skb_set_transport_header(skb, sizeof(struct fcoe_hdr));
-	fh = (struct fc_frame_header *) skb_transport_header(skb);

 	fr = fcoe_dev_from_skb(skb);
 	fr->fr_dev = lport;