| Message ID | 20190826095828.8948-1-ilie.halip@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bus: imx-weim: remove __init from 2 functions | expand |
On Mon, Aug 26, 2019 at 12:58:28PM +0300, Ilie Halip wrote: > A previous commit removed __init from weim_probe(), but this attribute is > still present for other functions called from it. Thus, these warnings > are triggered: > WARNING: Section mismatch in reference from the function weim_probe() to the function .init.text:imx_weim_gpr_setup() > WARNING: Section mismatch in reference from the function weim_probe() to the function .init.text:weim_timing_setup() > > Remove the __init attribute from these functions as well, since they > don't seem to be used anywhere else. > > Signed-off-by: Ilie Halip <ilie.halip@gmail.com> > Reported-by: "kernelci.org bot" <bot@kernelci.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: clang-built-linux@googlegroups.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
On Mon, Aug 26, 2019 at 12:58:28PM +0300, Ilie Halip wrote: > A previous commit removed __init from weim_probe(), but this attribute is > still present for other functions called from it. Thus, these warnings > are triggered: > WARNING: Section mismatch in reference from the function weim_probe() to the function .init.text:imx_weim_gpr_setup() > WARNING: Section mismatch in reference from the function weim_probe() to the function .init.text:weim_timing_setup() > > Remove the __init attribute from these functions as well, since they > don't seem to be used anywhere else. > > Signed-off-by: Ilie Halip <ilie.halip@gmail.com> > Reported-by: "kernelci.org bot" <bot@kernelci.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: clang-built-linux@googlegroups.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Applied, thanks.
Hi Shawn, I think you can disregard this patch; the issue was already fixed by Arnd[1] a couple of days after I sent it. [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?h=for-next&id=3b1261fb72c7dc6a9e4604ef1ea01d6bb67cc3d1 Thanks, I.H.
On Wed, Sep 11, 2019 at 10:40:19AM +0300, Ilie Halip wrote: > Hi Shawn, > > I think you can disregard this patch; the issue was already fixed by > Arnd[1] a couple of days after I sent it. Ah, okay. Thanks for the note. Dropped. Shawn
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 79af0c27f5a3..d82e8c00523d 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -76,7 +76,7 @@ static const struct of_device_id weim_id_table[] = { }; MODULE_DEVICE_TABLE(of, weim_id_table); -static int __init imx_weim_gpr_setup(struct platform_device *pdev) +static int imx_weim_gpr_setup(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; struct property *prop; @@ -126,7 +126,7 @@ static int __init imx_weim_gpr_setup(struct platform_device *pdev) } /* Parse and set the timing for this device. */ -static int __init weim_timing_setup(struct device *dev, +static int weim_timing_setup(struct device *dev, struct device_node *np, void __iomem *base, const struct imx_weim_devtype *devtype, struct cs_timing_state *ts)
A previous commit removed __init from weim_probe(), but this attribute is still present for other functions called from it. Thus, these warnings are triggered: WARNING: Section mismatch in reference from the function weim_probe() to the function .init.text:imx_weim_gpr_setup() WARNING: Section mismatch in reference from the function weim_probe() to the function .init.text:weim_timing_setup() Remove the __init attribute from these functions as well, since they don't seem to be used anywhere else. Signed-off-by: Ilie Halip <ilie.halip@gmail.com> Reported-by: "kernelci.org bot" <bot@kernelci.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: clang-built-linux@googlegroups.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/bus/imx-weim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)