| Message ID | 20190814235712.4487-1-jsmart2021@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | lpfc: Update lpfc to revision 12.4.0.0 | expand |
James,
> Update lpfc to revision 12.4.0.0
Applied to 5.4/scsi-queue, thanks!
On 8/20/19 5:06 AM, Martin K. Petersen wrote: > > James, > >> Update lpfc to revision 12.4.0.0 > > Applied to 5.4/scsi-queue, thanks! > This update is crashing on my server: [ 33.178690] general protection fault: 0000 [#1] SMP PTI [ 33.226638] CPU: 0 PID: 297 Comm: kworker/0:5 Tainted: G E 5.3.0-rc1-default+ #311 [ 33.303342] Hardware name: HP ProLiant DL80 Gen9/ProLiant DL80 Gen9, BIOS U15 05/21/2018 [ 33.373381] Workqueue: events work_for_cpu_fn [ 33.410073] RIP: 0010:lpfc_sli4_if6_write_cq_db+0x17/0x40 [lpfc] [ 33.461269] Code: 89 10 f3 c3 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 0f 1f 44 00 00 48 85 f6 74 34 85 d2 75 0 5 80 f9 01 75 2b 31 c0 84 c9 <0f> b7 8e 98 00 00 00 0f 95 c0 c1 e2 10 81 e2 00 00 ff 1f c1 e0 1d [ 33.621155] RSP: 0018:ffffba160070fd38 EFLAGS: 00010202 [ 33.666603] RAX: 0000000000000000 RBX: ffff97fc269a2600 RCX: 0000000000000001 [ 33.729092] RDX: 0000000000000000 RSI: 00b000b000af00af RDI: ffff97fc28db2000 [ 33.792038] RBP: ffffba160070fe00 R08: 0000000000000002 R09: 000000000000593f [ 33.852386] R10: 0000000000000000 R11: ffff97fc1c0437f8 R12: 0000000000000000 [ 33.913178] R13: 0000000000000014 R14: ffff97fc28db3148 R15: ffff97fc28db2000 [ 33.974091] FS: 0000000000000000(0000) GS:ffff97fc3f800000(0000) knlGS:0000000000000000 [ 34.043535] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 34.092663] CR2: 00007f58e5617a82 CR3: 000000025520a004 CR4: 00000000001606f0 [ 34.153539] Call Trace: [ 34.174605] lpfc_sli4_hba_setup+0xf32/0x1d60 [lpfc] [ 34.216913] ? __kernfs_create_file+0x80/0xb0 [ 34.255860] ? sysfs_add_file_mode_ns+0x99/0x180 [ 34.296111] ? lpfc_pci_probe_one+0xbdc/0x13e0 [lpfc] [ 34.339767] lpfc_pci_probe_one+0xbdc/0x13e0 [lpfc] [ 34.381377] local_pci_probe+0x42/0x90 Cheers, Hannes
On 8/27/2019 6:31 AM, Hannes Reinecke wrote: > On 8/20/19 5:06 AM, Martin K. Petersen wrote: >> James, >> >>> Update lpfc to revision 12.4.0.0 >> Applied to 5.4/scsi-queue, thanks! >> > This update is crashing on my server: > > [ 33.178690] general protection fault: 0000 [#1] SMP PTI > [ 33.226638] CPU: 0 PID: 297 Comm: kworker/0:5 Tainted: G E > 5.3.0-rc1-default+ #311 > [ 33.303342] Hardware name: HP ProLiant DL80 Gen9/ProLiant DL80 Gen9, > BIOS U15 05/21/2018 > [ 33.373381] Workqueue: events work_for_cpu_fn > [ 33.410073] RIP: 0010:lpfc_sli4_if6_write_cq_db+0x17/0x40 [lpfc] > Hannes, try this patch. It appears there was an issue in patch 41: scsi: lpfc: Merge per-protocol WQ/CQ pairs into single per-cpu pair commit c00f62e6c5468ed0673c583f1ff284274e817410 -- james --- a/drivers/scsi/lpfc/lpfc_sli.c 2019-08-23 13:55:18.253546775 -0700 +++ b/drivers/scsi/lpfc_sli.c 2019-08-27 17:04:51.095330056 -0700 @@ -5553,7 +5553,7 @@ lpfc_sli4_arm_cqeq_intr(struct lpfc_hba for (qidx = 0; qidx < phba->cfg_hdw_queue; qidx++) { qp = &sli4_hba->hdwq[qidx]; /* ARM the corresponding CQ */ - sli4_hba->sli4_write_cq_db(phba, qp[qidx].io_cq, 0, + sli4_hba->sli4_write_cq_db(phba, qp->io_cq, 0, LPFC_QUEUE_REARM); }
Update lpfc to revision 12.4.0.0 This patch set contains a laundry list of fixes for lpfc. Most are small. There are a couple of cleanup patches and several functional additions at the tail of the patch set. The patches were cut against Martin's 5.4/scsi-queue tree James Smart (42): lpfc: Limit xri count for kdump environment lpfc: Fix PLOGI failure with high remoteport count lpfc: Fix ELS field alignments lpfc: Fix crash on driver unload in wq free lpfc: Fix failure to clear non-zero eq_delay after io rate reduction lpfc: Fix leak of ELS completions on adapter reset lpfc: Fix port relogin failure due to GID_FT interaction lpfc: Fix discovery when target has no GID_FT information lpfc: Fix ADISC reception terminating login state if a NVME target lpfc: Fix issuing init_vpi mbox on SLI-3 card lpfc: Fix Oops in nvme_register with target logout/login lpfc: Fix irq raising in lpfc_sli_hba_down lpfc: Fix oops when fewer hdwqs than cpus lpfc: Fix FLOGI handling across multiple link up/down conditions lpfc: Fix null ptr oops updating lpfc_devloss_tmo via sysfs attribute lpfc: Fix devices that don't return after devloss followed by rediscovery lpfc: Fix loss of remote port after devloss due to lack of RPIs lpfc: Fix propagation of devloss_tmo setting to nvme transport lpfc: Fix sg_seg_cnt for HBAs that don't support NVME lpfc: Fix driver nvme rescan logging lpfc: Fix error in remote port address change lpfc: Fix deadlock on host_lock during cable pulls lpfc: Fix crash due to port reset racing vs adapter error handling lpfc: Fix too many sg segments spamming in kernel log lpfc: Fix hang when downloading fw on port enabled for nvme lpfc: Fix nvme target mode ABTSing a received ABTS lpfc: Fix nvme sg_seg_cnt display if HBA does not support NVME lpfc: Fix sli4 adapter initialization with MSI lpfc: Fix upcall to bsg done in non-success cases lpfc: Fix Max Frame Size value shown in fdmishow output lpfc: Fix reported physical link speed on a disabled trunked link lpfc: Fix BlockGuard enablement on FCoE adapters lpfc: Fix nvme first burst module parameter description lpfc: Fix coverity warnings lpfc: Add simple unlikely optimizations to reduce NVME latency lpfc: Migrate to %px and %pf in kernel print calls lpfc: Add first and second level hardware revisions to sysfs reporting lpfc: Add MDS driver loopback diagnostics support lpfc: Support dynamic unbounded SGL lists on G7 hardware. lpfc: Add NVMe sequence level error recovery support lpfc: Merge per-protocol WQ/CQ pairs into single per-cpu pair lpfc: Update lpfc version to 12.4.0.0 drivers/scsi/lpfc/lpfc.h | 9 +- drivers/scsi/lpfc/lpfc_attr.c | 76 +++- drivers/scsi/lpfc/lpfc_bsg.c | 24 +- drivers/scsi/lpfc/lpfc_crtn.h | 3 +- drivers/scsi/lpfc/lpfc_ct.c | 68 ++- drivers/scsi/lpfc/lpfc_debugfs.c | 96 +---- drivers/scsi/lpfc/lpfc_debugfs.h | 61 +-- drivers/scsi/lpfc/lpfc_disc.h | 3 + drivers/scsi/lpfc/lpfc_els.c | 116 ++++- drivers/scsi/lpfc/lpfc_hbadisc.c | 176 +++++--- drivers/scsi/lpfc/lpfc_hw.h | 6 +- drivers/scsi/lpfc/lpfc_hw4.h | 34 ++ drivers/scsi/lpfc/lpfc_init.c | 857 +++++++++++++++++++------------------ drivers/scsi/lpfc/lpfc_mem.c | 44 +- drivers/scsi/lpfc/lpfc_nportdisc.c | 43 +- drivers/scsi/lpfc/lpfc_nvme.c | 389 ++++++++++------- drivers/scsi/lpfc/lpfc_nvmet.c | 28 +- drivers/scsi/lpfc/lpfc_scsi.c | 512 ++++++++++++++++------ drivers/scsi/lpfc/lpfc_sli.c | 529 +++++++++++++++++------ drivers/scsi/lpfc/lpfc_sli.h | 11 +- drivers/scsi/lpfc/lpfc_sli4.h | 47 +- drivers/scsi/lpfc/lpfc_version.h | 2 +- drivers/scsi/lpfc/lpfc_vport.c | 8 +- 23 files changed, 1965 insertions(+), 1177 deletions(-)