| Message ID | 20190724082508.27617-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | backlight: gpio: simplify the driver | expand |
śr., 24 lip 2019 o 10:25 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do > that. > > The first patch adds all necessary data structures to ecovec24. Patch > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > 3-4/7 remove unused platform data fields. Last three patches contain > additional improvements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 > > v1 -> v2: > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > - added additional two patches with minor improvements > > v2 -> v3: > - in patch 7/7: used initializers to set values for pdata and dev local vars > > Bartosz Golaszewski (7): > sh: ecovec24: add additional properties to the backlight device > backlight: gpio: simplify the platform data handling > sh: ecovec24: don't set unused fields in platform data > backlight: gpio: remove unused fields from platform data > backlight: gpio: remove dev from struct gpio_backlight > backlight: gpio: remove def_value from struct gpio_backlight > backlight: gpio: use a helper variable for &pdev->dev > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > include/linux/platform_data/gpio_backlight.h | 3 - > 3 files changed, 44 insertions(+), 74 deletions(-) > > -- > 2.21.0 > Daniel, I missed your review tags - could you add them again? Thanks, Bart
On Wed, Jul 24, 2019 at 10:25 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do > that. > > The first patch adds all necessary data structures to ecovec24. Patch > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > 3-4/7 remove unused platform data fields. Last three patches contain > additional improvements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 > > v1 -> v2: > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > - added additional two patches with minor improvements > > v2 -> v3: > - in patch 7/7: used initializers to set values for pdata and dev local vars The series: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
śr., 24 lip 2019 o 10:25 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do > that. > > The first patch adds all necessary data structures to ecovec24. Patch > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > 3-4/7 remove unused platform data fields. Last three patches contain > additional improvements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 > > v1 -> v2: > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > - added additional two patches with minor improvements > > v2 -> v3: > - in patch 7/7: used initializers to set values for pdata and dev local vars > > Bartosz Golaszewski (7): > sh: ecovec24: add additional properties to the backlight device > backlight: gpio: simplify the platform data handling > sh: ecovec24: don't set unused fields in platform data > backlight: gpio: remove unused fields from platform data > backlight: gpio: remove dev from struct gpio_backlight > backlight: gpio: remove def_value from struct gpio_backlight > backlight: gpio: use a helper variable for &pdev->dev > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > include/linux/platform_data/gpio_backlight.h | 3 - > 3 files changed, 44 insertions(+), 74 deletions(-) > > -- > 2.21.0 > Hi Rich, Yoshinori, can you ack the sh patches in this series? Bart
czw., 8 sie 2019 o 10:17 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > śr., 24 lip 2019 o 10:25 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > While working on my other series related to gpio-backlight[1] I noticed > > that we could simplify the driver if we made the only user of platform > > data use GPIO lookups and device properties. This series tries to do > > that. > > > > The first patch adds all necessary data structures to ecovec24. Patch > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > > 3-4/7 remove unused platform data fields. Last three patches contain > > additional improvements for the GPIO backlight driver while we're already > > modifying it. > > > > I don't have access to this HW but hopefully this works. Only compile > > tested. > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > v1 -> v2: > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > - added additional two patches with minor improvements > > > > v2 -> v3: > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > Bartosz Golaszewski (7): > > sh: ecovec24: add additional properties to the backlight device > > backlight: gpio: simplify the platform data handling > > sh: ecovec24: don't set unused fields in platform data > > backlight: gpio: remove unused fields from platform data > > backlight: gpio: remove dev from struct gpio_backlight > > backlight: gpio: remove def_value from struct gpio_backlight > > backlight: gpio: use a helper variable for &pdev->dev > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > > include/linux/platform_data/gpio_backlight.h | 3 - > > 3 files changed, 44 insertions(+), 74 deletions(-) > > > > -- > > 2.21.0 > > > > Hi Rich, Yoshinori, > > can you ack the sh patches in this series? > > Bart Ping.
pt., 16 sie 2019 o 17:48 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > czw., 8 sie 2019 o 10:17 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > > > śr., 24 lip 2019 o 10:25 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > While working on my other series related to gpio-backlight[1] I noticed > > > that we could simplify the driver if we made the only user of platform > > > data use GPIO lookups and device properties. This series tries to do > > > that. > > > > > > The first patch adds all necessary data structures to ecovec24. Patch > > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > > > 3-4/7 remove unused platform data fields. Last three patches contain > > > additional improvements for the GPIO backlight driver while we're already > > > modifying it. > > > > > > I don't have access to this HW but hopefully this works. Only compile > > > tested. > > > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > > > v1 -> v2: > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > > - added additional two patches with minor improvements > > > > > > v2 -> v3: > > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > > > Bartosz Golaszewski (7): > > > sh: ecovec24: add additional properties to the backlight device > > > backlight: gpio: simplify the platform data handling > > > sh: ecovec24: don't set unused fields in platform data > > > backlight: gpio: remove unused fields from platform data > > > backlight: gpio: remove dev from struct gpio_backlight > > > backlight: gpio: remove def_value from struct gpio_backlight > > > backlight: gpio: use a helper variable for &pdev->dev > > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > > > include/linux/platform_data/gpio_backlight.h | 3 - > > > 3 files changed, 44 insertions(+), 74 deletions(-) > > > > > > -- > > > 2.21.0 > > > > > > > Hi Rich, Yoshinori, > > > > can you ack the sh patches in this series? > > > > Bart > > Ping. Hi, any chance of getting this reviewed for sh? Bart
CC the pour soul with the ecovec board. On Wed, Aug 28, 2019 at 9:33 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > pt., 16 sie 2019 o 17:48 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > czw., 8 sie 2019 o 10:17 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > > śr., 24 lip 2019 o 10:25 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > > > While working on my other series related to gpio-backlight[1] I noticed > > > > that we could simplify the driver if we made the only user of platform > > > > data use GPIO lookups and device properties. This series tries to do > > > > that. > > > > > > > > The first patch adds all necessary data structures to ecovec24. Patch > > > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > > > > 3-4/7 remove unused platform data fields. Last three patches contain > > > > additional improvements for the GPIO backlight driver while we're already > > > > modifying it. > > > > > > > > I don't have access to this HW but hopefully this works. Only compile > > > > tested. > > > > > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > > > > > v1 -> v2: > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > > > - added additional two patches with minor improvements > > > > > > > > v2 -> v3: > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > > > > > Bartosz Golaszewski (7): > > > > sh: ecovec24: add additional properties to the backlight device > > > > backlight: gpio: simplify the platform data handling > > > > sh: ecovec24: don't set unused fields in platform data > > > > backlight: gpio: remove unused fields from platform data > > > > backlight: gpio: remove dev from struct gpio_backlight > > > > backlight: gpio: remove def_value from struct gpio_backlight > > > > backlight: gpio: use a helper variable for &pdev->dev > > > > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > > > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > > > > include/linux/platform_data/gpio_backlight.h | 3 - > > > > 3 files changed, 44 insertions(+), 74 deletions(-) > > > > > > > > -- > > > > 2.21.0 > > > > > > > > > > Hi Rich, Yoshinori, > > > > > > can you ack the sh patches in this series? > > > > > > Bart > > > > Ping. > > Hi, > > any chance of getting this reviewed for sh? Gr{oetje,eeting}s, Geert
On Wed, Aug 28, 2019 at 10:36 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> CC the pour soul with the ecovec board.
With great power comes great responsibility ;)
Yours,
Linus Walleij
Hi Geert, On Wed, Aug 28, 2019 at 06:31:19PM +0200, Linus Walleij wrote: > On Wed, Aug 28, 2019 at 10:36 AM Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > > CC the pour soul with the ecovec board. > I'm sorry, Eco what ? :) > With great power comes great responsibility ;) > Yeah, that's -exactly- a 'great powers' board :) I'll try to resurect it from the deads again and get back eventually with a tested-by. I only briefly looked at the series and I don't have any LCD to test the backlight with, I hope I can sample the backlight GPIO value from some test point, if I ever find the schematics... > Yours, > Linus Walleij
On Wed, 24 Jul 2019, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do > that. > > The first patch adds all necessary data structures to ecovec24. Patch > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > 3-4/7 remove unused platform data fields. Last three patches contain > additional improvements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 > > v1 -> v2: > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > - added additional two patches with minor improvements > > v2 -> v3: > - in patch 7/7: used initializers to set values for pdata and dev local vars > > Bartosz Golaszewski (7): > sh: ecovec24: add additional properties to the backlight device > backlight: gpio: simplify the platform data handling > sh: ecovec24: don't set unused fields in platform data > backlight: gpio: remove unused fields from platform data > backlight: gpio: remove dev from struct gpio_backlight > backlight: gpio: remove def_value from struct gpio_backlight > backlight: gpio: use a helper variable for &pdev->dev > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > include/linux/platform_data/gpio_backlight.h | 3 - > 3 files changed, 44 insertions(+), 74 deletions(-) Can you collect all your Acks and re-submit please?
pon., 2 wrz 2019 o 11:31 Lee Jones <lee.jones@linaro.org> napisał(a): > > On Wed, 24 Jul 2019, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > While working on my other series related to gpio-backlight[1] I noticed > > that we could simplify the driver if we made the only user of platform > > data use GPIO lookups and device properties. This series tries to do > > that. > > > > The first patch adds all necessary data structures to ecovec24. Patch > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > > 3-4/7 remove unused platform data fields. Last three patches contain > > additional improvements for the GPIO backlight driver while we're already > > modifying it. > > > > I don't have access to this HW but hopefully this works. Only compile > > tested. > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > v1 -> v2: > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > - added additional two patches with minor improvements > > > > v2 -> v3: > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > Bartosz Golaszewski (7): > > sh: ecovec24: add additional properties to the backlight device > > backlight: gpio: simplify the platform data handling > > sh: ecovec24: don't set unused fields in platform data > > backlight: gpio: remove unused fields from platform data > > backlight: gpio: remove dev from struct gpio_backlight > > backlight: gpio: remove def_value from struct gpio_backlight > > backlight: gpio: use a helper variable for &pdev->dev > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > > include/linux/platform_data/gpio_backlight.h | 3 - > > 3 files changed, 44 insertions(+), 74 deletions(-) > > Can you collect all your Acks and re-submit please? > Done. Bart > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch adds all necessary data structures to ecovec24. Patch 2/7 unifies much of the code for both pdata and non-pdata cases. Patches 3-4/7 remove unused platform data fields. Last three patches contain additional improvements for the GPIO backlight driver while we're already modifying it. I don't have access to this HW but hopefully this works. Only compile tested. [1] https://lkml.org/lkml/2019/6/25/900 v1 -> v2: - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy - added additional two patches with minor improvements v2 -> v3: - in patch 7/7: used initializers to set values for pdata and dev local vars Bartosz Golaszewski (7): sh: ecovec24: add additional properties to the backlight device backlight: gpio: simplify the platform data handling sh: ecovec24: don't set unused fields in platform data backlight: gpio: remove unused fields from platform data backlight: gpio: remove dev from struct gpio_backlight backlight: gpio: remove def_value from struct gpio_backlight backlight: gpio: use a helper variable for &pdev->dev arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 44 insertions(+), 74 deletions(-)