| Message ID | 1565086474-4461-1-git-send-email-rayagonda.kokatanur@broadcom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/1] spi: bcm-qspi: Make BSPI default mode | expand |
On Tue, Aug 06, 2019 at 03:44:34PM +0530, Rayagonda Kokatanur wrote: > Switch back to BSPI mode after MSPI operations (write and erase) > are completed. This change will keep qpsi in BSPI mode by default. Why?
The spi-nor controller defaults to BSPI mode. So its being put to its default mode. Kamal On Tue, Aug 6, 2019 at 8:16 AM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Aug 06, 2019 at 03:44:34PM +0530, Rayagonda Kokatanur wrote: > > Switch back to BSPI mode after MSPI operations (write and erase) > > are completed. This change will keep qpsi in BSPI mode by default. > > Why?
On Tue, Aug 27, 2019 at 09:01:42AM -0400, Kamal Dasu wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > The spi-nor controller defaults to BSPI mode. So its being put to its > default mode. The changelog should explain this.
diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index 902bdbf..46a811a 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -897,6 +897,7 @@ static int bcm_qspi_transfer_one(struct spi_master *master, read_from_hw(qspi, slots); } + bcm_qspi_enable_bspi(qspi); return 0; }
Switch back to BSPI mode after MSPI operations (write and erase) are completed. This change will keep qpsi in BSPI mode by default. Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> --- drivers/spi/spi-bcm-qspi.c | 1 + 1 file changed, 1 insertion(+)