Message ID | 20190902080603.5636-2-horms+renesas@verge.net.au (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Geert Uytterhoeven |
Headers | show |
Series | ravb: Remove use of undocumented registers | expand |
Hi Simon-san, Thank you for the patch! > From: Simon Horman, Sent: Monday, September 2, 2019 5:06 PM > > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > The field name is FBP rather than FPB. > > This field is unused and could equally be removed from the driver entirely. > But there seems no harm in leaving as documentation of the presence of the > field. > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v0 - Kazuya Mizuguchi > > v1 - Simon Horman > * Extracted from larger patch > * Wrote changelog > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index ac9195add811..bdb051f04b0c 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -317,7 +312,7 @@ enum UFCD_BIT { > > /* SFO */ > enum SFO_BIT { > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ > --- > drivers/net/ethernet/renesas/ravb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h This patch has two same diff. After removed either one of them, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > index ac9195add811..2596a95a4300 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -317,7 +317,7 @@ enum UFCD_BIT { > > /* SFO */ > enum SFO_BIT { > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ > -- > 2.11.0
Hello! On 09/02/2019 11:06 AM, Simon Horman wrote: > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > The field name is FBP rather than FPB. > > This field is unused and could equally be removed from the driver entirely. > But there seems no harm in leaving as documentation of the presence of the > field. > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- > v0 - Kazuya Mizuguchi > > v1 - Simon Horman > * Extracted from larger patch I'd just claim the authorship in this case (and mentioned that it's based on Mizuguchi-san's large patch right in the change log). > * Wrote changelog > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index ac9195add811..bdb051f04b0c 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -317,7 +312,7 @@ enum UFCD_BIT { > > /* SFO */ > enum SFO_BIT { > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ > --- This is where the actual patch starts, right? > drivers/net/ethernet/renesas/ravb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index ac9195add811..2596a95a4300 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -317,7 +317,7 @@ enum UFCD_BIT { > > /* SFO */ > enum SFO_BIT { > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ MBR, Sergei
From: Simon Horman <horms+renesas@verge.net.au> Date: Mon, 2 Sep 2019 10:06:01 +0200 > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ > --- > drivers/net/ethernet/renesas/ravb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h Simon please clean this up, I don't know what happened here :-)
On Mon, Sep 02, 2019 at 11:33:55AM -0700, David Miller wrote: > From: Simon Horman <horms+renesas@verge.net.au> > Date: Mon, 2 Sep 2019 10:06:01 +0200 > > > - SFO_FPB = 0x0000003F, > > + SFO_FBP = 0x0000003F, > > }; > > > > /* RTC */ > > --- > > drivers/net/ethernet/renesas/ravb.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > > Simon please clean this up, I don't know what happened here :-) Yeah, sorry about that. I don't know how it happened either.
diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h index ac9195add811..bdb051f04b0c 100644 --- a/drivers/net/ethernet/renesas/ravb.h +++ b/drivers/net/ethernet/renesas/ravb.h @@ -317,7 +312,7 @@ enum UFCD_BIT { /* SFO */ enum SFO_BIT { - SFO_FPB = 0x0000003F, + SFO_FBP = 0x0000003F, }; /* RTC */ --- drivers/net/ethernet/renesas/ravb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h index ac9195add811..2596a95a4300 100644 --- a/drivers/net/ethernet/renesas/ravb.h +++ b/drivers/net/ethernet/renesas/ravb.h @@ -317,7 +317,7 @@ enum UFCD_BIT { /* SFO */ enum SFO_BIT { - SFO_FPB = 0x0000003F, + SFO_FBP = 0x0000003F, }; /* RTC */