| Message ID | 20190904022120.4174-1-andrew@aj.id.au (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 72976643aef55a2a3eec85e5342a3c3608f66e64 |
| Headers | show |
| Series | [v3] mmc: sdhci-of-aspeed: Depend on CONFIG_OF_ADDRESS | expand |
On Wed, 4 Sep 2019 at 04:20, Andrew Jeffery <andrew@aj.id.au> wrote: > > Resolves the following build error reported by the 0-day bot: > > ERROR: "of_platform_device_create" [drivers/mmc/host/sdhci-of-aspeed.ko] undefined! > > SPARC does not set CONFIG_OF_ADDRESS so the symbol is missing. Depend on > CONFIG_OF_ADDRESS to ensure the driver is only built for supported > configurations. > > Fixes: 2d28dbe042f4 ("mmc: sdhci-of-aspeed: Add support for the ASPEED SD controller") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Applied for next, thanks! Kind regards Uffe > --- > v2 was a series of 4 patches, three of which were applied leaving this build > fix to be reworked. The v2 series can be found here: > > https://patchwork.ozlabs.org/cover/1156457/ > > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 0f8a230de2f3..3a52f5703286 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -157,7 +157,7 @@ config MMC_SDHCI_OF_ARASAN > config MMC_SDHCI_OF_ASPEED > tristate "SDHCI OF support for the ASPEED SDHCI controller" > depends on MMC_SDHCI_PLTFM > - depends on OF > + depends on OF && OF_ADDRESS > help > This selects the ASPEED Secure Digital Host Controller Interface. > > -- > 2.20.1 >
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 0f8a230de2f3..3a52f5703286 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -157,7 +157,7 @@ config MMC_SDHCI_OF_ARASAN config MMC_SDHCI_OF_ASPEED tristate "SDHCI OF support for the ASPEED SDHCI controller" depends on MMC_SDHCI_PLTFM - depends on OF + depends on OF && OF_ADDRESS help This selects the ASPEED Secure Digital Host Controller Interface.
Resolves the following build error reported by the 0-day bot: ERROR: "of_platform_device_create" [drivers/mmc/host/sdhci-of-aspeed.ko] undefined! SPARC does not set CONFIG_OF_ADDRESS so the symbol is missing. Depend on CONFIG_OF_ADDRESS to ensure the driver is only built for supported configurations. Fixes: 2d28dbe042f4 ("mmc: sdhci-of-aspeed: Add support for the ASPEED SD controller") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- v2 was a series of 4 patches, three of which were applied leaving this build fix to be reworked. The v2 series can be found here: https://patchwork.ozlabs.org/cover/1156457/ drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)