| Message ID | 20190905070649.13975-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: remove sched-if.h includes from various sources | expand |
On 05.09.2019 09:06, Juergen Gross wrote: > xen/sched-if.h is included in multiple sources where it isn't directly > needed. Remove those #include statements. > > Suggested-by: Jan Beulich <jbeulich@suse.com> > Signed-off-by: Juergen Gross <jgross@suse.com> Given the tag in place already I'm not sure this is needed, but just in case: Acked-by: Jan Beulich <jbeulich@suse.com> Jan
On 05/09/2019 08:21, Jan Beulich wrote: > On 05.09.2019 09:06, Juergen Gross wrote: >> xen/sched-if.h is included in multiple sources where it isn't directly >> needed. Remove those #include statements. >> >> Suggested-by: Jan Beulich <jbeulich@suse.com> >> Signed-off-by: Juergen Gross <jgross@suse.com> > Given the tag in place already I'm not sure this is needed, but just > in case: > Acked-by: Jan Beulich <jbeulich@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> Last time I played this game (which was this dev cycle), I found that all includes were still necessary. Clearly something has changed in staging - any idea what? ~Andrew
diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c index 8f7b6e9b8c..836f524ef4 100644 --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -38,7 +38,6 @@ #include <xen/guest_access.h> #include <xen/keyhandler.h> #include <xen/trace.h> -#include <xen/sched-if.h> #include <xen/irq.h> #include <asm/cache.h> #include <asm/io.h> diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index 28ad7dd659..4b2b6de191 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -10,7 +10,6 @@ #include <xen/errno.h> #include <xen/console.h> #include <xen/sched.h> -#include <xen/sched-if.h> #include <xen/cpumask.h> #include <xen/event.h> #include <xen/guest_access.h> diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c b/xen/arch/x86/cpu/mcheck/mctelem.c index 3bb13e5265..012a9b95e5 100644 --- a/xen/arch/x86/cpu/mcheck/mctelem.c +++ b/xen/arch/x86/cpu/mcheck/mctelem.c @@ -18,7 +18,6 @@ #include <xen/smp.h> #include <xen/errno.h> #include <xen/sched.h> -#include <xen/sched-if.h> #include <xen/cpumask.h> #include <xen/event.h> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index d0b35b0ce2..5a88ef368f 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -3,7 +3,6 @@ #include <xen/err.h> #include <xen/grant_table.h> #include <xen/sched.h> -#include <xen/sched-if.h> #include <xen/domain.h> #include <xen/serial.h> #include <xen/softirq.h> diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 5c4254ac87..911416c1e1 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -25,7 +25,6 @@ #include <xen/domain.h> #include <xen/domain_page.h> #include <xen/sched.h> -#include <xen/sched-if.h> #include <xen/irq.h> #include <xen/delay.h> #include <xen/softirq.h>
xen/sched-if.h is included in multiple sources where it isn't directly needed. Remove those #include statements. Suggested-by: Jan Beulich <jbeulich@suse.com> Signed-off-by: Juergen Gross <jgross@suse.com> --- Carved out from patch 7 of my core scheduling series --- xen/arch/x86/acpi/cpu_idle.c | 1 - xen/arch/x86/cpu/mcheck/mce.c | 1 - xen/arch/x86/cpu/mcheck/mctelem.c | 1 - xen/arch/x86/setup.c | 1 - xen/arch/x86/smpboot.c | 1 - 5 files changed, 5 deletions(-)