| Message ID | 20190905064400.24800-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f4df4e4042b045c6ddbaff878a17ae169fe68ba6 |
| Headers | show |
| Series | [-next] ASoC: SOF: imx8: Fix COMPILE_TEST error | expand |
On Thu, 2019-09-05 at 14:44 +0800, YueHaibing wrote: > When do compile test, if SND_SOC_SOF_OF is not set, we get: > > sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_request': > imx8.c:(.text+0xb0): undefined reference to `snd_sof_ipc_msgs_rx' > sound/soc/sof/imx/imx8.o: In function `imx8_ipc_msg_data': > imx8.c:(.text+0xf4): undefined reference to `sof_mailbox_read' > sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_reply': > imx8.c:(.text+0x160): undefined reference to `sof_mailbox_read' > > Make SND_SOC_SOF_IMX_TOPLEVEL always depends on SND_SOC_SOF_OF > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > sound/soc/sof/imx/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig > index fd73d84..5acae75 100644 > --- a/sound/soc/sof/imx/Kconfig > +++ b/sound/soc/sof/imx/Kconfig > @@ -2,7 +2,8 @@ > > config SND_SOC_SOF_IMX_TOPLEVEL > bool "SOF support for NXP i.MX audio DSPs" > - depends on ARM64 && SND_SOC_SOF_OF || COMPILE_TEST > + depends on ARM64|| COMPILE_TEST > + depends on SND_SOC_SOF_OF > help > This adds support for Sound Open Firmware for NXP i.MX > platforms. > Say Y if you have such a device.
On 9/5/19 1:44 AM, YueHaibing wrote: > When do compile test, if SND_SOC_SOF_OF is not set, we get: > > sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_request': > imx8.c:(.text+0xb0): undefined reference to `snd_sof_ipc_msgs_rx' > sound/soc/sof/imx/imx8.o: In function `imx8_ipc_msg_data': > imx8.c:(.text+0xf4): undefined reference to `sof_mailbox_read' > sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_reply': > imx8.c:(.text+0x160): undefined reference to `sof_mailbox_read' > > Make SND_SOC_SOF_IMX_TOPLEVEL always depends on SND_SOC_SOF_OF > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > sound/soc/sof/imx/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig > index fd73d84..5acae75 100644 > --- a/sound/soc/sof/imx/Kconfig > +++ b/sound/soc/sof/imx/Kconfig > @@ -2,7 +2,8 @@ > > config SND_SOC_SOF_IMX_TOPLEVEL > bool "SOF support for NXP i.MX audio DSPs" > - depends on ARM64 && SND_SOC_SOF_OF || COMPILE_TEST > + depends on ARM64|| COMPILE_TEST > + depends on SND_SOC_SOF_OF > help > This adds support for Sound Open Firmware for NXP i.MX platforms. > Say Y if you have such a device. >
diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig index fd73d84..5acae75 100644 --- a/sound/soc/sof/imx/Kconfig +++ b/sound/soc/sof/imx/Kconfig @@ -2,7 +2,8 @@ config SND_SOC_SOF_IMX_TOPLEVEL bool "SOF support for NXP i.MX audio DSPs" - depends on ARM64 && SND_SOC_SOF_OF || COMPILE_TEST + depends on ARM64|| COMPILE_TEST + depends on SND_SOC_SOF_OF help This adds support for Sound Open Firmware for NXP i.MX platforms. Say Y if you have such a device.
When do compile test, if SND_SOC_SOF_OF is not set, we get: sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_request': imx8.c:(.text+0xb0): undefined reference to `snd_sof_ipc_msgs_rx' sound/soc/sof/imx/imx8.o: In function `imx8_ipc_msg_data': imx8.c:(.text+0xf4): undefined reference to `sof_mailbox_read' sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_reply': imx8.c:(.text+0x160): undefined reference to `sof_mailbox_read' Make SND_SOC_SOF_IMX_TOPLEVEL always depends on SND_SOC_SOF_OF Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- sound/soc/sof/imx/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)