| Message ID | 1567693630-27544-2-git-send-email-arnaud.pouliquen@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add API to get rpmsg message max length | expand |
On Thu, Sep 5, 2019 at 8:35 AM Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: > > Return the rpmsg buffer size for sending message, so rpmsg users > can split a long message in several sub rpmsg buffers. > > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> > --- > drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 2 ++ > drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ > include/linux/rpmsg.h | 10 ++++++++++ > 4 files changed, 43 insertions(+) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index e330ec4dfc33..a6ef54c4779a 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, > } > EXPORT_SYMBOL(rpmsg_trysend_offchannel); > > +/** > + * rpmsg_get_mtu() - get maximum transmission buffer size for sending message. > + * @ept: the rpmsg endpoint > + * > + * This function returns maximum buffer size available for a single message. > + * > + * Return: the maximum transmission size on success and an appropriate error > + * value on failure. > + */ What is the intent of this? The term "mtu" is "maximum transfer unit" - ie the largest payload of data that could possibly be sent, however at any one point in time, that might not be able to be accommodated. I don't think this is implemented correctly. In GLINK and SMD, you've not implemented MTU, you've implemented "how much can I send at this point in time". To me, this is not mtu. In the case of SMD, you could get the fifo size and return that as the mtu, but since you seem to be wanting to use this from the TTY layer to determine how much can be sent at a particular point in time, I don't think you actually want mtu. For GLINK, I don't actually think you can get a mtu based on the design, but I'm trying to remember from 5-6 years ago when we designed it. It would be possible that a larger intent would be made available later. I think you need to first determine if you are actually looking for mtu, or "how much data can I send right now", because right now, it isn't clear.
Hi Jeffrey, On 9/5/19 4:42 PM, Jeffrey Hugo wrote: > On Thu, Sep 5, 2019 at 8:35 AM Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: >> >> Return the rpmsg buffer size for sending message, so rpmsg users >> can split a long message in several sub rpmsg buffers. >> >> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> >> --- >> drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++++++++++ >> drivers/rpmsg/rpmsg_internal.h | 2 ++ >> drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ >> include/linux/rpmsg.h | 10 ++++++++++ >> 4 files changed, 43 insertions(+) >> >> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c >> index e330ec4dfc33..a6ef54c4779a 100644 >> --- a/drivers/rpmsg/rpmsg_core.c >> +++ b/drivers/rpmsg/rpmsg_core.c >> @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, >> } >> EXPORT_SYMBOL(rpmsg_trysend_offchannel); >> >> +/** >> + * rpmsg_get_mtu() - get maximum transmission buffer size for sending message. >> + * @ept: the rpmsg endpoint >> + * >> + * This function returns maximum buffer size available for a single message. >> + * >> + * Return: the maximum transmission size on success and an appropriate error >> + * value on failure. >> + */ > > What is the intent of this? > > The term "mtu" is "maximum transfer unit" - ie the largest payload of > data that could possibly be sent, however at any one point in time, > that might not be able to be accommodated. I was not aware that the MTU has to be static in time. And I'm not enough expert to be able challenge this. The use of the MTU initially came from a Bjorn request and IMHO makes sense in RPMSG protocol as other protocols. The aim here is not to guaranty the available size but to provide to rpmsg client a packet size information that is not available today at rpmsg client level. For instance for the virtio rpmsg bus we provide the size of a vring buffer, not the total size available in the vring. > > I don't think this is implemented correctly. In GLINK and SMD, you've > not implemented MTU, you've implemented "how much can I send at this > point in time". To me, this is not mtu. If MTU has to be static i agree with you. > > In the case of SMD, you could get the fifo size and return that as the > mtu, but since you seem to be wanting to use this from the TTY layer > to determine how much can be sent at a particular point in time, I > don't think you actually want mtu. Please forget the TTY for the moment, The mtu is used to help the tty framework to split the buffer to write. The size is then adjusted on write. For SMD i can provide the fifo_size,or a division of this size to "limit" congestion. would this make sense for you? > > For GLINK, I don't actually think you can get a mtu based on the > design, but I'm trying to remember from 5-6 years ago when we designed > it. It would be possible that a larger intent would be made available > later. Is it possible to have the largest intent? or it's not deterministic. > > I think you need to first determine if you are actually looking for > mtu, or "how much data can I send right now", because right now, it > isn't clear. > In my view it is the MTU. "how much data can I send right now" is an information that is very volatile as buffers can be shared between several clients, therefore unusable. An alternative would be to make this ops optional, but that would mean that some generic clients would not be compatible with SMD and/or Glink drivers. Thanks, Arnaud
On Thu, Sep 5, 2019 at 10:02 AM Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: > > Hi Jeffrey, > > > On 9/5/19 4:42 PM, Jeffrey Hugo wrote: > > On Thu, Sep 5, 2019 at 8:35 AM Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: > >> > >> Return the rpmsg buffer size for sending message, so rpmsg users > >> can split a long message in several sub rpmsg buffers. > >> > >> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> > >> --- > >> drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++++++++++ > >> drivers/rpmsg/rpmsg_internal.h | 2 ++ > >> drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ > >> include/linux/rpmsg.h | 10 ++++++++++ > >> 4 files changed, 43 insertions(+) > >> > >> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > >> index e330ec4dfc33..a6ef54c4779a 100644 > >> --- a/drivers/rpmsg/rpmsg_core.c > >> +++ b/drivers/rpmsg/rpmsg_core.c > >> @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, > >> } > >> EXPORT_SYMBOL(rpmsg_trysend_offchannel); > >> > >> +/** > >> + * rpmsg_get_mtu() - get maximum transmission buffer size for sending message. > >> + * @ept: the rpmsg endpoint > >> + * > >> + * This function returns maximum buffer size available for a single message. > >> + * > >> + * Return: the maximum transmission size on success and an appropriate error > >> + * value on failure. > >> + */ > > > > What is the intent of this? > > > > The term "mtu" is "maximum transfer unit" - ie the largest payload of > > data that could possibly be sent, however at any one point in time, > > that might not be able to be accommodated. > I was not aware that the MTU has to be static in time. And I'm not > enough expert to be able challenge this. > The use of the MTU initially came from a Bjorn request and IMHO makes > sense in RPMSG protocol as other protocols. The aim here is not to > guaranty the available size but to provide to rpmsg client a packet size > information that is not available today at rpmsg client level. > For instance for the virtio rpmsg bus we provide the size of a vring > buffer, not the total size available in the vring. > > > > > I don't think this is implemented correctly. In GLINK and SMD, you've > > not implemented MTU, you've implemented "how much can I send at this > > point in time". To me, this is not mtu. > If MTU has to be static i agree with you. > > > > In the case of SMD, you could get the fifo size and return that as the > > mtu, but since you seem to be wanting to use this from the TTY layer > > to determine how much can be sent at a particular point in time, I > > don't think you actually want mtu. > Please forget the TTY for the moment, The mtu is used to help the tty > framework to split the buffer to write. The size is then adjusted on write. > For SMD i can provide the fifo_size,or a division of this size to > "limit" congestion. > would this make sense for you? Historically, TTY over SMD (I'm basing this on my experience with the downstream code) has operated in a streaming fasion, where it attempts to put as much data as will fit in the fifo at that point in time. So you would have a "write_size_avail" operation that returns the amount of free space in the fifo, and then the TTY client would attempt to write that amount of data into the fifo. In sort, the fifo size is the maximum that could be put into the transport, but at any one point in time, there may be data sitting in the fifo that the remote end has not yet procesed, which would limit the amount of data you could put in the fifo to fifo_size - size of data currently sitting in the fifo. SMD channels have dedicated fifos, and are assumed to be used for a single client. If the channel is muxed between multiple clients, and you want to manage "congestion", that would need to be managed at a layer above SMD. > > > > For GLINK, I don't actually think you can get a mtu based on the > > design, but I'm trying to remember from 5-6 years ago when we designed > > it. It would be possible that a larger intent would be made available > > later. > Is it possible to have the largest intent? or it's not deterministic. Not really. I think GLINK defines a maximum size that it can handle as an intent (something like uint32_max), however there is no guarantee that any particular client will support that. If you attempt to have the MTU as the max that GLINK supports, and a client never queues an intent that large, the data will never be able to be transmitted. The MTU is really based on the the whims of the remote side, and I don't recall if there is a way in the GLINK protocol to query that. If I recall correctly, there is a way to request the remote side queue an intent of a specific size, which the remote side can either do (success) or reject the request (failure). In my mind, there should be a valid scenario in which a client can transmit data of a size equal to the MTU (although the client may need to wait for that to happen), however I don't have a simple answer on how to determine that value in a generic way for GLINK. > > > > I think you need to first determine if you are actually looking for > > mtu, or "how much data can I send right now", because right now, it > > isn't clear. > > > In my view it is the MTU. "how much data can I send right now" is an > information that is very volatile as buffers can be shared between > several clients, therefore unusable. Thats valid. If you want MTU, then I think you need to fix the GLINK/SMD implementations since those are not providing the correct information. Unfortunately, GLINK is complicated. I think Bjorn should chime in on what he thinks would be valid behavior for GLINK.
On 9/5/19 6:18 PM, Jeffrey Hugo wrote: > On Thu, Sep 5, 2019 at 10:02 AM Arnaud Pouliquen > <arnaud.pouliquen@st.com> wrote: >> >> Hi Jeffrey, >> >> >> On 9/5/19 4:42 PM, Jeffrey Hugo wrote: >>> On Thu, Sep 5, 2019 at 8:35 AM Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: >>>> >>>> Return the rpmsg buffer size for sending message, so rpmsg users >>>> can split a long message in several sub rpmsg buffers. >>>> >>>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> >>>> --- >>>> drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++++++++++ >>>> drivers/rpmsg/rpmsg_internal.h | 2 ++ >>>> drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ >>>> include/linux/rpmsg.h | 10 ++++++++++ >>>> 4 files changed, 43 insertions(+) >>>> >>>> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c >>>> index e330ec4dfc33..a6ef54c4779a 100644 >>>> --- a/drivers/rpmsg/rpmsg_core.c >>>> +++ b/drivers/rpmsg/rpmsg_core.c >>>> @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, >>>> } >>>> EXPORT_SYMBOL(rpmsg_trysend_offchannel); >>>> >>>> +/** >>>> + * rpmsg_get_mtu() - get maximum transmission buffer size for sending message. >>>> + * @ept: the rpmsg endpoint >>>> + * >>>> + * This function returns maximum buffer size available for a single message. >>>> + * >>>> + * Return: the maximum transmission size on success and an appropriate error >>>> + * value on failure. >>>> + */ >>> >>> What is the intent of this? >>> >>> The term "mtu" is "maximum transfer unit" - ie the largest payload of >>> data that could possibly be sent, however at any one point in time, >>> that might not be able to be accommodated. >> I was not aware that the MTU has to be static in time. And I'm not >> enough expert to be able challenge this. >> The use of the MTU initially came from a Bjorn request and IMHO makes >> sense in RPMSG protocol as other protocols. The aim here is not to >> guaranty the available size but to provide to rpmsg client a packet size >> information that is not available today at rpmsg client level. >> For instance for the virtio rpmsg bus we provide the size of a vring >> buffer, not the total size available in the vring. >> >>> >>> I don't think this is implemented correctly. In GLINK and SMD, you've >>> not implemented MTU, you've implemented "how much can I send at this >>> point in time". To me, this is not mtu. >> If MTU has to be static i agree with you. >>> >>> In the case of SMD, you could get the fifo size and return that as the >>> mtu, but since you seem to be wanting to use this from the TTY layer >>> to determine how much can be sent at a particular point in time, I >>> don't think you actually want mtu. >> Please forget the TTY for the moment, The mtu is used to help the tty >> framework to split the buffer to write. The size is then adjusted on write. >> For SMD i can provide the fifo_size,or a division of this size to >> "limit" congestion. >> would this make sense for you? > > Historically, TTY over SMD (I'm basing this on my experience with the > downstream code) has operated in a streaming fasion, where it attempts > to put as much data as will fit in the fifo at that point in time. So > you would have a "write_size_avail" operation that returns the amount > of free space in the fifo, and then the TTY client would attempt to > write that amount of data into the fifo. > > In sort, the fifo size is the maximum that could be put into the > transport, but at any one point in time, there may be data sitting in > the fifo that the remote end has not yet procesed, which would limit > the amount of data you could put in the fifo to fifo_size - size of > data currently sitting in the fifo. Regarding __qcom_smd_send function. if message length is higher than fifo_size EINVAL error is returned, else if send failed EAGAIN error is returned ( meaning that it is busy and that client has to retry to sent it later). Based on this behavior, seems make sense to return channel->fifo_size as MTU value. > > SMD channels have dedicated fifos, and are assumed to be used for a > single client. If the channel is muxed between multiple clients, and > you want to manage "congestion", that would need to be managed at a > layer above SMD. Yes this is the flow control that could have to be in core or splitted between the core and the platform driver. We had a first discussion with Bjorn few month ago on this subject, the need was identified. >>> >>> For GLINK, I don't actually think you can get a mtu based on the >>> design, but I'm trying to remember from 5-6 years ago when we designed >>> it. It would be possible that a larger intent would be made available >>> later. >> Is it possible to have the largest intent? or it's not deterministic. > > Not really. I think GLINK defines a maximum size that it can handle > as an intent (something like uint32_max), however there is no > guarantee that any particular client will support that. If you > attempt to have the MTU as the max that GLINK supports, and a client > never queues an intent that large, the data will never be able to be > transmitted. The MTU is really based on the the whims of the remote > side, and I don't recall if there is a way in the GLINK protocol to > query that. If I recall correctly, there is a way to request the > remote side queue an intent of a specific size, which the remote side > can either do (success) or reject the request (failure). > > In my mind, there should be a valid scenario in which a client can > transmit data of a size equal to the MTU (although the client may need > to wait for that to happen), however I don't have a simple answer on > how to determine that value in a generic way for GLINK. So no simple way for GLINK :(, anyway thanks for you time and your expertise. > >>> >>> I think you need to first determine if you are actually looking for >>> mtu, or "how much data can I send right now", because right now, it >>> isn't clear. >>> >> In my view it is the MTU. "how much data can I send right now" is an >> information that is very volatile as buffers can be shared between >> several clients, therefore unusable. > > Thats valid. If you want MTU, then I think you need to fix the > GLINK/SMD implementations since those are not providing the correct > information. Unfortunately, GLINK is complicated. I think Bjorn > should chime in on what he thinks would be valid behavior for GLINK. > An alternative could be a DT property that could be defined depending on the remote side constraint. Bjorn, please, could you share your view to help to find a solution to implement the MTU for Glink? or should we simply consider the MTU ops as optional and in this case how to determine a default size? Thanks, Arnaud
diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index e330ec4dfc33..a6ef54c4779a 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, } EXPORT_SYMBOL(rpmsg_trysend_offchannel); +/** + * rpmsg_get_mtu() - get maximum transmission buffer size for sending message. + * @ept: the rpmsg endpoint + * + * This function returns maximum buffer size available for a single message. + * + * Return: the maximum transmission size on success and an appropriate error + * value on failure. + */ + +ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept) +{ + if (WARN_ON(!ept)) + return -EINVAL; + if (!ept->ops->get_mtu) + return -ENOTSUPP; + + return ept->ops->get_mtu(ept); +} +EXPORT_SYMBOL(rpmsg_get_mtu); + /* * match an rpmsg channel with a channel info struct. * this is used to make sure we're not creating rpmsg devices for channels diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h index 3fc83cd50e98..12b9e72adc75 100644 --- a/drivers/rpmsg/rpmsg_internal.h +++ b/drivers/rpmsg/rpmsg_internal.h @@ -47,6 +47,7 @@ struct rpmsg_device_ops { * @trysendto: see @rpmsg_trysendto(), optional * @trysend_offchannel: see @rpmsg_trysend_offchannel(), optional * @poll: see @rpmsg_poll(), optional + * @get_mtu: see @get_mpu(), required * * Indirection table for the operations that a rpmsg backend should implement. * In addition to @destroy_ept, the backend must at least implement @send and @@ -66,6 +67,7 @@ struct rpmsg_endpoint_ops { void *data, int len); __poll_t (*poll)(struct rpmsg_endpoint *ept, struct file *filp, poll_table *wait); + ssize_t (*get_mtu)(struct rpmsg_endpoint *ept); }; int rpmsg_register_device(struct rpmsg_device *rpdev); diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 376ebbf880d6..6e48fdf24555 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -175,6 +175,7 @@ static int virtio_rpmsg_trysendto(struct rpmsg_endpoint *ept, void *data, int len, u32 dst); static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, void *data, int len); +static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept); static const struct rpmsg_endpoint_ops virtio_endpoint_ops = { .destroy_ept = virtio_rpmsg_destroy_ept, @@ -184,6 +185,7 @@ static const struct rpmsg_endpoint_ops virtio_endpoint_ops = { .trysend = virtio_rpmsg_trysend, .trysendto = virtio_rpmsg_trysendto, .trysend_offchannel = virtio_rpmsg_trysend_offchannel, + .get_mtu = virtio_rpmsg_get_mtu, }; /** @@ -699,6 +701,14 @@ static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, false); } +static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept) +{ + struct rpmsg_device *rpdev = ept->rpdev; + struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); + + return vch->vrp->buf_size - sizeof(struct rpmsg_hdr); +} + static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, struct rpmsg_hdr *msg, unsigned int len) { diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h index 9fe156d1c018..88d7892ca93d 100644 --- a/include/linux/rpmsg.h +++ b/include/linux/rpmsg.h @@ -135,6 +135,8 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, struct file *filp, poll_table *wait); +ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept); + #else static inline int register_rpmsg_device(struct rpmsg_device *dev) @@ -242,6 +244,14 @@ static inline __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, return 0; } +static inline ssize_t rpmsg_get_mtu(struct rpmsg_endpoint *ept) +{ + /* This shouldn't be possible */ + WARN_ON(1); + + return -ENXIO; +} + #endif /* IS_ENABLED(CONFIG_RPMSG) */ /* use a macro to avoid include chaining to get THIS_MODULE */
Return the rpmsg buffer size for sending message, so rpmsg users can split a long message in several sub rpmsg buffers. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> --- drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 2 ++ drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++ include/linux/rpmsg.h | 10 ++++++++++ 4 files changed, 43 insertions(+)