mbox series

[v2,0/9] tools-power-x86-intel-speed-select: Fixes and updates for output

Message ID 20190905120311.15286-1-prarit@redhat.com (mailing list archive)
Headers show
Series tools-power-x86-intel-speed-select: Fixes and updates for output | expand

Message

Prarit Bhargava Sept. 5, 2019, 12:03 p.m. UTC
Some general fixes and updates for intel-speed-select.  Fixes include some
typos as well as an off-by-one cpu count reporting error.  Updates for the
output are

- switching to MHz as a standard
- reporting CPU frequencies instead of ratios as a standard
- viewing a human-readable CPU list.
- avoiding reporting "0|1" as success|fail as these can be confusing for a
  user.

v2: Add additional patch to fix memory leak and remove help text in 8/9.

Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: David Arcari <darcari@redhat.com>
Cc: linux-kernel@vger.kernel.org

Prarit Bhargava (9):
  tools/power/x86/intel-speed-select: Fix package typo
  tools/power/x86/intel-speed-select: Fix help option typo
  tools/power/x86/intel-speed-select: Fix cpu-count output
  tools/power/x86/intel-speed-select: Simplify output for turbo-freq and
    base-freq
  tools/power/x86/intel-speed-select: Switch output to MHz
  tools/power/x86/intel-speed-select: Change turbo ratio output to
    maximum turbo frequency
  tools/power/x86/intel-speed-select: Output human readable CPU list
  tools/power/x86/intel-speed-select: Output success/failed for command
    output
  tools/power/x86/intel-speed-select: Fix memory leak

 .../x86/intel-speed-select/isst-config.c      |  21 +--
 .../x86/intel-speed-select/isst-display.c     | 120 +++++++++++++-----
 2 files changed, 98 insertions(+), 43 deletions(-)

Comments

srinivas pandruvada Sept. 5, 2019, 11:05 p.m. UTC | #1
On Thu, 2019-09-05 at 08:03 -0400, Prarit Bhargava wrote:
> Some general fixes and updates for intel-speed-select.  Fixes include
> some
> typos as well as an off-by-one cpu count reporting error.  Updates
> for the
> output are
> 
> - switching to MHz as a standard
> - reporting CPU frequencies instead of ratios as a standard
> - viewing a human-readable CPU list.
> - avoiding reporting "0|1" as success|fail as these can be confusing
> for a
>   user.
> 
> v2: Add additional patch to fix memory leak and remove help text in
> 8/9.

For the series

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> 
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: David Arcari <darcari@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> 
> Prarit Bhargava (9):
>   tools/power/x86/intel-speed-select: Fix package typo
>   tools/power/x86/intel-speed-select: Fix help option typo
>   tools/power/x86/intel-speed-select: Fix cpu-count output
>   tools/power/x86/intel-speed-select: Simplify output for turbo-freq
> and
>     base-freq
>   tools/power/x86/intel-speed-select: Switch output to MHz
>   tools/power/x86/intel-speed-select: Change turbo ratio output to
>     maximum turbo frequency
>   tools/power/x86/intel-speed-select: Output human readable CPU list
>   tools/power/x86/intel-speed-select: Output success/failed for
> command
>     output
>   tools/power/x86/intel-speed-select: Fix memory leak
> 
>  .../x86/intel-speed-select/isst-config.c      |  21 +--
>  .../x86/intel-speed-select/isst-display.c     | 120 +++++++++++++---
> --
>  2 files changed, 98 insertions(+), 43 deletions(-)
>
Andy Shevchenko Sept. 7, 2019, 6:13 p.m. UTC | #2
On Fri, Sep 6, 2019 at 10:58 AM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Thu, 2019-09-05 at 08:03 -0400, Prarit Bhargava wrote:
> > Some general fixes and updates for intel-speed-select.  Fixes include
> > some
> > typos as well as an off-by-one cpu count reporting error.  Updates
> > for the
> > output are
> >
> > - switching to MHz as a standard
> > - reporting CPU frequencies instead of ratios as a standard
> > - viewing a human-readable CPU list.
> > - avoiding reporting "0|1" as success|fail as these can be confusing
> > for a
> >   user.
> >
> > v2: Add additional patch to fix memory leak and remove help text in
> > 8/9.
>
> For the series
>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>

Pushed to my review and testing queue, thanks!


> >
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Cc: David Arcari <darcari@redhat.com>
> > Cc: linux-kernel@vger.kernel.org
> >
> > Prarit Bhargava (9):
> >   tools/power/x86/intel-speed-select: Fix package typo
> >   tools/power/x86/intel-speed-select: Fix help option typo
> >   tools/power/x86/intel-speed-select: Fix cpu-count output
> >   tools/power/x86/intel-speed-select: Simplify output for turbo-freq
> > and
> >     base-freq
> >   tools/power/x86/intel-speed-select: Switch output to MHz
> >   tools/power/x86/intel-speed-select: Change turbo ratio output to
> >     maximum turbo frequency
> >   tools/power/x86/intel-speed-select: Output human readable CPU list
> >   tools/power/x86/intel-speed-select: Output success/failed for
> > command
> >     output
> >   tools/power/x86/intel-speed-select: Fix memory leak
> >
> >  .../x86/intel-speed-select/isst-config.c      |  21 +--
> >  .../x86/intel-speed-select/isst-display.c     | 120 +++++++++++++---
> > --
> >  2 files changed, 98 insertions(+), 43 deletions(-)
> >
>


--
With Best Regards,
Andy Shevchenko