| Message ID | a2b56edcada7b9000a6e906387a02c0ee42681db.1567587220.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits | expand |
Hi, * H. Nikolaus Schaller <hns@goldelico.com> [190904 08:54]: > According to omap.txt bindings documentation, matching the ti-cpufreq driver needs > to specify explicitly if a board uses an omap3430 or omap36xx chip. > > This needs to add ti,omap3430 to most omap34xx boards and replace ti,omap3630 > by ti,omap36xx for some omap36xx boards (most others already have done it right). > > We also clean up some instances of missing ti,am3517 so that we can rely on > seeing either one of: > > ti,am3517 > ti,omap34xx > ti,omap36xx > > in addition to ti,omap3. Please set up things to use ti,omap3630 in addition to ti,omap36xx for compatible to avoid churning the same files later. > diff --git a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts > --- a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts > +++ b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts > @@ -9,5 +9,5 @@ > > / { > model = "LogicPD Zoom DM3730 SOM-LV Development Kit"; > - compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap3"; > + compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap36xx", "ti,omap3"; > }; So just make this: compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap36xx", "ti,omap3"; And so on. It's fine to use ti,omap3630 for 37xx too as they're the same. > diff --git a/arch/arm/boot/dts/omap3-ldp.dts b/arch/arm/boot/dts/omap3-ldp.dts > index 9a5fde2d9bce..9947574bd0f8 100644 > --- a/arch/arm/boot/dts/omap3-ldp.dts > +++ b/arch/arm/boot/dts/omap3-ldp.dts > @@ -10,7 +10,7 @@ > > / { > model = "TI OMAP3430 LDP (Zoom1 Labrador)"; > - compatible = "ti,omap3-ldp", "ti,omap3"; > + compatible = "ti,omap3-ldp", "ti,omap34xx, "ti,omap3"; This fails to compile, it's missing a '"' for ti,omap34xx. And here too, please update to use: compatible = "ti,omap3-ldp", "ti,omap3430", "ti,omap34xx", "ti,omap3"; And again it's fine to add "ti,omap3430" for 3530 variants. Regards, Tony
Hi, I am preparing the next PATCH version now. Incl. updating the commit messages to carry more documentation about the opp-supported-hw bit definitions. So please do not merge yet. > Am 05.09.2019 um 16:27 schrieb Tony Lindgren <tony@atomide.com>: > > Hi, > > * H. Nikolaus Schaller <hns@goldelico.com> [190904 08:54]: >> According to omap.txt bindings documentation, matching the ti-cpufreq driver needs >> to specify explicitly if a board uses an omap3430 or omap36xx chip. >> >> This needs to add ti,omap3430 to most omap34xx boards and replace ti,omap3630 >> by ti,omap36xx for some omap36xx boards (most others already have done it right). >> >> We also clean up some instances of missing ti,am3517 so that we can rely on >> seeing either one of: >> >> ti,am3517 >> ti,omap34xx >> ti,omap36xx >> >> in addition to ti,omap3. > > Please set up things to use ti,omap3630 in addition to ti,omap36xx > for compatible to avoid churning the same files later. > >> diff --git a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts >> --- a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts >> +++ b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts >> @@ -9,5 +9,5 @@ >> >> / { >> model = "LogicPD Zoom DM3730 SOM-LV Development Kit"; >> - compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap3"; >> + compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap36xx", "ti,omap3"; >> }; > > So just make this: > > compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap36xx", "ti,omap3"; Do we really need both? The clock driver already checks for both variants and the ti-cpufreq will as well. So it suffices to have either "ti,omap3630" or "ti,omap36xx". But yes, there may be user-space code that reads sysfs. So we should keep the "ti,omap3630" and add "ti,omap36xx". > > And so on. It's fine to use ti,omap3630 for 37xx too as they're the same. > >> diff --git a/arch/arm/boot/dts/omap3-ldp.dts b/arch/arm/boot/dts/omap3-ldp.dts >> index 9a5fde2d9bce..9947574bd0f8 100644 >> --- a/arch/arm/boot/dts/omap3-ldp.dts >> +++ b/arch/arm/boot/dts/omap3-ldp.dts >> @@ -10,7 +10,7 @@ >> >> / { >> model = "TI OMAP3430 LDP (Zoom1 Labrador)"; >> - compatible = "ti,omap3-ldp", "ti,omap3"; >> + compatible = "ti,omap3-ldp", "ti,omap34xx, "ti,omap3"; > > This fails to compile, it's missing a '"' for ti,omap34xx. And here too, > please update to use: Ah yes. I missed that (and my build script did not build all DTB). > > compatible = "ti,omap3-ldp", "ti,omap3430", "ti,omap34xx", "ti,omap3"; After thinking a little about the whole topic the main rule of this change must be: * do not break any existing in-tree DTS => only *add* to compatible what we need to distinguish between omap34 and omap36 * additions shall only follow new scheme => we only add "ti,omap34xx" or "ti,omap36xx" but neither "ti,omap3630" nor "ti,omap3430" * cover some out-of-tree DTS => make the ti-cpufreq driver still match "ti,omap3430" or "ti,omap3630" even if this duplicates compatibility This would mean that the logicpd-som-lv-37xx-devkit.dts gets the additional "ti,omap36xx" while the omap3-ldp.dts would only get an "ti,omap34xx" but no "ti,omap3430" (since we do not use it anywhere). Could you agree on this approach? > > And again it's fine to add "ti,omap3430" for 3530 variants. Yes, sure. BR, Nikolaus
* H. Nikolaus Schaller <hns@goldelico.com> [190906 07:53]: > > Am 05.09.2019 um 16:27 schrieb Tony Lindgren <tony@atomide.com>: > > compatible = "ti,omap3-ldp", "ti,omap3430", "ti,omap34xx", "ti,omap3"; > > After thinking a little about the whole topic the main rule of this change must be: > > * do not break any existing in-tree DTS > => only *add* to compatible what we need to distinguish between omap34 and omap36 > > * additions shall only follow new scheme > => we only add "ti,omap34xx" or "ti,omap36xx" > but neither "ti,omap3630" nor "ti,omap3430" Sorry I don't follow you on this one.. We should always add "ti,omap3630" where "ti,omap36xx" is currently used so we can eventually get rid of "ti,omap36xx". And the same for 34xx. > * cover some out-of-tree DTS > => make the ti-cpufreq driver still match "ti,omap3430" or "ti,omap3630" > even if this duplicates compatibility > > This would mean that the logicpd-som-lv-37xx-devkit.dts gets the additional "ti,omap36xx" > while the omap3-ldp.dts would only get an "ti,omap34xx" but no "ti,omap3430" (since we > do not use it anywhere). > > Could you agree on this approach? Yeah sounds like logicpd-som-lv-37xx-devkit.dts currently still needs "ti,omap36xx" for now. If modifying omap3-ldp.dts, also add "ti,omap3430" in additon to "ti,omap34xx" that it already has. So basically let's assume the following: "ti,omap3430" == "ti,omap34xx" "ti,omap3630" == "ti,omap36xx" This means code needs to parse both. And eventually we just drop the "xx" variants. So while patching compatibles, let's also update for this to avoid multiple patches churning the same compatibles over and over. Regards, Tony
Hi Tony, > Am 06.09.2019 um 17:47 schrieb Tony Lindgren <tony@atomide.com>: > > * H. Nikolaus Schaller <hns@goldelico.com> [190906 07:53]: >>> Am 05.09.2019 um 16:27 schrieb Tony Lindgren <tony@atomide.com>: >>> compatible = "ti,omap3-ldp", "ti,omap3430", "ti,omap34xx", "ti,omap3"; >> >> After thinking a little about the whole topic the main rule of this change must be: >> >> * do not break any existing in-tree DTS >> => only *add* to compatible what we need to distinguish between omap34 and omap36 >> >> * additions shall only follow new scheme >> => we only add "ti,omap34xx" or "ti,omap36xx" >> but neither "ti,omap3630" nor "ti,omap3430" > > Sorry I don't follow you on this one.. We should always add "ti,omap3630" > where "ti,omap36xx" is currently used so we can eventually get rid of > "ti,omap36xx". And the same for 34xx. Ah, ok now I see. You want to make the "ti,omap3630" the official one and "ti,omap36xx" legacy. It is probably an arbitrary choice if we want to get rid of the xx or the 30. I had thought to do it the other way round because I had done this statistics: for i in 3430 34xx 3630 36xx; do echo $i $(fgrep '"'ti,omap$i'"' arch/arm/boot/dts/*.dts* | wc -l); done 3430 12 34xx 28 3630 3 36xx 23 which would indicate that 34xx and 36xx are more common. >> * cover some out-of-tree DTS >> => make the ti-cpufreq driver still match "ti,omap3430" or "ti,omap3630" >> even if this duplicates compatibility >> >> This would mean that the logicpd-som-lv-37xx-devkit.dts gets the additional "ti,omap36xx" >> while the omap3-ldp.dts would only get an "ti,omap34xx" but no "ti,omap3430" (since we >> do not use it anywhere). >> >> Could you agree on this approach? > > Yeah sounds like logicpd-som-lv-37xx-devkit.dts currently still needs > "ti,omap36xx" for now. > > If modifying omap3-ldp.dts, also add "ti,omap3430" in additon to > "ti,omap34xx" that it already has. > > So basically let's assume the following: > > "ti,omap3430" == "ti,omap34xx" > "ti,omap3630" == "ti,omap36xx" > > This means code needs to parse both. Yes, it already does everywhere. BTW there is also some code that does special SoC detection based on soc_device_match(), mainly in omapdrm/dss. If we were to use this mechanism in the ti-cpufreq driver we could match it to ti,omap3 and could avoid all these changes. But make it less maintainable and code more complex. > > And eventually we just drop the "xx" variants. > > So while patching compatibles, let's also update for this to > avoid multiple patches churning the same compatibles over and > over. Ok. I'll rework the patch so that we never add "ti,34xx" or "ti,36xx" but add "ti,3430" or "ti,3630" if missing. I'll also take a look at omap.txt bindings since that likely needs an update as well to better describe what the official ones are and which are legacy. BR and thanks, Nikolaus
> Am 06.09.2019 um 19:08 schrieb H. Nikolaus Schaller <hns@goldelico.com>: > > Hi Tony, > >> Am 06.09.2019 um 17:47 schrieb Tony Lindgren <tony@atomide.com>: >> >> * H. Nikolaus Schaller <hns@goldelico.com> [190906 07:53]: >>>> Am 05.09.2019 um 16:27 schrieb Tony Lindgren <tony@atomide.com>: >>>> compatible = "ti,omap3-ldp", "ti,omap3430", "ti,omap34xx", "ti,omap3"; >>> >>> After thinking a little about the whole topic the main rule of this change must be: >>> >>> * do not break any existing in-tree DTS >>> => only *add* to compatible what we need to distinguish between omap34 and omap36 >>> >>> * additions shall only follow new scheme >>> => we only add "ti,omap34xx" or "ti,omap36xx" >>> but neither "ti,omap3630" nor "ti,omap3430" >> >> Sorry I don't follow you on this one.. We should always add "ti,omap3630" >> where "ti,omap36xx" is currently used so we can eventually get rid of >> "ti,omap36xx". And the same for 34xx. > > Ah, ok now I see. > > You want to make the "ti,omap3630" the official one and "ti,omap36xx" legacy. > It is probably an arbitrary choice if we want to get rid of the xx or the 30. > > I had thought to do it the other way round because I had done this statistics: > > for i in 3430 34xx 3630 36xx; do echo $i $(fgrep '"'ti,omap$i'"' arch/arm/boot/dts/*.dts* | wc -l); done > > 3430 12 > 34xx 28 > 3630 3 > 36xx 23 sorry, here is the correct result. I had some .bak files sitting around: 3430 12 34xx 5 3630 3 36xx 23 > which would indicate that 34xx and 36xx are more common. > >>> * cover some out-of-tree DTS >>> => make the ti-cpufreq driver still match "ti,omap3430" or "ti,omap3630" >>> even if this duplicates compatibility >>> >>> This would mean that the logicpd-som-lv-37xx-devkit.dts gets the additional "ti,omap36xx" >>> while the omap3-ldp.dts would only get an "ti,omap34xx" but no "ti,omap3430" (since we >>> do not use it anywhere). >>> >>> Could you agree on this approach? >> >> Yeah sounds like logicpd-som-lv-37xx-devkit.dts currently still needs >> "ti,omap36xx" for now. >> >> If modifying omap3-ldp.dts, also add "ti,omap3430" in additon to >> "ti,omap34xx" that it already has. >> >> So basically let's assume the following: >> >> "ti,omap3430" == "ti,omap34xx" >> "ti,omap3630" == "ti,omap36xx" >> >> This means code needs to parse both. > > Yes, it already does everywhere. > > BTW there is also some code that does special SoC detection based on > soc_device_match(), mainly in omapdrm/dss. > > If we were to use this mechanism in the ti-cpufreq driver we could > match it to ti,omap3 and could avoid all these changes. > > But make it less maintainable and code more complex. > >> >> And eventually we just drop the "xx" variants. > >> >> So while patching compatibles, let's also update for this to >> avoid multiple patches churning the same compatibles over and >> over. > > Ok. I'll rework the patch so that we never add "ti,34xx" or "ti,36xx" > but add "ti,3430" or "ti,3630" if missing. > > I'll also take a look at omap.txt bindings since that likely needs > an update as well to better describe what the official ones are > and which are legacy. > > BR and thanks, > Nikolaus >
* H. Nikolaus Schaller <hns@goldelico.com> [190906 17:09]: > for i in 3430 34xx 3630 36xx; do echo $i $(fgrep '"'ti,omap$i'"' arch/arm/boot/dts/*.dts* | wc -l); done > > 3430 12 > 34xx 28 > 3630 3 > 36xx 23 > > which would indicate that 34xx and 36xx are more common. Right, but the xx variants are against the device tree naming and that's why we should get rid of them in the dts. The compatible should be named after the first instance like "ti,omap3430" and similar devices can just use that. > BTW there is also some code that does special SoC detection based on > soc_device_match(), mainly in omapdrm/dss. > > If we were to use this mechanism in the ti-cpufreq driver we could > match it to ti,omap3 and could avoid all these changes. > > But make it less maintainable and code more complex. Hmm right, yeah using soc_device_match() would remove this issue. It might be worth doing as these SoC variants do not change much and the code should not need updating. Up to you to decide. > I'll also take a look at omap.txt bindings since that likely needs > an update as well to better describe what the official ones are > and which are legacy. OK. Just limit the compatible changes to the ones that need to be modified for this series, the rest can be done with a separate patches. Regards, Tony
> Am 06.09.2019 um 19:24 schrieb Tony Lindgren <tony@atomide.com>: > > * H. Nikolaus Schaller <hns@goldelico.com> [190906 17:09]: >> for i in 3430 34xx 3630 36xx; do echo $i $(fgrep '"'ti,omap$i'"' arch/arm/boot/dts/*.dts* | wc -l); done >> >> 3430 12 >> 34xx 28 >> 3630 3 >> 36xx 23 >> >> which would indicate that 34xx and 36xx are more common. > > Right, but the xx variants are against the device tree naming and > that's why we should get rid of them in the dts. The compatible > should be named after the first instance like "ti,omap3430" and > similar devices can just use that. > >> BTW there is also some code that does special SoC detection based on >> soc_device_match(), mainly in omapdrm/dss. >> >> If we were to use this mechanism in the ti-cpufreq driver we could >> match it to ti,omap3 and could avoid all these changes. >> >> But make it less maintainable and code more complex. > > Hmm right, yeah using soc_device_match() would remove this issue. > It might be worth doing as these SoC variants do not change > much and the code should not need updating. Up to you to > decide. > >> I'll also take a look at omap.txt bindings since that likely needs >> an update as well to better describe what the official ones are >> and which are legacy. > > OK. Just limit the compatible changes to the ones that > need to be modified for this series, the rest can be > done with a separate patches. Well, with this rule we modify almost all of them. In total ca. 35 files. But it looks right. The rest is just one missing ti,am3517. Here is the script I want to use for bulk conversion: # add ti,omap3430 if missing find arch/arm/boot/dts -name '*.dts*' -exec fgrep -q '"ti,omap34xx"' {} \; ! -exec fgrep -q '"ti,omap3430"' {} \; -exec sed -i '' 's/"ti,omap34xx"/"ti,omap3430", "ti,omap34xx"/' {} \; # add ti,omap3630 if missing find arch/arm/boot/dts -name '*.dts*' -exec fgrep -q '"ti,omap36xx"' {} \; ! -exec fgrep -q '"ti,omap3630"' {} \; -exec sed -i '' 's/"ti,omap36xx"/"ti,omap3630", "ti,omap36xx"/' {} \; # add ti,omap3430 default if missing find arch/arm/boot/dts -name 'omap*.dts*' -exec fgrep -q '"ti,omap3"' {} \; ! -exec fgrep -q '"ti,omap3630"' {} \; ! -exec fgrep -q '"ti,omap36xx"' {} \; ! -exec fgrep -q '"ti,am3517"' {} \; ! -exec fgrep -q '"ti,omap34xx"' {} \; ! -exec fgrep -q '"ti,omap3430"' {} \; -exec sed -i '' 's/"ti,omap3"/"ti,omap3430", "ti,omap3"/' {} \; + manually add ti,am3517 to arch/arm/boot/dts/am3517_mt_ventoux.dts BR, Nikolaus
> Am 06.09.2019 um 19:24 schrieb Tony Lindgren <tony@atomide.com>: > > * H. Nikolaus Schaller <hns@goldelico.com> [190906 17:09]: > >> BTW there is also some code that does special SoC detection based on >> soc_device_match(), mainly in omapdrm/dss. >> >> If we were to use this mechanism in the ti-cpufreq driver we could >> match it to ti,omap3 and could avoid all these changes. >> >> But make it less maintainable and code more complex. > > Hmm right, yeah using soc_device_match() would remove this issue. > It might be worth doing as these SoC variants do not change > much and the code should not need updating. Up to you to > decide. I have looked through the structure of the ti-cpufreq driver but it assumes that each set of register offsets and bit masks has its own compatible so that it can just switch descriptor tables. There is no provision to run soc_device_match() instead. So let's forget this idea... BR, Nikolaus
diff --git a/arch/arm/boot/dts/am3517_mt_ventoux.dts b/arch/arm/boot/dts/am3517_mt_ventoux.dts index e507e4ae0d88..e7d7124a34ba 100644 --- a/arch/arm/boot/dts/am3517_mt_ventoux.dts +++ b/arch/arm/boot/dts/am3517_mt_ventoux.dts @@ -8,7 +8,7 @@ / { model = "TeeJet Mt.Ventoux"; - compatible = "teejet,mt_ventoux", "ti,omap3"; + compatible = "teejet,mt_ventoux", "ti,am3517", "ti,omap3"; memory@80000000 { device_type = "memory"; diff --git a/arch/arm/boot/dts/logicpd-som-lv-35xx-devkit.dts b/arch/arm/boot/dts/logicpd-som-lv-35xx-devkit.dts index f7a841a28865..2a0a98fe67f0 100644 --- a/arch/arm/boot/dts/logicpd-som-lv-35xx-devkit.dts +++ b/arch/arm/boot/dts/logicpd-som-lv-35xx-devkit.dts @@ -9,5 +9,5 @@ / { model = "LogicPD Zoom OMAP35xx SOM-LV Development Kit"; - compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3"; + compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3430", "ti,omap3"; }; diff --git a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts index a604d92221a4..ea441acf000d 100644 --- a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts +++ b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts @@ -9,5 +9,5 @@ / { model = "LogicPD Zoom DM3730 SOM-LV Development Kit"; - compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap3"; + compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap36xx", "ti,omap3"; }; diff --git a/arch/arm/boot/dts/logicpd-torpedo-35xx-devkit.dts b/arch/arm/boot/dts/logicpd-torpedo-35xx-devkit.dts index 7675bc3fa868..57bae2aa910e 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-35xx-devkit.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-35xx-devkit.dts @@ -9,5 +9,5 @@ / { model = "LogicPD Zoom OMAP35xx Torpedo Development Kit"; - compatible = "logicpd,dm3730-torpedo-devkit", "ti,omap3"; + compatible = "logicpd,dm3730-torpedo-devkit", "ti,omap3430", "ti,omap3"; }; diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts index 18c27e85051f..1937a1c36ad3 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts @@ -9,7 +9,7 @@ / { model = "LogicPD Zoom DM3730 Torpedo + Wireless Development Kit"; - compatible = "logicpd,dm3730-torpedo-devkit", "ti,omap3630", "ti,omap3"; + compatible = "logicpd,dm3730-torpedo-devkit", "ti,omap36xx", "ti,omap3"; wl12xx_vmmc: wl12xx_vmmc { compatible = "regulator-fixed"; diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts index e3df3c166902..4ed3f93f5841 100644 --- a/arch/arm/boot/dts/omap3-beagle.dts +++ b/arch/arm/boot/dts/omap3-beagle.dts @@ -8,7 +8,7 @@ / { model = "TI OMAP3 BeagleBoard"; - compatible = "ti,omap3-beagle", "ti,omap3"; + compatible = "ti,omap3-beagle", "ti,omap3430", "ti,omap3"; cpus { cpu@0 { diff --git a/arch/arm/boot/dts/omap3-cm-t3530.dts b/arch/arm/boot/dts/omap3-cm-t3530.dts index 76e52c78cbb4..f13644a776aa 100644 --- a/arch/arm/boot/dts/omap3-cm-t3530.dts +++ b/arch/arm/boot/dts/omap3-cm-t3530.dts @@ -9,7 +9,7 @@ / { model = "CompuLab CM-T3530"; - compatible = "compulab,omap3-cm-t3530", "ti,omap34xx", "ti,omap3"; + compatible = "compulab,omap3-cm-t3530", "ti,omap3430", "ti,omap3"; /* Regulator to trigger the reset signal of the Wifi module */ mmc2_sdio_reset: regulator-mmc2-sdio-reset { diff --git a/arch/arm/boot/dts/omap3-devkit8000-lcd43.dts b/arch/arm/boot/dts/omap3-devkit8000-lcd43.dts index a80fc60bc773..afed85078ad8 100644 --- a/arch/arm/boot/dts/omap3-devkit8000-lcd43.dts +++ b/arch/arm/boot/dts/omap3-devkit8000-lcd43.dts @@ -11,7 +11,7 @@ #include "omap3-devkit8000-lcd-common.dtsi" / { model = "TimLL OMAP3 Devkit8000 with 4.3'' LCD panel"; - compatible = "timll,omap3-devkit8000", "ti,omap3"; + compatible = "timll,omap3-devkit8000", "ti,omap3430", "ti,omap3"; lcd0: display { panel-timing { diff --git a/arch/arm/boot/dts/omap3-devkit8000-lcd70.dts b/arch/arm/boot/dts/omap3-devkit8000-lcd70.dts index 0753776071f8..07c51a105c0d 100644 --- a/arch/arm/boot/dts/omap3-devkit8000-lcd70.dts +++ b/arch/arm/boot/dts/omap3-devkit8000-lcd70.dts @@ -11,7 +11,7 @@ #include "omap3-devkit8000-lcd-common.dtsi" / { model = "TimLL OMAP3 Devkit8000 with 7.0'' LCD panel"; - compatible = "timll,omap3-devkit8000", "ti,omap3"; + compatible = "timll,omap3-devkit8000", "ti,omap3430", "ti,omap3"; lcd0: display { panel-timing { diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts index faafc48d8f61..162d0726b008 100644 --- a/arch/arm/boot/dts/omap3-devkit8000.dts +++ b/arch/arm/boot/dts/omap3-devkit8000.dts @@ -7,7 +7,7 @@ #include "omap3-devkit8000-common.dtsi" / { model = "TimLL OMAP3 Devkit8000"; - compatible = "timll,omap3-devkit8000", "ti,omap3"; + compatible = "timll,omap3-devkit8000", "ti,omap3430", "ti,omap3"; aliases { display1 = &dvi0; diff --git a/arch/arm/boot/dts/omap3-evm-37xx.dts b/arch/arm/boot/dts/omap3-evm-37xx.dts index e0c0382388f0..311550ee4eae 100644 --- a/arch/arm/boot/dts/omap3-evm-37xx.dts +++ b/arch/arm/boot/dts/omap3-evm-37xx.dts @@ -10,7 +10,7 @@ / { model = "TI OMAP37XX EVM (TMDSEVM3730)"; - compatible = "ti,omap3-evm-37xx", "ti,omap3630", "ti,omap3"; + compatible = "ti,omap3-evm-37xx", "ti,omap36xx", "ti,omap3"; }; &omap3_pmx_core2 { diff --git a/arch/arm/boot/dts/omap3-ha-lcd.dts b/arch/arm/boot/dts/omap3-ha-lcd.dts index badb9b3c8897..74751798c00e 100644 --- a/arch/arm/boot/dts/omap3-ha-lcd.dts +++ b/arch/arm/boot/dts/omap3-ha-lcd.dts @@ -8,7 +8,7 @@ / { model = "TI OMAP3 HEAD acoustics LCD-baseboard with TAO3530 SOM"; - compatible = "headacoustics,omap3-ha-lcd", "technexion,omap3-tao3530", "ti,omap34xx", "ti,omap3"; + compatible = "headacoustics,omap3-ha-lcd", "technexion,omap3-tao3530", "ti,omap3430", "ti,omap3"; }; &omap3_pmx_core { diff --git a/arch/arm/boot/dts/omap3-ha.dts b/arch/arm/boot/dts/omap3-ha.dts index a5365252bfbe..f36cbc0a3586 100644 --- a/arch/arm/boot/dts/omap3-ha.dts +++ b/arch/arm/boot/dts/omap3-ha.dts @@ -8,7 +8,7 @@ / { model = "TI OMAP3 HEAD acoustics baseboard with TAO3530 SOM"; - compatible = "headacoustics,omap3-ha", "technexion,omap3-tao3530", "ti,omap34xx", "ti,omap3"; + compatible = "headacoustics,omap3-ha", "technexion,omap3-tao3530", "ti,omap3430", "ti,omap3"; }; &omap3_pmx_core { diff --git a/arch/arm/boot/dts/omap3-ldp.dts b/arch/arm/boot/dts/omap3-ldp.dts index 9a5fde2d9bce..9947574bd0f8 100644 --- a/arch/arm/boot/dts/omap3-ldp.dts +++ b/arch/arm/boot/dts/omap3-ldp.dts @@ -10,7 +10,7 @@ / { model = "TI OMAP3430 LDP (Zoom1 Labrador)"; - compatible = "ti,omap3-ldp", "ti,omap3"; + compatible = "ti,omap3-ldp", "ti,omap34xx, "ti,omap3"; memory@80000000 { device_type = "memory"; diff --git a/arch/arm/boot/dts/omap3-sbc-t3530.dts b/arch/arm/boot/dts/omap3-sbc-t3530.dts index ae96002abb3b..19582ef68e60 100644 --- a/arch/arm/boot/dts/omap3-sbc-t3530.dts +++ b/arch/arm/boot/dts/omap3-sbc-t3530.dts @@ -8,7 +8,7 @@ / { model = "CompuLab SBC-T3530 with CM-T3530"; - compatible = "compulab,omap3-sbc-t3530", "compulab,omap3-cm-t3530", "ti,omap34xx", "ti,omap3"; + compatible = "compulab,omap3-sbc-t3530", "compulab,omap3-cm-t3530", "ti,omap3430", "ti,omap3"; aliases { display0 = &dvi0; diff --git a/arch/arm/boot/dts/omap3-thunder.dts b/arch/arm/boot/dts/omap3-thunder.dts index 6276e7079b36..b12ff8ecae50 100644 --- a/arch/arm/boot/dts/omap3-thunder.dts +++ b/arch/arm/boot/dts/omap3-thunder.dts @@ -8,7 +8,7 @@ / { model = "TI OMAP3 Thunder baseboard with TAO3530 SOM"; - compatible = "technexion,omap3-thunder", "technexion,omap3-tao3530", "ti,omap34xx", "ti,omap3"; + compatible = "technexion,omap3-thunder", "technexion,omap3-tao3530", "ti,omap3430", "ti,omap3"; }; &omap3_pmx_core { diff --git a/arch/arm/boot/dts/omap3430-sdp.dts b/arch/arm/boot/dts/omap3430-sdp.dts index 0abd61108a53..7bfde8aac7ae 100644 --- a/arch/arm/boot/dts/omap3430-sdp.dts +++ b/arch/arm/boot/dts/omap3430-sdp.dts @@ -8,7 +8,7 @@ / { model = "TI OMAP3430 SDP"; - compatible = "ti,omap3430-sdp", "ti,omap3"; + compatible = "ti,omap3430-sdp", "ti,omap3430", "ti,omap3"; memory@80000000 { device_type = "memory";
According to omap.txt bindings documentation, matching the ti-cpufreq driver needs to specify explicitly if a board uses an omap3430 or omap36xx chip. This needs to add ti,omap3430 to most omap34xx boards and replace ti,omap3630 by ti,omap36xx for some omap36xx boards (most others already have done it right). We also clean up some instances of missing ti,am3517 so that we can rely on seeing either one of: ti,am3517 ti,omap34xx ti,omap36xx in addition to ti,omap3. Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/arm/boot/dts/am3517_mt_ventoux.dts | 2 +- arch/arm/boot/dts/logicpd-som-lv-35xx-devkit.dts | 2 +- arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts | 2 +- arch/arm/boot/dts/logicpd-torpedo-35xx-devkit.dts | 2 +- arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts | 2 +- arch/arm/boot/dts/omap3-beagle.dts | 2 +- arch/arm/boot/dts/omap3-cm-t3530.dts | 2 +- arch/arm/boot/dts/omap3-devkit8000-lcd43.dts | 2 +- arch/arm/boot/dts/omap3-devkit8000-lcd70.dts | 2 +- arch/arm/boot/dts/omap3-devkit8000.dts | 2 +- arch/arm/boot/dts/omap3-evm-37xx.dts | 2 +- arch/arm/boot/dts/omap3-ha-lcd.dts | 2 +- arch/arm/boot/dts/omap3-ha.dts | 2 +- arch/arm/boot/dts/omap3-ldp.dts | 2 +- arch/arm/boot/dts/omap3-sbc-t3530.dts | 2 +- arch/arm/boot/dts/omap3-thunder.dts | 2 +- arch/arm/boot/dts/omap3430-sdp.dts | 2 +- 17 files changed, 17 insertions(+), 17 deletions(-)