| Message ID | 20190717083327.47646-1-cychiang@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add HDMI jack support on RK3288 | expand |
On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang <cychiang@chromium.org> wrote: > > This patch series supports HDMI jack reporting on RK3288, which uses > DRM dw-hdmi driver and hdmi-codec codec driver. > > The previous discussion about reporting jack status using hdmi-notifier > and drm_audio_component is at > > https://lore.kernel.org/patchwork/patch/1083027/ > > The new approach is to use a callback mechanism that is > specific to hdmi-codec. > > Changes from v4 to v5: > - synopsys/Kconfig: Remove the incorrect dependency change in v4. > - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need > for jack support. > > Cheng-Yi Chiang (5): > ASoC: hdmi-codec: Add an op to set callback function for plug event > drm: bridge: dw-hdmi: Report connector status using callback > drm: dw-hdmi-i2s: Use fixed id for codec device > ASoC: rockchip_max98090: Add dai_link for HDMI > ASoC: rockchip_max98090: Add HDMI jack support > LGTM. Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang <cychiang@chromium.org> wrote: > > > > This patch series supports HDMI jack reporting on RK3288, which uses > > DRM dw-hdmi driver and hdmi-codec codec driver. > > > > The previous discussion about reporting jack status using hdmi-notifier > > and drm_audio_component is at > > > > https://lore.kernel.org/patchwork/patch/1083027/ > > > > The new approach is to use a callback mechanism that is > > specific to hdmi-codec. > > > > Changes from v4 to v5: > > - synopsys/Kconfig: Remove the incorrect dependency change in v4. > > - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need > > for jack support. > > > > Cheng-Yi Chiang (5): > > ASoC: hdmi-codec: Add an op to set callback function for plug event > > drm: bridge: dw-hdmi: Report connector status using callback > > drm: dw-hdmi-i2s: Use fixed id for codec device > > ASoC: rockchip_max98090: Add dai_link for HDMI > > ASoC: rockchip_max98090: Add HDMI jack support > > > LGTM. > > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> Hi Daniel, Do you have further concern on this patch series related to hdmi-codec and drm part ? We would like to merge this patch series if possible. They will be needed in many future chrome projects for HDMI audio jack detection. Thanks a lot!
On Fri, Aug 30, 2019 at 10:55 AM Cheng-yi Chiang <cychiang@chromium.org> wrote: > > On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > > > On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang <cychiang@chromium.org> wrote: > > > > > > This patch series supports HDMI jack reporting on RK3288, which uses > > > DRM dw-hdmi driver and hdmi-codec codec driver. > > > > > > The previous discussion about reporting jack status using hdmi-notifier > > > and drm_audio_component is at > > > > > > https://lore.kernel.org/patchwork/patch/1083027/ > > > > > > The new approach is to use a callback mechanism that is > > > specific to hdmi-codec. > > > > > > Changes from v4 to v5: > > > - synopsys/Kconfig: Remove the incorrect dependency change in v4. > > > - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need > > > for jack support. > > > > > > Cheng-Yi Chiang (5): > > > ASoC: hdmi-codec: Add an op to set callback function for plug event > > > drm: bridge: dw-hdmi: Report connector status using callback > > > drm: dw-hdmi-i2s: Use fixed id for codec device > > > ASoC: rockchip_max98090: Add dai_link for HDMI > > > ASoC: rockchip_max98090: Add HDMI jack support > > > > > LGTM. > > > > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> > > Hi Daniel, > Do you have further concern on this patch series related to hdmi-codec > and drm part ? > We would like to merge this patch series if possible. > They will be needed in many future chrome projects for HDMI audio jack > detection. > Thanks a lot! Hi Neil, I am not sure if this patch series is under your radar. Would you mind taking a look ? This patch series has been following great suggestions from various reviewers, so I hope it is fine now. Audio jack reporting for HDMI might not be needed for other OS, but it is a must on ChromeOS. We have many previous projects using different local patch sets to achieve HDMI jack reporting. I hope that we can achieve a proper way and really get the patches merged to mainline. Thanks a lot!
Hi, On 08/09/2019 15:51, Cheng-yi Chiang wrote: > On Fri, Aug 30, 2019 at 10:55 AM Cheng-yi Chiang <cychiang@chromium.org> wrote: >> >> On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih <tzungbi@google.com> wrote: >>> >>> On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang <cychiang@chromium.org> wrote: >>>> >>>> This patch series supports HDMI jack reporting on RK3288, which uses >>>> DRM dw-hdmi driver and hdmi-codec codec driver. >>>> >>>> The previous discussion about reporting jack status using hdmi-notifier >>>> and drm_audio_component is at >>>> >>>> https://lore.kernel.org/patchwork/patch/1083027/ >>>> >>>> The new approach is to use a callback mechanism that is >>>> specific to hdmi-codec. >>>> >>>> Changes from v4 to v5: >>>> - synopsys/Kconfig: Remove the incorrect dependency change in v4. >>>> - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need >>>> for jack support. >>>> >>>> Cheng-Yi Chiang (5): >>>> ASoC: hdmi-codec: Add an op to set callback function for plug event >>>> drm: bridge: dw-hdmi: Report connector status using callback >>>> drm: dw-hdmi-i2s: Use fixed id for codec device >>>> ASoC: rockchip_max98090: Add dai_link for HDMI >>>> ASoC: rockchip_max98090: Add HDMI jack support >>>> >>> LGTM. >>> >>> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> >> >> Hi Daniel, >> Do you have further concern on this patch series related to hdmi-codec >> and drm part ? >> We would like to merge this patch series if possible. >> They will be needed in many future chrome projects for HDMI audio jack >> detection. >> Thanks a lot! > > Hi Neil, > I am not sure if this patch series is under your radar. > Would you mind taking a look ? > This patch series has been following great suggestions from various > reviewers, so I hope it is fine now. I'd like some review from ASoC people and other drm bridge reviewers, Jernej, Jonas & Andrzej. Jonas could have some comments on the overall patchset. > > Audio jack reporting for HDMI might not be needed for other OS, but it > is a must on ChromeOS. > We have many previous projects using different local patch sets to > achieve HDMI jack reporting. > I hope that we can achieve a proper way and really get the patches > merged to mainline. > Thanks a lot! > Sure, Don't forget to put Jernej, Jonas, and Jerome Brunet <jbrunet@baylibre.com> who is working on integrating audio on the Amlogic SoCs. Neil
On Mon, Sep 09, 2019 at 09:37:14AM +0200, Neil Armstrong wrote: > I'd like some review from ASoC people and other drm bridge reviewers, > Jernej, Jonas & Andrzej. > Jonas could have some comments on the overall patchset. The ASoC bits look basically fine, I've gone ahead and applied patch 1 as is since we're just before the merge window and that way we reduce potential cross tree issues. I know there's a lot of discussion on the DRM side about how they want to handle things with jacks, I'm not 100% sure what the latest thinking is there.
Hi, On 09/09/2019 15:53, Mark Brown wrote: > On Mon, Sep 09, 2019 at 09:37:14AM +0200, Neil Armstrong wrote: > >> I'd like some review from ASoC people and other drm bridge reviewers, >> Jernej, Jonas & Andrzej. > >> Jonas could have some comments on the overall patchset. > > The ASoC bits look basically fine, I've gone ahead and applied > patch 1 as is since we're just before the merge window and that > way we reduce potential cross tree issues. I know there's a lot > of discussion on the DRM side about how they want to handle > things with jacks, I'm not 100% sure what the latest thinking is > there. > Thanks Mark. Cheng-Yi can you resent this serie without the already applied first patch with Jernej, Jonas, and Jerome Brunet <jbrunet@baylibre.com> CCed ? Thanks, Neil
On Fri, Sep 13, 2019 at 5:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Hi, > > On 09/09/2019 15:53, Mark Brown wrote: > > On Mon, Sep 09, 2019 at 09:37:14AM +0200, Neil Armstrong wrote: > > > >> I'd like some review from ASoC people and other drm bridge reviewers, > >> Jernej, Jonas & Andrzej. > > > >> Jonas could have some comments on the overall patchset. > > > > The ASoC bits look basically fine, I've gone ahead and applied > > patch 1 as is since we're just before the merge window and that > > way we reduce potential cross tree issues. I know there's a lot > > of discussion on the DRM side about how they want to handle > > things with jacks, I'm not 100% sure what the latest thinking is > > there. > > > > Thanks Mark. > > > Cheng-Yi can you resent this serie without the already applied > first patch with Jernej, Jonas, and Jerome Brunet <jbrunet@baylibre.com> CCed ? Hi Neil, Got it. Sorry for the late reply. I will resend this series without the first patch, based on latest drm-misc-next, and cc the folks. Thanks! > > Thanks, > Neil >