diff mbox series

ssb: make array pwr_info_offset static const, makes object smaller

Message ID 20190906154053.32218-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit d3bb26868105397bb23eccabe2eaae6662606629
Delegated to: Kalle Valo
Headers show
Series ssb: make array pwr_info_offset static const, makes object smaller | expand

Commit Message

Colin King Sept. 6, 2019, 3:40 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Don't populate the array pwr_info_offset on the stack but instead make it
static const. Makes the object code smaller by 207 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  26066	   3000	     64	  29130	   71ca	drivers/ssb/pci.o

After:
   text	   data	    bss	    dec	    hex	filename
  25763	   3096	     64	  28923	   70fb	drivers/ssb/pci.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/ssb/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Büsch Sept. 9, 2019, 5:53 p.m. UTC | #1 
On Fri,  6 Sep 2019 16:40:53 +0100
Colin King <colin.king@canonical.com> wrote:

> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index da2d2ab8104d..7c3ae52f2b15 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
>  {
>  	int i;
>  	u16 o;
> -	u16 pwr_info_offset[] = {
> +	static const u16 pwr_info_offset[] = {
>  		SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
>  		SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
>  	};

Thanks for your contribution. This change makes sense.

Kalle, can you please take it?

Acked-by: Michael Büsch <m@bues.ch>
Kalle Valo Sept. 13, 2019, 2:23 p.m. UTC | #2 
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the array pwr_info_offset on the stack but instead make it
> static const. Makes the object code smaller by 207 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   26066	   3000	     64	  29130	   71ca	drivers/ssb/pci.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   25763	   3096	     64	  28923	   70fb	drivers/ssb/pci.o
> 
> (gcc version 9.2.1, amd64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Michael Büsch <m@bues.ch>

Patch applied to wireless-drivers-next.git, thanks.

d3bb26868105 ssb: make array pwr_info_offset static const, makes object smaller
diff mbox series

Patch

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index da2d2ab8104d..7c3ae52f2b15 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -595,7 +595,7 @@  static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
 {
 	int i;
 	u16 o;
-	u16 pwr_info_offset[] = {
+	static const u16 pwr_info_offset[] = {
 		SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
 		SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
 	};