| Message ID | 20190906152438.1533833-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b99a3120f9a30e1429d8d634e18da8dff93340c6 |
| Headers | show |
| Series | rtc: meson: mark PM functions as __maybe_unused | expand |
Arnd Bergmann <arnd@arndb.de> writes: > The meson_vrtc_set_wakeup_time() function is only used by > the PM functions and causes a warning when they are disabled: > > drivers/rtc/rtc-meson-vrtc.c:32:13: error: unused function 'meson_vrtc_set_wakeup_time' [-Werror,-Wunused-function] > > Remove the #ifdef around the callers and add a __maybe_unused > annotation as a more reliable way to avoid these warnings. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
On 06/09/2019 17:24:29+0200, Arnd Bergmann wrote: > The meson_vrtc_set_wakeup_time() function is only used by > the PM functions and causes a warning when they are disabled: > > drivers/rtc/rtc-meson-vrtc.c:32:13: error: unused function 'meson_vrtc_set_wakeup_time' [-Werror,-Wunused-function] > > Remove the #ifdef around the callers and add a __maybe_unused > annotation as a more reliable way to avoid these warnings. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/rtc/rtc-meson-vrtc.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 4621a4715179..89e5ba0dae69 100644 --- a/drivers/rtc/rtc-meson-vrtc.c +++ b/drivers/rtc/rtc-meson-vrtc.c @@ -91,8 +91,7 @@ static int meson_vrtc_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP -static int meson_vrtc_suspend(struct device *dev) +static int __maybe_unused meson_vrtc_suspend(struct device *dev) { struct meson_vrtc_data *vrtc = dev_get_drvdata(dev); @@ -121,7 +120,7 @@ static int meson_vrtc_suspend(struct device *dev) return 0; } -static int meson_vrtc_resume(struct device *dev) +static int __maybe_unused meson_vrtc_resume(struct device *dev) { struct meson_vrtc_data *vrtc = dev_get_drvdata(dev); @@ -131,7 +130,7 @@ static int meson_vrtc_resume(struct device *dev) meson_vrtc_set_wakeup_time(vrtc, 0); return 0; } -#endif + static SIMPLE_DEV_PM_OPS(meson_vrtc_pm_ops, meson_vrtc_suspend, meson_vrtc_resume);
The meson_vrtc_set_wakeup_time() function is only used by the PM functions and causes a warning when they are disabled: drivers/rtc/rtc-meson-vrtc.c:32:13: error: unused function 'meson_vrtc_set_wakeup_time' [-Werror,-Wunused-function] Remove the #ifdef around the callers and add a __maybe_unused annotation as a more reliable way to avoid these warnings. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/rtc/rtc-meson-vrtc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)