| Message ID | 20190913054435.3662-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: fix arm build with debugtrace configured | expand |
On 13.09.2019 07:44, Juergen Gross wrote: > Add missing #includes. > > Signed-off-by: Juergen Gross <jgross@suse.com> Acked-by: Jan Beulich <jbeulich@suse.com> Albeit for the future it would be nice if the connection to the actual breakage was established in the description, by mentioning the offending commit and/or by naming the specific build problem. Jan
Hi Jan, On 13/09/2019 07:13, Jan Beulich wrote: > On 13.09.2019 07:44, Juergen Gross wrote: >> Add missing #includes. >> >> Signed-off-by: Juergen Gross <jgross@suse.com> > > Acked-by: Jan Beulich <jbeulich@suse.com> > > Albeit for the future it would be nice if the connection to the > actual breakage was established in the description, by mentioning > the offending commit and/or by naming the specific build problem. It would have been nice you the commit message was at least updated before committing. With the current one it is unclear why it is necessary so it feels quite random. Cheers,
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c index 5d22d431ad..7313e89389 100644 --- a/xen/common/debugtrace.c +++ b/xen/common/debugtrace.c @@ -11,7 +11,9 @@ #include <xen/keyhandler.h> #include <xen/lib.h> #include <xen/mm.h> +#include <xen/percpu.h> #include <xen/serial.h> +#include <xen/smp.h> #include <xen/spinlock.h> #include <xen/watchdog.h>
Add missing #includes. Signed-off-by: Juergen Gross <jgross@suse.com> --- xen/common/debugtrace.c | 2 ++ 1 file changed, 2 insertions(+)