| Message ID | 20190914091835.11236-1-birger.sp@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5] git-gui: add hotkey to toggle "Amend Last Commit" | expand |
You missed labelling the menu item of "Amend Last Commit" with the shortcut, like we do for other menu items bound to a hotkey like F5 for rescan, Ctrl-T for stage, etc. I added that locally. Thanks for the re-roll. Will queue. On 14/09/19 11:18AM, Birger Skogeng Pedersen wrote: > Selecting whether to "Amend Last Commit" or not does not have a hotkey. > > With this patch, the user may toggle between the two options with > CTRL/CMD+e. > > Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com> > Rebased-by: Bert Wesarg <bert.wesarg@googlemail.com> > --- > git-gui.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/git-gui.sh b/git-gui.sh > index c7d9103..790adf1 100755 > --- a/git-gui.sh > +++ b/git-gui.sh > @@ -2664,6 +2664,12 @@ proc focus_widget {widget} { > } > } > > +proc toggle_commit_type {} { > + global commit_type_is_amend > + set commit_type_is_amend [expr !$commit_type_is_amend] > + do_select_commit_type > +} > + > ###################################################################### > ## > ## ui construction > @@ -3892,6 +3898,8 @@ bind . <$M1B-Key-j> do_revert_selection > bind . <$M1B-Key-J> do_revert_selection > bind . <$M1B-Key-i> do_add_all > bind . <$M1B-Key-I> do_add_all > +bind . <$M1B-Key-e> toggle_commit_type > +bind . <$M1B-Key-E> toggle_commit_type > bind . <$M1B-Key-minus> {show_less_context;break} > bind . <$M1B-Key-KP_Subtract> {show_less_context;break} > bind . <$M1B-Key-equal> {show_more_context;break} > -- > 2.21.0.windows.1 >
Hi, On Sat, Sep 14, 2019 at 7:48 PM Pratyush Yadav <me@yadavpratyush.com> wrote: > You missed labelling the menu item of "Amend Last Commit" with the > shortcut, like we do for other menu items bound to a hotkey like F5 for > rescan, Ctrl-T for stage, etc. I added that locally. Sorry about that. Thanks! Birger
diff --git a/git-gui.sh b/git-gui.sh index c7d9103..790adf1 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -2664,6 +2664,12 @@ proc focus_widget {widget} { } } +proc toggle_commit_type {} { + global commit_type_is_amend + set commit_type_is_amend [expr !$commit_type_is_amend] + do_select_commit_type +} + ###################################################################### ## ## ui construction @@ -3892,6 +3898,8 @@ bind . <$M1B-Key-j> do_revert_selection bind . <$M1B-Key-J> do_revert_selection bind . <$M1B-Key-i> do_add_all bind . <$M1B-Key-I> do_add_all +bind . <$M1B-Key-e> toggle_commit_type +bind . <$M1B-Key-E> toggle_commit_type bind . <$M1B-Key-minus> {show_less_context;break} bind . <$M1B-Key-KP_Subtract> {show_less_context;break} bind . <$M1B-Key-equal> {show_more_context;break}
Selecting whether to "Amend Last Commit" or not does not have a hotkey. With this patch, the user may toggle between the two options with CTRL/CMD+e. Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com> Rebased-by: Bert Wesarg <bert.wesarg@googlemail.com> --- git-gui.sh | 8 ++++++++ 1 file changed, 8 insertions(+)