| Message ID | 20190917172120.GA11581@SD (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] i2c: qup: remove explicit conversion to boolean | expand |
On 17/09/2019 19:21, Saiyam Doshi wrote: > The debug message after platform_get_irq() failure is redundant > because platform_get_irq() already prints an error. Thus remove it. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com> > --- > Changes in v2: > Updated changelog and removed unnecessary braces after if condition. > > drivers/i2c/busses/i2c-qup.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index 5519c19bfd9c..ed09a59066b2 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -1766,10 +1766,8 @@ static int qup_i2c_probe(struct platform_device *pdev) > return PTR_ERR(qup->base); > > qup->irq = platform_get_irq(pdev, 0); > - if (qup->irq < 0) { > - dev_err(qup->dev, "No IRQ defined\n"); > + if (qup->irq < 0) > return qup->irq; > - } As far as I understand, platform_get_irq() == 0 is also an error condition. I think the typical way to handle this peculiarity is: (Maybe the IRQ maintainers will correct me) qup->irq = platform_get_irq(pdev, 0); if (qup->irq <= 0) return qup->irq ? : -ENXIO; Regards.
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 5519c19bfd9c..ed09a59066b2 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -1766,10 +1766,8 @@ static int qup_i2c_probe(struct platform_device *pdev) return PTR_ERR(qup->base); qup->irq = platform_get_irq(pdev, 0); - if (qup->irq < 0) { - dev_err(qup->dev, "No IRQ defined\n"); + if (qup->irq < 0) return qup->irq; - } if (has_acpi_companion(qup->dev)) { ret = device_property_read_u32(qup->dev,
The debug message after platform_get_irq() failure is redundant because platform_get_irq() already prints an error. Thus remove it. Generated by: scripts/coccinelle/api/platform_get_irq.cocci Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com> --- Changes in v2: Updated changelog and removed unnecessary braces after if condition. drivers/i2c/busses/i2c-qup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.20.1