diff mbox series

[for-4.13] configure: fix print syntax for python 3

Message ID 20190919111722.iajioonuzqfharaf@debian (mailing list archive)
State New, archived
Headers show
Series [for-4.13] configure: fix print syntax for python 3 | expand

Commit Message

Wei Liu Sept. 19, 2019, 11:17 a.m. UTC 
16cc3362a missed one print statement.

Signed-off-by: Wei Liu <wl@xen.org>
---
 m4/python_devel.m4 | 2 +-
 tools/configure    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

     LDFLAGS="$LDFLAGS `$PYTHON -c 'import distutils.sysconfig; \

Comments

Wei Liu Sept. 19, 2019, 11:19 a.m. UTC | #1 
On Thu, 19 Sep 2019 at 12:17, Wei Liu <wl@xen.org> wrote:
>
> 16cc3362a missed one print statement.
>
> Signed-off-by: Wei Liu <wl@xen.org>
> ---
>  m4/python_devel.m4 | 2 +-
>  tools/configure    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
> index 7f26381376..e365cd658e 100644
> --- a/m4/python_devel.m4
> +++ b/m4/python_devel.m4
> @@ -6,7 +6,7 @@ AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
>  AS_IF([test x"$pyconfig" = x"no"], [
>      dnl For those that don't have python-config
>      CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
> -        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
> +        print("-I" +
> distutils.sysconfig.get_config_var("INCLUDEPY"))'`"

Urgh. This has been mangled. Hope you get the idea...

Wei.
Ian Jackson Sept. 19, 2019, 11:28 a.m. UTC | #2 
Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python 3"):
> On Thu, 19 Sep 2019 at 12:17, Wei Liu <wl@xen.org> wrote:
> >
> > 16cc3362a missed one print statement.
> >
> > Signed-off-by: Wei Liu <wl@xen.org>
> > ---
> >  m4/python_devel.m4 | 2 +-
> >  tools/configure    | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
> > index 7f26381376..e365cd658e 100644
> > --- a/m4/python_devel.m4
> > +++ b/m4/python_devel.m4
> > @@ -6,7 +6,7 @@ AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
> >  AS_IF([test x"$pyconfig" = x"no"], [
> >      dnl For those that don't have python-config
> >      CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
> > -        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
> > +        print("-I" +
> > distutils.sysconfig.get_config_var("INCLUDEPY"))'`"
> 
> Urgh. This has been mangled. Hope you get the idea...

My previous reply bounced due to header mangling in your first mail.
Let me try again:

This is good in principle but:

Can you provide as a git branch ?  Then I will get the unmangled
version and be able to try it out.

Ian.
Wei Liu Sept. 19, 2019, 11:35 a.m. UTC | #3 
On Thu, 19 Sep 2019 at 12:28, Ian Jackson <ian.jackson@citrix.com> wrote:

> My previous reply bounced due to header mangling in your first mail.
> Let me try again:
>
> This is good in principle but:
>
> Can you provide as a git branch ?  Then I will get the unmangled
> version and be able to try it out.
>

See https://xenbits.xen.org/gitweb/?p=people/liuw/xen.git;a=commitdiff;h=864c7fb715039906762c9638f04ddfd97c1ae54b

> Ian.
Ian Jackson Sept. 19, 2019, 1:01 p.m. UTC | #4 
Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python 3"):
> On Thu, 19 Sep 2019 at 12:28, Ian Jackson <ian.jackson@citrix.com> wrote:
> > My previous reply bounced due to header mangling in your first mail.
> > Let me try again:
> >
> > This is good in principle but:
> >
> > Can you provide as a git branch ?  Then I will get the unmangled
> > version and be able to try it out.
> 
> See https://xenbits.xen.org/gitweb/?p=people/liuw/xen.git;a=commitdiff;h=864c7fb715039906762c9638f04ddfd97c1ae54b

Thanks,

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

and pushed.

Ian.
diff mbox series

Patch

diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
index 7f26381376..e365cd658e 100644
--- a/m4/python_devel.m4
+++ b/m4/python_devel.m4
@@ -6,7 +6,7 @@  AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
 AS_IF([test x"$pyconfig" = x"no"], [
     dnl For those that don't have python-config
     CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
-        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
+        print("-I" +
distutils.sysconfig.get_config_var("INCLUDEPY"))'`"
     CPPFLAGS="$CPPFLAGS `$PYTHON -c 'import distutils.sysconfig; \
         print(distutils.sysconfig.get_config_var("CFLAGS"))'`"
     LDFLAGS="$LDFLAGS `$PYTHON -c 'import distutils.sysconfig; \
diff --git a/tools/configure b/tools/configure
index 1baacea9ac..614d1f5b61 100755
--- a/tools/configure
+++ b/tools/configure
@@ -7441,7 +7441,7 @@  fi
 if test x"$pyconfig" = x"no"; then :
 
         CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
-        print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
+        print("-I" +
distutils.sysconfig.get_config_var("INCLUDEPY"))'`"
     CPPFLAGS="$CPPFLAGS `$PYTHON -c 'import distutils.sysconfig; \
         print(distutils.sysconfig.get_config_var("CFLAGS"))'`"