| Message ID | 20190912210509.19816-1-mhei@heimpold.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Various fixes for mmc-utils | expand |
Ulf/Adrian, As Chris is less responsive in the past few years, We might want to follow the scsi ML practice with regard to the ufs driver: Add several reviewers while Martin is pulling the patches. It is working quite well since then. Is this something that you might consider? Thanks, Avri > > > This series bundles several small fixes and enhancements I stumbled over > during short testing around one year ago. > > The initial sent v1 got a review by Avri, but was not applied (yet). > > I'm resending this v2 with the hope, that there is now some more interest. > > I added his Reviewed-by, no other technical changes. > > It can also be found in my Github tree: > https://github.com/mhei/mmc-utils/tree/fixes-enh > > Michael Heimpold (5): > Check calloc's return value before using the pointer > Cleanup memory in error case > Fix parsing of character in to_binstr() > Optimize to_binstr() function > Add eMMC vendor Micron to table > > lsmmc.c | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) > > -- > 2.17.1
On Thu, 19 Sep 2019 at 11:41, Avri Altman <Avri.Altman@wdc.com> wrote: > > Ulf/Adrian, > > As Chris is less responsive in the past few years, > We might want to follow the scsi ML practice with regard to the ufs driver: > Add several reviewers while Martin is pulling the patches. This has been discussed earlier [1] and Chris also agreed that it seems like a good idea. > > It is working quite well since then. > > Is this something that you might consider? As said, it's been discussed. I think it boils down to that someone must volunteer to help Chris. Then it's just a matter of formalizing this, set up git push permissions and document the new ways of maintenance. Perhaps you would be interested to help out? [...] Kind regards Uffe [1] https://patchwork.kernel.org/patch/10709543/
> On Thu, 19 Sep 2019 at 11:41, Avri Altman <Avri.Altman@wdc.com> wrote: > > > > Ulf/Adrian, > > > > As Chris is less responsive in the past few years, We might want to > > follow the scsi ML practice with regard to the ufs driver: > > Add several reviewers while Martin is pulling the patches. > > This has been discussed earlier [1] and Chris also agreed that it seems like a > good idea. Then I would like to suggest myself as a reviewer [R]. I hope that some more people would be interested to support this. Would you be able to pick mmc-utils patches? Thanks, Avri > > > > > It is working quite well since then. > > > > Is this something that you might consider? > > As said, it's been discussed. I think it boils down to that someone must > volunteer to help Chris. Then it's just a matter of formalizing this, set up git > push permissions and document the new ways of maintenance. > > Perhaps you would be interested to help out? > > [...] > > Kind regards > Uffe > > [1] > https://patchwork.kernel.org/patch/10709543/
On Thu, 19 Sep 2019 at 16:06, Avri Altman <Avri.Altman@wdc.com> wrote: > > > On Thu, 19 Sep 2019 at 11:41, Avri Altman <Avri.Altman@wdc.com> wrote: > > > > > > Ulf/Adrian, > > > > > > As Chris is less responsive in the past few years, We might want to > > > follow the scsi ML practice with regard to the ufs driver: > > > Add several reviewers while Martin is pulling the patches. > > > > This has been discussed earlier [1] and Chris also agreed that it seems like a > > good idea. > Then I would like to suggest myself as a reviewer [R]. > I hope that some more people would be interested to support this. > Would you be able to pick mmc-utils patches? Really great that you are willing to help! No, I can't pick patches, as don't have the permission to push them to the git tree. Only Chris can do that at this point. We could create a group to share publish permissions to the git, but it depending on what Chris feels about that. Chris? Kind regards Uffe > > Thanks, > Avri > > > > > > > > > It is working quite well since then. > > > > > > Is this something that you might consider? > > > > As said, it's been discussed. I think it boils down to that someone must > > volunteer to help Chris. Then it's just a matter of formalizing this, set up git > > push permissions and document the new ways of maintenance. > > > > Perhaps you would be interested to help out? > > > > [...] > > > > Kind regards > > Uffe > > > > [1] > > https://patchwork.kernel.org/patch/10709543/
Hi Michael, On Thu, Sep 12, 2019 at 11:05:04PM +0200, Michael Heimpold wrote: > This series bundles several small fixes and enhancements > I stumbled over during short testing around one year ago. > > The initial sent v1 got a review by Avri, but was not applied (yet). > > I'm resending this v2 with the hope, that there is now some > more interest. > > I added his Reviewed-by, no other technical changes. > > It can also be found in my Github tree: > https://github.com/mhei/mmc-utils/tree/fixes-enh > > Michael Heimpold (5): > Check calloc's return value before using the pointer > Cleanup memory in error case > Fix parsing of character in to_binstr() > Optimize to_binstr() function > Add eMMC vendor Micron to table Thanks, pushed to mmc-next master, apologies for the delay. - Chris.
Hi folks, On Thu, Oct 03, 2019 at 12:22:28PM +0200, Ulf Hansson wrote: > > Then I would like to suggest myself as a reviewer [R]. > > I hope that some more people would be interested to support this. > > Would you be able to pick mmc-utils patches? > > Really great that you are willing to help! > > No, I can't pick patches, as don't have the permission to push them to > the git tree. Only Chris can do that at this point. > > We could create a group to share publish permissions to the git, but > it depending on what Chris feels about that. Yes, if it's possible to share permissions on the current repo to include Ulf and Avri too, that works fine for me.