| Message ID | 20190920053817.13754-1-christophe.roullier@st.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: ethernet: stmmac: some fixes and optimization | expand |
On Fri, 20 Sep 2019 07:38:12 +0200, Christophe Roullier wrote: > Some improvements (manage syscfg as optional clock, update slew rate of > ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) > Fix warning build message when W=1 There seems to be some new features/cleanups (or improvements as you say) here. Could you explain the negative impact not applying these changes will have? Patches 1 and 3 in particular. net-next is now closed [1], and will reopen some time after the merge window is over. For now we are only expecting fixes for the net tree. Could you (a) provide stronger motivation these changes are fixes; or (b) separate the fixes from improvements? Thank you! [1] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
Hi Jakub, all, It is not urgent, no problem to wait next merge window (release 5.5) For patch 1 and 3, it is improvement/cleanup because now syscfg clock is not mandatory (I put code backward compatible). Regards, Christophe On 9/23/19 12:12 AM, Jakub Kicinski wrote: > On Fri, 20 Sep 2019 07:38:12 +0200, Christophe Roullier wrote: >> Some improvements (manage syscfg as optional clock, update slew rate of >> ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) >> Fix warning build message when W=1 > There seems to be some new features/cleanups (or improvements as > you say) here. Could you explain the negative impact not applying > these changes will have? Patches 1 and 3 in particular. > > net-next is now closed [1], and will reopen some time after the merge > window is over. For now we are only expecting fixes for the net tree. > > Could you (a) provide stronger motivation these changes are fixes; or > (b) separate the fixes from improvements? > > Thank you! > > [1] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
Hi Christophe On 9/20/19 7:38 AM, Christophe Roullier wrote: > Some improvements (manage syscfg as optional clock, update slew rate of > ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) > Fix warning build message when W=1 > > Christophe Roullier (5): > net: ethernet: stmmac: Add support for syscfg clock > net: ethernet: stmmac: fix warning when w=1 option is used during > build > ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet > ARM: dts: stm32: adjust slew rate for Ethernet > ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power > mode on stm32mp157c > DT patches will be applied on stm32-next after dwmac-stm32 patches merge in net-next. > arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 9 +++- > arch/arm/boot/dts/stm32mp157c.dtsi | 7 ++-- > .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 42 ++++++++++++------- > 3 files changed, 38 insertions(+), 20 deletions(-) >
Hi all, Just a "gentleman ping" about this series Regards, Christophe. On 9/23/19 9:46 AM, Christophe ROULLIER wrote: > Hi Jakub, all, > > It is not urgent, no problem to wait next merge window (release 5.5) > > For patch 1 and 3, it is improvement/cleanup because now syscfg clock > is not mandatory (I put code backward compatible). > > Regards, > > Christophe > > On 9/23/19 12:12 AM, Jakub Kicinski wrote: >> On Fri, 20 Sep 2019 07:38:12 +0200, Christophe Roullier wrote: >>> Some improvements (manage syscfg as optional clock, update slew rate of >>> ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power >>> mode) >>> Fix warning build message when W=1 >> There seems to be some new features/cleanups (or improvements as >> you say) here. Could you explain the negative impact not applying >> these changes will have? Patches 1 and 3 in particular. >> >> net-next is now closed [1], and will reopen some time after the merge >> window is over. For now we are only expecting fixes for the net tree. >> >> Could you (a) provide stronger motivation these changes are fixes; or >> (b) separate the fixes from improvements? >> >> Thank you! >> >> [1] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
Some improvements (manage syscfg as optional clock, update slew rate of ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) Fix warning build message when W=1 Christophe Roullier (5): net: ethernet: stmmac: Add support for syscfg clock net: ethernet: stmmac: fix warning when w=1 option is used during build ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet ARM: dts: stm32: adjust slew rate for Ethernet ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power mode on stm32mp157c arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 9 +++- arch/arm/boot/dts/stm32mp157c.dtsi | 7 ++-- .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 42 ++++++++++++------- 3 files changed, 38 insertions(+), 20 deletions(-)