| Message ID | 20190829073439.13069-1-andy.tang@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7eb3894b2fac978f811684e3ccb3cb0ad7820bef |
| Headers | show |
| Series | arm64: dts: ls1028a: fix a compatible issue | expand |
On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote: > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. > So correct it. Can elaborate the fix a little bit, saying what's the issue exactly with using that incorrect compatible? > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> Do we need a fix tag? Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index 5e14e5a19744..f5da9e8b0d9d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -107,7 +107,7 @@ > status = "okay"; > > i2c-mux@77 { > - compatible = "nxp,pca9847"; > + compatible = "nxp,pca9547"; > reg = <0x77>; > #address-cells = <1>; > #size-cells = <0>; > -- > 2.17.1 >
Hi Shawn, > -----Original Message----- > From: Shawn Guo <shawnguo@kernel.org> > Sent: 2019年9月14日 10:43 > To: Andy Tang <andy.tang@nxp.com> > Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org; > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue > > Caution: EXT Email > > On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote: > > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. > > So correct it. > > Can elaborate the fix a little bit, saying what's the issue exactly with using > that incorrect compatible? Ok. > > > > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > > Do we need a fix tag? What does "fix tag" mean? BR, Andy > > Shawn > > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > index 5e14e5a19744..f5da9e8b0d9d 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > > @@ -107,7 +107,7 @@ > > status = "okay"; > > > > i2c-mux@77 { > > - compatible = "nxp,pca9847"; > > + compatible = "nxp,pca9547"; > > reg = <0x77>; > > #address-cells = <1>; > > #size-cells = <0>; > > -- > > 2.17.1 > >
On Tue, Sep 24, 2019 at 08:00:29AM +0000, Andy Tang wrote: > Hi Shawn, > > > > -----Original Message----- > > From: Shawn Guo <shawnguo@kernel.org> > > Sent: 2019年9月14日 10:43 > > To: Andy Tang <andy.tang@nxp.com> > > Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org; > > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue > > > > Caution: EXT Email > > > > On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote: > > > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. > > > So correct it. > > > > Can elaborate the fix a little bit, saying what's the issue exactly with using > > that incorrect compatible? > Ok. > > > > > > > > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > > > > Do we need a fix tag? > What does "fix tag" mean? Please search 'Fixes' in Documentation/process/submitting-patches.rst. Shawn
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts index 5e14e5a19744..f5da9e8b0d9d 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts @@ -107,7 +107,7 @@ status = "okay"; i2c-mux@77 { - compatible = "nxp,pca9847"; + compatible = "nxp,pca9547"; reg = <0x77>; #address-cells = <1>; #size-cells = <0>;
The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. So correct it. Signed-off-by: Yuantian Tang <andy.tang@nxp.com> --- arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)