| Message ID | 20190924093609.22895-4-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: bus: simple-pm-bus, renesas-bsc: convert bindings to json-schema | expand |
Hello! On 09/24/2019 12:36 PM, Simon Horman wrote: > Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the > proposed binding description in json-schema which in turn reflects the ePAR It's ePAPR. BTW, you can now refer to DT spec itself instead -- it was based on ePAPR... > standard - "the name of a node should be somewhat generic, reflecting the > function of the device and not its precise programming model." > > Also drop the unit address as there is neither a reg property nor > non-empty ranges. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> [...] MBR, Sergei
On 09/24/2019 01:15 PM, Sergei Shtylyov wrote: >> Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the >> proposed binding description in json-schema which in turn reflects the ePAR > > It's ePAPR. BTW, you can now refer to DT spec itself instead -- it was based > on ePAPR... https://www.devicetree.org/specifications/ [...] MBR, Sergei
On Tue, Sep 24, 2019 at 01:18:30PM +0300, Sergei Shtylyov wrote: > On 09/24/2019 01:15 PM, Sergei Shtylyov wrote: > > >> Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the > >> proposed binding description in json-schema which in turn reflects the ePAR > > > > It's ePAPR. BTW, you can now refer to DT spec itself instead -- it was based > > on ePAPR... > > https://www.devicetree.org/specifications/ Thanks Sergei, how about this? arm64: dts: qcom: msm8996: Update simple-pm-bus node name to 'bus' Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the proposed binding description in json-schema which in turn reflects the Devicetree specification [1] v0.3-rc2. "The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. If appropriate, the name should be one of the following choices: ... * bus ..." Also drop the unit address as there is neither a reg property nor non-empty ranges. [1] https://www.devicetree.org/specifications/ Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Hello! On 26.09.2019 11:32, Simon Horman wrote: >>>> Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the >>>> proposed binding description in json-schema which in turn reflects the ePAR >>> >>> It's ePAPR. BTW, you can now refer to DT spec itself instead -- it was based >>> on ePAPR... >> >> https://www.devicetree.org/specifications/ > > Thanks Sergei, > > how about this? > > arm64: dts: qcom: msm8996: Update simple-pm-bus node name to 'bus' > > Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the > proposed binding description in json-schema which in turn reflects the > Devicetree specification [1] v0.3-rc2. > > "The name of a node should be somewhat generic, reflecting the function > of the device and not its precise programming model. If appropriate, > the name should be one of the following choices: > ... > * bus > ..." > > Also drop the unit address as there is neither a reg property nor > non-empty ranges. > > [1] https://www.devicetree.org/specifications/ > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Fine with me. MBR, Sergei
Hi Simon, On Tue, Sep 24, 2019 at 11:37 AM Simon Horman <horms+renesas@verge.net.au> wrote: > Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the > proposed binding description in json-schema which in turn reflects the ePAR > standard - "the name of a node should be somewhat generic, reflecting the > function of the device and not its precise programming model." > > Also drop the unit address as there is neither a reg property nor > non-empty ranges. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v2 > * New patch > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 96c0a481f454..99f376ebd27e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -1373,7 +1373,7 @@ > clock-names = "iface", "bus"; > }; > > - agnoc@0 { > + bus { > power-domains = <&gcc AGGRE0_NOC_GDSC>; > compatible = "simple-pm-bus"; > #address-cells = <1>; This file is included by arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi, which references agnoc@0, so you have to update that one as well, to avoid introducing silent breakages. Gr{oetje,eeting}s, Geert
On Thu, Sep 26, 2019 at 01:58:21PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Sep 24, 2019 at 11:37 AM Simon Horman > <horms+renesas@verge.net.au> wrote: > > Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the > > proposed binding description in json-schema which in turn reflects the ePAR > > standard - "the name of a node should be somewhat generic, reflecting the > > function of the device and not its precise programming model." > > > > Also drop the unit address as there is neither a reg property nor > > non-empty ranges. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > v2 > > * New patch > > --- > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > index 96c0a481f454..99f376ebd27e 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > @@ -1373,7 +1373,7 @@ > > clock-names = "iface", "bus"; > > }; > > > > - agnoc@0 { > > + bus { > > power-domains = <&gcc AGGRE0_NOC_GDSC>; > > compatible = "simple-pm-bus"; > > #address-cells = <1>; > > This file is included by arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi, > which references agnoc@0, so you have to update that one as well, > to avoid introducing silent breakages. Thanks, will do.
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 96c0a481f454..99f376ebd27e 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -1373,7 +1373,7 @@ clock-names = "iface", "bus"; }; - agnoc@0 { + bus { power-domains = <&gcc AGGRE0_NOC_GDSC>; compatible = "simple-pm-bus"; #address-cells = <1>;
Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the proposed binding description in json-schema which in turn reflects the ePAR standard - "the name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model." Also drop the unit address as there is neither a reg property nor non-empty ranges. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * New patch --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)