| Message ID | 20190924125334.5543-1-yangerkun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | io_uring: compare cached_cq_tail with cq.head in_io_uring_poll | expand |
On 9/24/19 6:53 AM, yangerkun wrote: > After 75b28af("io_uring: allocate the two rings together"), we compare > sq.head with cached_cq_tail to determine does there any cq invalid. > Actually, we should use cq.head. Nice catch, applied. BTW, note for future submissions, this: > Fixes: 75b28af ("io_uring: allocate the two rings together") sha should be 12 characters. I will fix it up in this one.
diff --git a/fs/io_uring.c b/fs/io_uring.c index 0dadbdbead0f..63cbefba1fb5 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -3263,7 +3263,7 @@ static __poll_t io_uring_poll(struct file *file, poll_table *wait) if (READ_ONCE(ctx->rings->sq.tail) - ctx->cached_sq_head != ctx->rings->sq_ring_entries) mask |= EPOLLOUT | EPOLLWRNORM; - if (READ_ONCE(ctx->rings->sq.head) != ctx->cached_cq_tail) + if (READ_ONCE(ctx->rings->cq.head) != ctx->cached_cq_tail) mask |= EPOLLIN | EPOLLRDNORM; return mask;
After 75b28af("io_uring: allocate the two rings together"), we compare sq.head with cached_cq_tail to determine does there any cq invalid. Actually, we should use cq.head. Fixes: 75b28af ("io_uring: allocate the two rings together") Signed-off-by: yangerkun <yangerkun@huawei.com> --- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)