mbox

[PULL,0/7] Python (acceptance tests) queue - 2019-09-23

Message ID 20190923134019.8548-1-crosa@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

git://github.com/clebergnu/qemu.git tags/python-next-pull-request

Message

Cleber Rosa Sept. 23, 2019, 1:40 p.m. UTC 
The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad:

  Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' into staging (2019-09-20 17:28:43 +0100)

are available in the Git repository at:

  git://github.com/clebergnu/qemu.git tags/python-next-pull-request

for you to fetch changes up to 2fe6f4d9babb957244676fdf23b9a7ca2323034b:

  Acceptance tests: use avocado.utils.ssh for SSH interaction (2019-09-20 17:13:41 -0400)

----------------------------------------------------------------
Improvements include:

 * Relaxed error code pattern on machine_m68k_nextcube.py
 * Better naming and separation of tests in x86_cpu_model_versions.py
 * New checks on guest side on linux_ssh_mips_malta.py
 * Use of avocado.utils.ssh, and thus "/usr/bin/ssh" for SSH
   interaction

A Travis-CI check for this branch can be seen at:

 * https://travis-ci.org/clebergnu/qemu/builds/587665790

----------------------------------------------------------------

Aleksandar Markovic (2):
  tests/acceptance: Refactor and improve reporting in
    linux_ssh_mips_malta.py
  tests/acceptance: Add new test cases in linux_ssh_mips_malta.py

Cleber Rosa (5):
  Acceptance test machine_m68k_nextcube.py: relax the error code pattern
  Acceptance test x86_cpu_model_versions: shutdown VMs
  Acceptance test x86_cpu_model_versions: fix mismatches between test
    and messages
  Acceptance test x86_cpu_model_versions: split into smaller tests
  Acceptance tests: use avocado.utils.ssh for SSH interaction

 tests/acceptance/linux_ssh_mips_malta.py   | 159 ++++++++++++---------
 tests/acceptance/machine_m68k_nextcube.py  |   2 +-
 tests/acceptance/x86_cpu_model_versions.py |  22 ++-
 tests/requirements.txt                     |   3 +-
 4 files changed, 110 insertions(+), 76 deletions(-)

Comments

no-reply@patchew.org Sept. 23, 2019, 7:54 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-crosa@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190923134019.8548-1-crosa@redhat.com
Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
b200b91 Acceptance tests: use avocado.utils.ssh for SSH interaction
333b8f1 tests/acceptance: Add new test cases in linux_ssh_mips_malta.py
cb9e32e tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py
c5b436a Acceptance test x86_cpu_model_versions: split into smaller tests
eb9f595 Acceptance test x86_cpu_model_versions: fix mismatches between test and messages
8bbd882 Acceptance test x86_cpu_model_versions: shutdown VMs
c5f67b5 Acceptance test machine_m68k_nextcube.py: relax the error code pattern

=== OUTPUT BEGIN ===
1/7 Checking commit c5f67b555dad (Acceptance test machine_m68k_nextcube.py: relax the error code pattern)
2/7 Checking commit 8bbd8828cf1e (Acceptance test x86_cpu_model_versions: shutdown VMs)
3/7 Checking commit eb9f595504b2 (Acceptance test x86_cpu_model_versions: fix mismatches between test and messages)
ERROR: line over 90 characters
#25: FILE: tests/acceptance/x86_cpu_model_versions.py:283:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v1 should not have arch-capabilities')

ERROR: line over 90 characters
#34: FILE: tests/acceptance/x86_cpu_model_versions.py:292:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v2 should have arch-capabilities')

ERROR: line over 90 characters
#42: FILE: tests/acceptance/x86_cpu_model_versions.py:299:
+        vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off,+arch-capabilities')

total: 3 errors, 0 warnings, 24 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit c5b436a0666a (Acceptance test x86_cpu_model_versions: split into smaller tests)
5/7 Checking commit cb9e32eca764 (tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py)
6/7 Checking commit 333b8f13665e (tests/acceptance: Add new test cases in linux_ssh_mips_malta.py)
7/7 Checking commit b200b916e0e8 (Acceptance tests: use avocado.utils.ssh for SSH interaction)
WARNING: line over 80 characters
#126: FILE: tests/acceptance/linux_ssh_mips_malta.py:85:
+        stdout_lines = [line.rstrip() for line in result.stdout_text.splitlines()]

WARNING: line over 80 characters
#130: FILE: tests/acceptance/linux_ssh_mips_malta.py:88:
+        stderr_lines = [line.rstrip() for line in result.stderr_text.splitlines()]

total: 0 errors, 2 warnings, 158 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190923134019.8548-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Sept. 24, 2019, 1:26 a.m. UTC | #2 
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-crosa@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190923134019.8548-1-crosa@redhat.com
Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
95d8aed Acceptance tests: use avocado.utils.ssh for SSH interaction
b5d62a1 tests/acceptance: Add new test cases in linux_ssh_mips_malta.py
41b8da1 tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py
9dbf0de Acceptance test x86_cpu_model_versions: split into smaller tests
a3bdbf3 Acceptance test x86_cpu_model_versions: fix mismatches between test and messages
4423807 Acceptance test x86_cpu_model_versions: shutdown VMs
e3d4392 Acceptance test machine_m68k_nextcube.py: relax the error code pattern

=== OUTPUT BEGIN ===
1/7 Checking commit e3d43927ffb3 (Acceptance test machine_m68k_nextcube.py: relax the error code pattern)
2/7 Checking commit 44238078fcde (Acceptance test x86_cpu_model_versions: shutdown VMs)
3/7 Checking commit a3bdbf35dd33 (Acceptance test x86_cpu_model_versions: fix mismatches between test and messages)
ERROR: line over 90 characters
#25: FILE: tests/acceptance/x86_cpu_model_versions.py:283:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v1 should not have arch-capabilities')

ERROR: line over 90 characters
#34: FILE: tests/acceptance/x86_cpu_model_versions.py:292:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v2 should have arch-capabilities')

ERROR: line over 90 characters
#42: FILE: tests/acceptance/x86_cpu_model_versions.py:299:
+        vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off,+arch-capabilities')

total: 3 errors, 0 warnings, 24 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit 9dbf0de5f7d5 (Acceptance test x86_cpu_model_versions: split into smaller tests)
5/7 Checking commit 41b8da1921af (tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py)
6/7 Checking commit b5d62a1def54 (tests/acceptance: Add new test cases in linux_ssh_mips_malta.py)
7/7 Checking commit 95d8aed259c8 (Acceptance tests: use avocado.utils.ssh for SSH interaction)
WARNING: line over 80 characters
#126: FILE: tests/acceptance/linux_ssh_mips_malta.py:85:
+        stdout_lines = [line.rstrip() for line in result.stdout_text.splitlines()]

WARNING: line over 80 characters
#130: FILE: tests/acceptance/linux_ssh_mips_malta.py:88:
+        stderr_lines = [line.rstrip() for line in result.stderr_text.splitlines()]

total: 0 errors, 2 warnings, 158 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190923134019.8548-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Sept. 24, 2019, 8:10 a.m. UTC | #3 
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-crosa@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190923134019.8548-1-crosa@redhat.com
Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
586193c Acceptance tests: use avocado.utils.ssh for SSH interaction
73df413 tests/acceptance: Add new test cases in linux_ssh_mips_malta.py
cfc25f3 tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py
4661118 Acceptance test x86_cpu_model_versions: split into smaller tests
2fb1036 Acceptance test x86_cpu_model_versions: fix mismatches between test and messages
f5e5d96 Acceptance test x86_cpu_model_versions: shutdown VMs
0c13726 Acceptance test machine_m68k_nextcube.py: relax the error code pattern

=== OUTPUT BEGIN ===
1/7 Checking commit 0c137262db6e (Acceptance test machine_m68k_nextcube.py: relax the error code pattern)
2/7 Checking commit f5e5d9617fe9 (Acceptance test x86_cpu_model_versions: shutdown VMs)
3/7 Checking commit 2fb10362a8ed (Acceptance test x86_cpu_model_versions: fix mismatches between test and messages)
ERROR: line over 90 characters
#25: FILE: tests/acceptance/x86_cpu_model_versions.py:283:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v1 should not have arch-capabilities')

ERROR: line over 90 characters
#34: FILE: tests/acceptance/x86_cpu_model_versions.py:292:
+                         'pc-i440fx-4.0 + Cascadelake-Server-v2 should have arch-capabilities')

ERROR: line over 90 characters
#42: FILE: tests/acceptance/x86_cpu_model_versions.py:299:
+        vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off,+arch-capabilities')

total: 3 errors, 0 warnings, 24 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit 4661118c3be7 (Acceptance test x86_cpu_model_versions: split into smaller tests)
5/7 Checking commit cfc25f3d2559 (tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py)
6/7 Checking commit 73df413e17b2 (tests/acceptance: Add new test cases in linux_ssh_mips_malta.py)
7/7 Checking commit 586193c82d14 (Acceptance tests: use avocado.utils.ssh for SSH interaction)
WARNING: line over 80 characters
#126: FILE: tests/acceptance/linux_ssh_mips_malta.py:85:
+        stdout_lines = [line.rstrip() for line in result.stdout_text.splitlines()]

WARNING: line over 80 characters
#130: FILE: tests/acceptance/linux_ssh_mips_malta.py:88:
+        stderr_lines = [line.rstrip() for line in result.stderr_text.splitlines()]

total: 0 errors, 2 warnings, 158 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190923134019.8548-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Sept. 24, 2019, 12:49 p.m. UTC | #4 
On Mon, 23 Sep 2019 at 14:40, Cleber Rosa <crosa@redhat.com> wrote:
>
> The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad:
>
>   Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' into staging (2019-09-20 17:28:43 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/clebergnu/qemu.git tags/python-next-pull-request
>
> for you to fetch changes up to 2fe6f4d9babb957244676fdf23b9a7ca2323034b:
>
>   Acceptance tests: use avocado.utils.ssh for SSH interaction (2019-09-20 17:13:41 -0400)
>
> ----------------------------------------------------------------
> Improvements include:
>
>  * Relaxed error code pattern on machine_m68k_nextcube.py
>  * Better naming and separation of tests in x86_cpu_model_versions.py
>  * New checks on guest side on linux_ssh_mips_malta.py
>  * Use of avocado.utils.ssh, and thus "/usr/bin/ssh" for SSH
>    interaction
>
> A Travis-CI check for this branch can be seen at:
>
>  * https://travis-ci.org/clebergnu/qemu/builds/587665790
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM