| Message ID | 1569484721-4424-1-git-send-email-pawell@cadence.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9816144313d33974bbd4599d4e8e554c11cae27e |
| Headers | show |
| Series | [v3,-next] usb: cdns3: Fix sheduling with locks held. | expand |
On Thu, Sep 26, 2019 at 6:26 PM Pawel Laszczak <pawell@cadence.com> wrote: > > Patch fix issue in cdns3_ep0_feature_handle_device function. > > The function usleep_range can't be used there because this function is > called with locks held and IRQs disabled in > cdns3_device_thread_irq_handler(). > > To resolve this issue patch replaces usleep_range with mdelay. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") > --- > v2: added Reported-by and Fixes tags > v3: added version of the patch > --- > drivers/usb/cdns3/ep0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c > index 44f652e8b5a2..0445da0a5a0c 100644 > --- a/drivers/usb/cdns3/ep0.c > +++ b/drivers/usb/cdns3/ep0.c > @@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev, > * for sending status stage. > * This time should be less then 3ms. > */ > - usleep_range(1000, 2000); > + mdelay(1); > cdns3_set_register_bit(&priv_dev->regs->usb_cmd, > USB_CMD_STMODE | > USB_STS_TMODE_SEL(tmode - 1)); > -- > 2.17.1 > Reviewed-by: Peter Chen <peter.chen@nxp.com> Peter
diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index 44f652e8b5a2..0445da0a5a0c 100644 --- a/drivers/usb/cdns3/ep0.c +++ b/drivers/usb/cdns3/ep0.c @@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev, * for sending status stage. * This time should be less then 3ms. */ - usleep_range(1000, 2000); + mdelay(1); cdns3_set_register_bit(&priv_dev->regs->usb_cmd, USB_CMD_STMODE | USB_STS_TMODE_SEL(tmode - 1));
Patch fix issue in cdns3_ep0_feature_handle_device function. The function usleep_range can't be used there because this function is called with locks held and IRQs disabled in cdns3_device_thread_irq_handler(). To resolve this issue patch replaces usleep_range with mdelay. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") --- v2: added Reported-by and Fixes tags v3: added version of the patch --- drivers/usb/cdns3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1