diff mbox series

[4/4] arm64: dts: renesas: Add HiHope RZ/G2N main board support

Message ID 1568725530-55241-5-git-send-email-biju.das@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series Add HiHope RZ/G2N main board support | expand

Commit Message

Biju Das Sept. 17, 2019, 1:05 p.m. UTC 
Basic support for the HiHope RZ/G2N main board:
  - Memory,
  - Main crystal,
  - Serial console

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/Makefile               |  1 +
 .../boot/dts/renesas/r8a774b1-hihope-rzg2n.dts     | 26 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts

Comments

Geert Uytterhoeven Sept. 27, 2019, 12:38 p.m. UTC | #1 
Hi Biju,

On Tue, Sep 17, 2019 at 3:12 PM Biju Das <biju.das@bp.renesas.com> wrote:
> Basic support for the HiHope RZ/G2N main board:
>   - Memory,
>   - Main crystal,
>   - Serial console
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

One question below...

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device Tree Source for the HiHope RZ/G2N main board
> + *
> + * Copyright (C) 2019 Renesas Electronics Corp.
> + */
> +
> +/dts-v1/;
> +#include "r8a774b1.dtsi"
> +#include "hihope-common.dtsi"
> +
> +/ {
> +       model = "HopeRun HiHope RZ/G2N main board based on r8a774b1";
> +       compatible = "hoperun,hihope-rzg2n", "renesas,r8a774b1";
> +
> +       memory@48000000 {
> +               device_type = "memory";
> +               /* first 128MB is reserved for secure area. */
> +               reg = <0x0 0x48000000 0x0 0x78000000>;
> +       };
> +
> +       memory@480000000 {
> +               device_type = "memory";
> +               reg = <0x4 0x80000000 0x0 0x80000000>;
> +       };
> +};

So both the HiHope RZ/G2M and RZ/G2N boards have 4 GiB of RAM, while
the latter has a narrower memory bus, so it must be wired differently?

Gr{oetje,eeting}s,

                        Geert
Biju Das Sept. 27, 2019, 12:56 p.m. UTC | #2 
Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 4/4] arm64: dts: renesas: Add HiHope RZ/G2N main
> board support
> 
> Hi Biju,
> 
> On Tue, Sep 17, 2019 at 3:12 PM Biju Das <biju.das@bp.renesas.com> wrote:
> > Basic support for the HiHope RZ/G2N main board:
> >   - Memory,
> >   - Main crystal,
> >   - Serial console
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> One question below...
> 
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts
> > @@ -0,0 +1,26 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree Source for the HiHope RZ/G2N main board
> > + *
> > + * Copyright (C) 2019 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +#include "r8a774b1.dtsi"
> > +#include "hihope-common.dtsi"
> > +
> > +/ {
> > +       model = "HopeRun HiHope RZ/G2N main board based on r8a774b1";
> > +       compatible = "hoperun,hihope-rzg2n", "renesas,r8a774b1";
> > +
> > +       memory@48000000 {
> > +               device_type = "memory";
> > +               /* first 128MB is reserved for secure area. */
> > +               reg = <0x0 0x48000000 0x0 0x78000000>;
> > +       };
> > +
> > +       memory@480000000 {
> > +               device_type = "memory";
> > +               reg = <0x4 0x80000000 0x0 0x80000000>;
> > +       };
> > +};
> 
> So both the HiHope RZ/G2M and RZ/G2N boards have 4 GiB of RAM, while
> the latter has a narrower memory bus, so it must be wired differently?

RZ/G2M is LPDDR4-3200 with 32 bits × 2 channels,  where as RZ/G2N is LPDDR4-3200 with 32 bits × 1 channel.
RZ/G2M can have split mapping where as RZ/G2N can have only linear mapping.

Regards,
Biju
Geert Uytterhoeven Sept. 27, 2019, 1:41 p.m. UTC | #3 
Hi Biju,

On Fri, Sep 27, 2019 at 2:56 PM Biju Das <biju.das@bp.renesas.com> wrote:
> > Subject: Re: [PATCH 4/4] arm64: dts: renesas: Add HiHope RZ/G2N main
> > board support
> > On Tue, Sep 17, 2019 at 3:12 PM Biju Das <biju.das@bp.renesas.com> wrote:
> > > Basic support for the HiHope RZ/G2N main board:
> > >   - Memory,
> > >   - Main crystal,
> > >   - Serial console
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > One question below...
> >
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts
> > > @@ -0,0 +1,26 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Device Tree Source for the HiHope RZ/G2N main board
> > > + *
> > > + * Copyright (C) 2019 Renesas Electronics Corp.
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "r8a774b1.dtsi"
> > > +#include "hihope-common.dtsi"
> > > +
> > > +/ {
> > > +       model = "HopeRun HiHope RZ/G2N main board based on r8a774b1";
> > > +       compatible = "hoperun,hihope-rzg2n", "renesas,r8a774b1";
> > > +
> > > +       memory@48000000 {
> > > +               device_type = "memory";
> > > +               /* first 128MB is reserved for secure area. */
> > > +               reg = <0x0 0x48000000 0x0 0x78000000>;
> > > +       };
> > > +
> > > +       memory@480000000 {
> > > +               device_type = "memory";
> > > +               reg = <0x4 0x80000000 0x0 0x80000000>;
> > > +       };
> > > +};
> >
> > So both the HiHope RZ/G2M and RZ/G2N boards have 4 GiB of RAM, while
> > the latter has a narrower memory bus, so it must be wired differently?
>
> RZ/G2M is LPDDR4-3200 with 32 bits × 2 channels,  where as RZ/G2N is LPDDR4-3200 with 32 bits × 1 channel.
> RZ/G2M can have split mapping where as RZ/G2N can have only linear mapping.

Thanks for the confirmation, will queue in renesas-devel for v5.5.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 42b74c2..3a6a0fb 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,6 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex.dtb
+dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n.dtb
 dtb-$(CONFIG_ARCH_R8A774C0) += r8a774c0-cat874.dtb r8a774c0-ek874.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-h3ulcb-kf.dtb
diff --git a/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts b/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts
new file mode 100644
index 0000000..094b5ef
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n.dts
@@ -0,0 +1,26 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the HiHope RZ/G2N main board
+ *
+ * Copyright (C) 2019 Renesas Electronics Corp.
+ */
+
+/dts-v1/;
+#include "r8a774b1.dtsi"
+#include "hihope-common.dtsi"
+
+/ {
+	model = "HopeRun HiHope RZ/G2N main board based on r8a774b1";
+	compatible = "hoperun,hihope-rzg2n", "renesas,r8a774b1";
+
+	memory@48000000 {
+		device_type = "memory";
+		/* first 128MB is reserved for secure area. */
+		reg = <0x0 0x48000000 0x0 0x78000000>;
+	};
+
+	memory@480000000 {
+		device_type = "memory";
+		reg = <0x4 0x80000000 0x0 0x80000000>;
+	};
+};