| Message ID | 20191001080253.6135-2-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: dsi: misc timing fixes | expand |
On Tue, Oct 1, 2019 at 1:33 PM Icenowy Zheng <icenowy@aosc.io> wrote: > > This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2. > > The original commit adds a start parameter to the calculation of the > start delay according to some old BSP versions from Allwinner. However, > there're two ways to add this delay -- add it in DSI controller or add > it in the TCON. Add it in both controllers won't work. > > The code before this commit is picked from new versions of BSP kernel, > which has a comment for the 1 that says "put start_delay to tcon". By > checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it has > already added this delay, so we shouldn't repeat to add the delay in DSI > controller, otherwise the timing won't match. Thanks for this change. look like this is proper reason for adding + 1. also adding bsp code links here might help for future reference. Otherwise, Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
On Thu, Oct 03, 2019 at 12:38:43PM +0530, Jagan Teki wrote: > On Tue, Oct 1, 2019 at 1:33 PM Icenowy Zheng <icenowy@aosc.io> wrote: > > > > This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2. > > > > The original commit adds a start parameter to the calculation of the > > start delay according to some old BSP versions from Allwinner. However, > > there're two ways to add this delay -- add it in DSI controller or add > > it in the TCON. Add it in both controllers won't work. > > > > The code before this commit is picked from new versions of BSP kernel, > > which has a comment for the 1 that says "put start_delay to tcon". By > > checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it has > > already added this delay, so we shouldn't repeat to add the delay in DSI > > controller, otherwise the timing won't match. > > Thanks for this change. look like this is proper reason for adding + > 1. also adding bsp code links here might help for future reference. > > Otherwise, > > Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> The commit log was better in this one. I ended up merging this one, with your R-b. Maxime
于 2019年10月3日 GMT+08:00 下午9:19:16, Maxime Ripard <mripard@kernel.org> 写到: >On Thu, Oct 03, 2019 at 12:38:43PM +0530, Jagan Teki wrote: >> On Tue, Oct 1, 2019 at 1:33 PM Icenowy Zheng <icenowy@aosc.io> wrote: >> > >> > This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2. >> > >> > The original commit adds a start parameter to the calculation of >the >> > start delay according to some old BSP versions from Allwinner. >However, >> > there're two ways to add this delay -- add it in DSI controller or >add >> > it in the TCON. Add it in both controllers won't work. >> > >> > The code before this commit is picked from new versions of BSP >kernel, >> > which has a comment for the 1 that says "put start_delay to tcon". >By >> > checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it >has >> > already added this delay, so we shouldn't repeat to add the delay >in DSI >> > controller, otherwise the timing won't match. >> >> Thanks for this change. look like this is proper reason for adding + >> 1. also adding bsp code links here might help for future reference. >> >> Otherwise, >> >> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> > >The commit log was better in this one. I ended up merging this one, >with your R-b. Please note that Jagan's v11 3/7 is still needed. > >Maxime
On Thu, Oct 03, 2019 at 09:21:30PM +0800, Icenowy Zheng wrote: > > > 于 2019年10月3日 GMT+08:00 下午9:19:16, Maxime Ripard <mripard@kernel.org> 写到: > >On Thu, Oct 03, 2019 at 12:38:43PM +0530, Jagan Teki wrote: > >> On Tue, Oct 1, 2019 at 1:33 PM Icenowy Zheng <icenowy@aosc.io> wrote: > >> > > >> > This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2. > >> > > >> > The original commit adds a start parameter to the calculation of > >the > >> > start delay according to some old BSP versions from Allwinner. > >However, > >> > there're two ways to add this delay -- add it in DSI controller or > >add > >> > it in the TCON. Add it in both controllers won't work. > >> > > >> > The code before this commit is picked from new versions of BSP > >kernel, > >> > which has a comment for the 1 that says "put start_delay to tcon". > >By > >> > checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it > >has > >> > already added this delay, so we shouldn't repeat to add the delay > >in DSI > >> > controller, otherwise the timing won't match. > >> > >> Thanks for this change. look like this is proper reason for adding + > >> 1. also adding bsp code links here might help for future reference. > >> > >> Otherwise, > >> > >> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> > > > >The commit log was better in this one. I ended up merging this one, > >with your R-b. > > Please note that Jagan's v11 3/7 is still needed. Right, unfortunately, it doesn't apply anymore. Jagan, can you send that patch rebased? Thanks! Maxime
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 1636344ba9ec..c86e11631ebc 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -365,8 +365,7 @@ static void sun6i_dsi_inst_init(struct sun6i_dsi *dsi, static u16 sun6i_dsi_get_video_start_delay(struct sun6i_dsi *dsi, struct drm_display_mode *mode) { - u16 start = clamp(mode->vtotal - mode->vdisplay - 10, 8, 100); - u16 delay = mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; + u16 delay = mode->vtotal - (mode->vsync_end - mode->vdisplay) + 1; if (delay > mode->vtotal) delay = delay % mode->vtotal;
This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2. The original commit adds a start parameter to the calculation of the start delay according to some old BSP versions from Allwinner. However, there're two ways to add this delay -- add it in DSI controller or add it in the TCON. Add it in both controllers won't work. The code before this commit is picked from new versions of BSP kernel, which has a comment for the 1 that says "put start_delay to tcon". By checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it has already added this delay, so we shouldn't repeat to add the delay in DSI controller, otherwise the timing won't match. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)