Message ID | 20191002161851.1016-1-kwolf@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20191002161851.1016-1-kwolf@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === -Testing: -QEMU X.Y.Z monitor - type 'help' for more information -(qemu) savevm snap0 -Error: No block device can accept snapshots -(qemu) info snapshots -No available block device supports snapshots -(qemu) loadvm snap0 -Error: No block device supports snapshots -(qemu) quit +Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]... --- -Testing: -drive driver=file,file=TEST_DIR/t.IMGFMT,if=none -QEMU X.Y.Z monitor - type 'help' for more information -(qemu) savevm snap0 -Error: Device 'none0' is writable but does not support snapshots -(qemu) info snapshots -No available block device supports snapshots -(qemu) loadvm snap0 -Error: Device 'none0' is writable but does not support snapshots -(qemu) quit - -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 --- -Testing: -drive driver=file,file=TEST_DIR/t.IMGFMT,if=virtio -QEMU X.Y.Z monitor - type 'help' for more information -(qemu) savevm snap0 -Error: Device 'virtio0' is writable but does not support snapshots -(qemu) info snapshots -No available block device supports snapshots -(qemu) loadvm snap0 -Error: Device 'virtio0' is writable but does not support snapshots -(qemu) quit - -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 --- -Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -QEMU X.Y.Z monitor - type 'help' for more information -(qemu) savevm snap0 -Error: Device '' is writable but does not support snapshots -(qemu) info snapshots -No available block device supports snapshots -(qemu) loadvm snap0 -Error: Device '' is writable but does not support snapshots -(qemu) quit - -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 --- *** done Failures: 267 Failed 1 of 108 iotests make: *** [check-tests/check-block.sh] Error 1 Traceback (most recent call last): File "./tests/docker/docker.py", line 662, in <module> sys.exit(main()) --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=92726187a0bd495c9bd9618f815ba7bb', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-irvd3y2z/src/docker-src.2019-10-02-13.08.52.15131:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=92726187a0bd495c9bd9618f815ba7bb make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-irvd3y2z/src' make: *** [docker-run-test-quick@centos7] Error 2 real 9m50.205s user 0m8.303s The full log is available at http://patchew.org/logs/20191002161851.1016-1-kwolf@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Wed, 2 Oct 2019 at 17:18, Kevin Wolf <kwolf@redhat.com> wrote: > > The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to 352492e5541e293ea8117412ffd171ce1c7ac15d: > > iotests: Remove Python 2 compatibility code (2019-10-02 16:47:23 +0200) > > ---------------------------------------------------------------- > Block layer patches: > > - Fix internal snapshots with typical -blockdev setups > - iotests: Require Python 3.6 or later > > ---------------------------------------------------------------- > Kevin Wolf (4): > block/snapshot: Restrict set of snapshot nodes > iotests: Test internal snapshots with -blockdev > iotests: Require Python 3.6 or later > iotests: Remove Python 2 compatibility code Hi. This failed on iotest 267 on the ppc build machine I test on, in the same way that the patchew report for centos7 failed: --- /home/pm215/qemu/tests/qemu-iotests/267.out 2019-10-03 15:35:50.099974113 +0000 +++ /home/pm215/qemu/build/all/tests/qemu-iotests/267.out.bad 2019-10-03 15:41:46.190579461 +0000 @@ -3,180 +3,770 @@ === No block devices at all === Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 -Testing: -QEMU X.Y.Z monitor - type 'help' for more information -(qemu) savevm snap0 -Error: No block device can accept snapshots -(qemu) info snapshots -No available block device supports snapshots -(qemu) loadvm snap0 -Error: No block device supports snapshots -(qemu) quit +Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]... + -n, --quiet, --silent + suppress automatic printing of pattern space + -e script, --expression=script + add the script to the commands to be executed [etc] The machine is running 'sed (GNU sed) 4.2.2'. It looks like this version of sed doesn't like it if you specify '-r' twice, as you have done in the _filter_vmstate_size() function in common.filter in the "iotests: Test internal snapshots with -blockdev" patch. I think '-r' is supposed to apply to all scripts in the sed invocation; if that's correct then a command line like '-re thing1 -re thing2' is confusing and would be better written '-r -e thing1 -e thing2' even if this older sed didn't complain about it. thanks -- PMM