| Message ID | 20191001112421.2778-8-ribalda@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Implement UNIT_CELL_SIZE control | expand |
On 10/1/19 1:24 PM, Ricardo Ribalda Delgado wrote: > This helper function simplifies the code by not needing a union > v4l2_ctrl_ptr and an assignment every time we need to use > a ctrl_ptr. > > Suggested-by: Hans Verkuil <hverkuil@xs4all.nl> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org> > --- > include/media/v4l2-ctrls.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h > index c42f164e2c9e..51d74fa7c7e2 100644 > --- a/include/media/v4l2-ctrls.h > +++ b/include/media/v4l2-ctrls.h > @@ -73,6 +73,18 @@ union v4l2_ctrl_ptr { > void *p; > }; > > +/** > + * v4l2_ctrl_ptr_create() - Helper function to return a v4l2_ctrl_ptr from a > + * void pointer > + * @ptr: The void pointer > + */ > +static inline union v4l2_ctrl_ptr v4l2_ctrl_ptr_create(void *ptr) > +{ > + union v4l2_ctrl_ptr p = {.p = ptr}; Nitpick: add space after { and before } Regards, Hans > + > + return p; > +} > + > /** > * struct v4l2_ctrl_ops - The control operations that the driver has to provide. > * >
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index c42f164e2c9e..51d74fa7c7e2 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h @@ -73,6 +73,18 @@ union v4l2_ctrl_ptr { void *p; }; +/** + * v4l2_ctrl_ptr_create() - Helper function to return a v4l2_ctrl_ptr from a + * void pointer + * @ptr: The void pointer + */ +static inline union v4l2_ctrl_ptr v4l2_ctrl_ptr_create(void *ptr) +{ + union v4l2_ctrl_ptr p = {.p = ptr}; + + return p; +} + /** * struct v4l2_ctrl_ops - The control operations that the driver has to provide. *
This helper function simplifies the code by not needing a union v4l2_ctrl_ptr and an assignment every time we need to use a ctrl_ptr. Suggested-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org> --- include/media/v4l2-ctrls.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)