| Message ID | 20191007135933.12483-2-leon@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Leon Romanovsky |
| Headers | show |
| Series | Optimize SGL registration | expand |
On 10/7/19 6:59 AM, Leon Romanovsky wrote: > - u8 reserved_at_c0[0x8]; > + u8 max_sgl_for_optimized_performance[0x8]; Should the name of this member variable perhaps be changed into "max_sgl_for_optimal_performance"? Thanks, Bart.
On Mon, Oct 07, 2019 at 08:02:50AM -0700, Bart Van Assche wrote: > On 10/7/19 6:59 AM, Leon Romanovsky wrote: > > - u8 reserved_at_c0[0x8]; > > + u8 max_sgl_for_optimized_performance[0x8]; > > Should the name of this member variable perhaps be changed into > "max_sgl_for_optimal_performance"? We don't want to force our internal HW/FW names on all uverbs users and drivers. So, the answer is no, it is used for optimized performance, but it is not the proper name for uverbs. Thanks > > Thanks, > > Bart.
On Mon, Oct 07, 2019 at 04:59:31PM +0300, Leon Romanovsky wrote: > From: Yamin Friedman <yaminf@mellanox.com> > > Expose maximum scatter entries per RDMA READ for optimal performance. > > Signed-off-by: Yamin Friedman <yaminf@mellanox.com> > Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > --- > include/linux/mlx5/mlx5_ifc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I'm taking this patch to mlx5-next, since it is not controversial. Thanks
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 138c50d5a353..c0bfb1d90dd2 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -1153,7 +1153,7 @@ struct mlx5_ifc_cmd_hca_cap_bits { u8 log_max_srq[0x5]; u8 reserved_at_b0[0x10]; - u8 reserved_at_c0[0x8]; + u8 max_sgl_for_optimized_performance[0x8]; u8 log_max_cq_sz[0x8]; u8 reserved_at_d0[0xb]; u8 log_max_cq[0x5];