| Message ID | 20191007070844.14212-2-Mark-MC.Lee@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Update MT7629 to support PHYLINK API | expand |
Quoting MarkLee <Mark-MC.Lee@mediatek.com>: > Add missing configuration for mt7629 gmii mode support > > Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII") > Signed-off-by: MarkLee <Mark-MC.Lee@mediatek.com> > -- > v1->v2: > * no change > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index c61069340f4f..703adb96429e 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -261,6 +261,7 @@ static void mtk_mac_config(struct phylink_config > *config, unsigned int mode, > ge_mode = 0; > switch (state->interface) { > case PHY_INTERFACE_MODE_MII: > + case PHY_INTERFACE_MODE_GMII: > ge_mode = 1; > break; > case PHY_INTERFACE_MODE_REVMII: > -- > 2.17.1 Reviewed-by: René van Dorst <opensource@vdorst.com>
On Mon, 7 Oct 2019 15:08:43 +0800, MarkLee wrote: > Add missing configuration for mt7629 gmii mode support > > Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII") Thank you for adding the Fixes tag. It seem, however, that the patch in question did not change the ge_mode setting. Is it because GMII now makes a call to mtk_gmac_gephy_path_setup() that the different setting is required? The Fixes tag should point to the commit which introduced the wrong behaviour, it may be the initial commit of the driver if the behaviour was always there. Could you add more information to the patch description and perhaps update Fixes tag if 7e538372694b didn't introduce the problem?
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index c61069340f4f..703adb96429e 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -261,6 +261,7 @@ static void mtk_mac_config(struct phylink_config *config, unsigned int mode, ge_mode = 0; switch (state->interface) { case PHY_INTERFACE_MODE_MII: + case PHY_INTERFACE_MODE_GMII: ge_mode = 1; break; case PHY_INTERFACE_MODE_REVMII:
Add missing configuration for mt7629 gmii mode support Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII") Signed-off-by: MarkLee <Mark-MC.Lee@mediatek.com> -- v1->v2: * no change --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + 1 file changed, 1 insertion(+)